mirror of
https://github.com/FFmpeg/FFmpeg.git
synced 2024-11-26 19:01:44 +02:00
8be701d9f7
Up until now, an AVFilter's lists of input and output AVFilterPads were terminated by a sentinel and the only way to get the length of these lists was by using avfilter_pad_count(). This has two drawbacks: first, sizeof(AVFilterPad) is not negligible (i.e. 64B on 64bit systems); second, getting the size involves a function call instead of just reading the data. This commit therefore changes this. The sentinels are removed and new private fields nb_inputs and nb_outputs are added to AVFilter that contain the number of elements of the respective AVFilterPad array. Given that AVFilter.(in|out)puts are the only arrays of zero-terminated AVFilterPads an API user has access to (AVFilterContext.(in|out)put_pads are not zero-terminated and they already have a size field) the argument to avfilter_pad_count() is always one of these lists, so it just has to find the filter the list belongs to and read said number. This is slower than before, but a replacement function that just reads the internal numbers that users are expected to switch to will be added soon; and furthermore, avfilter_pad_count() is probably never called in hot loops anyway. This saves about 49KiB from the binary; notice that these sentinels are not in .bss despite being zeroed: they are in .data.rel.ro due to the non-sentinels. Reviewed-by: Nicolas George <george@nsup.org> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
99 lines
3.0 KiB
C
99 lines
3.0 KiB
C
/*
|
|
* Copyright (c) 2012 Stefano Sabatini
|
|
*
|
|
* This file is part of FFmpeg.
|
|
*
|
|
* FFmpeg is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* FFmpeg is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with FFmpeg; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*/
|
|
|
|
/**
|
|
* @file framestep filter, inspired on libmpcodecs/vf_framestep.c by
|
|
* Daniele Fornighieri <guru AT digitalfantasy it>.
|
|
*/
|
|
|
|
#include "libavutil/opt.h"
|
|
#include "avfilter.h"
|
|
#include "internal.h"
|
|
#include "video.h"
|
|
|
|
typedef struct NullContext {
|
|
const AVClass *class;
|
|
int frame_step;
|
|
} FrameStepContext;
|
|
|
|
#define OFFSET(x) offsetof(FrameStepContext, x)
|
|
#define FLAGS AV_OPT_FLAG_FILTERING_PARAM|AV_OPT_FLAG_VIDEO_PARAM
|
|
|
|
static const AVOption framestep_options[] = {
|
|
{ "step", "set frame step", OFFSET(frame_step), AV_OPT_TYPE_INT, {.i64=1}, 1, INT_MAX, FLAGS},
|
|
{ NULL },
|
|
};
|
|
|
|
AVFILTER_DEFINE_CLASS(framestep);
|
|
|
|
static int config_output_props(AVFilterLink *outlink)
|
|
{
|
|
AVFilterContext *ctx = outlink->src;
|
|
FrameStepContext *framestep = ctx->priv;
|
|
AVFilterLink *inlink = ctx->inputs[0];
|
|
|
|
outlink->frame_rate =
|
|
av_div_q(inlink->frame_rate, (AVRational){framestep->frame_step, 1});
|
|
|
|
av_log(ctx, AV_LOG_VERBOSE, "step:%d frame_rate:%d/%d(%f) -> frame_rate:%d/%d(%f)\n",
|
|
framestep->frame_step,
|
|
inlink->frame_rate.num, inlink->frame_rate.den, av_q2d(inlink->frame_rate),
|
|
outlink->frame_rate.num, outlink->frame_rate.den, av_q2d(outlink->frame_rate));
|
|
return 0;
|
|
}
|
|
|
|
static int filter_frame(AVFilterLink *inlink, AVFrame *ref)
|
|
{
|
|
FrameStepContext *framestep = inlink->dst->priv;
|
|
|
|
if (!(inlink->frame_count_out % framestep->frame_step)) {
|
|
return ff_filter_frame(inlink->dst->outputs[0], ref);
|
|
} else {
|
|
av_frame_free(&ref);
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
static const AVFilterPad framestep_inputs[] = {
|
|
{
|
|
.name = "default",
|
|
.type = AVMEDIA_TYPE_VIDEO,
|
|
.filter_frame = filter_frame,
|
|
},
|
|
};
|
|
|
|
static const AVFilterPad framestep_outputs[] = {
|
|
{
|
|
.name = "default",
|
|
.type = AVMEDIA_TYPE_VIDEO,
|
|
.config_props = config_output_props,
|
|
},
|
|
};
|
|
|
|
const AVFilter ff_vf_framestep = {
|
|
.name = "framestep",
|
|
.description = NULL_IF_CONFIG_SMALL("Select one frame every N frames."),
|
|
.priv_size = sizeof(FrameStepContext),
|
|
.priv_class = &framestep_class,
|
|
FILTER_INPUTS(framestep_inputs),
|
|
FILTER_OUTPUTS(framestep_outputs),
|
|
.flags = AVFILTER_FLAG_SUPPORT_TIMELINE_GENERIC,
|
|
};
|