1
0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2026-05-16 08:38:24 +02:00
Files
FFmpeg/libavcodec
Andreas Cadhalpun a79a5c32f9 golomb: always check for invalid UE golomb codes in get_ue_golomb
Also correct the check to reject log < 7, because UPDATE_CACHE only
guarantees 25 meaningful bits.

This fixes undefined behavior:
runtime error: shift exponent is negative

Testing with START/STOP timers in get_ue_golomb, one for the first
branch (A) and one for the second (B), shows that there is practically no
slowdown, e.g. for the cavs decoder:

With the check in the B branch:
    629 decicycles in get_ue_golomb B, 4194260 runs,     44 skips
    433 decicycles in get_ue_golomb A,268434102 runs,   1354 skips

Without the check:
    624 decicycles in get_ue_golomb B, 4194273 runs,     31 skips
    433 decicycles in get_ue_golomb A,268434203 runs,   1253 skips

Since the B branch is executed far less often than the A branch, this
change is negligible, even more so for the h264 decoder, where the ratio
B/A is a lot smaller.

Fixes: mozilla bug 1230239
Fixes: fbeb8b2c7c996e9b91c6b1af319d7ebc/asan_heap-oob_195450f_2743_e8856ece4579ea486670be2b236099a0.bit

Found-by: Tyson Smith
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
(cherry picked from commit 22e960ad47)
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
2015-12-17 20:03:56 +01:00
..
2015-08-29 06:44:20 +01:00
2015-08-22 06:16:31 +01:00
2015-08-27 17:05:44 +02:00
2015-09-01 14:35:32 +02:00
2015-08-18 10:24:01 -04:00
2015-08-04 04:16:43 +02:00
2015-10-08 13:15:42 +02:00
2015-08-27 02:59:43 +02:00
2015-08-18 11:48:49 -04:00
2015-09-03 09:47:44 +00:00
2015-08-18 11:48:49 -04:00
2015-10-12 21:46:54 +02:00
2015-08-11 23:16:35 +02:00
2015-07-27 16:21:14 +01:00
2015-08-21 08:46:05 +02:00
2015-08-21 08:46:05 +02:00
2015-08-18 09:46:49 -04:00
2015-11-26 16:05:41 +01:00
2015-09-04 09:33:46 -04:00
2015-09-08 22:31:44 +02:00
2015-08-28 04:25:15 +02:00
2015-08-18 10:24:01 -04:00
2015-07-27 19:13:48 +02:00
2015-08-18 11:48:49 -04:00
2015-10-08 13:15:42 +02:00
2015-08-15 15:06:01 +02:00
2015-08-18 11:48:49 -04:00
2015-10-12 21:46:54 +02:00
2015-08-19 14:15:43 +02:00
2015-09-07 15:32:56 +02:00
2015-08-03 10:12:10 +02:00
2015-07-27 15:24:58 +01:00