1
0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2024-12-07 11:13:41 +02:00
FFmpeg/libavfilter/vf_hwdownload.c
Andreas Rheinhardt b4f5201967 avfilter: Replace query_formats callback with union of list and callback
If one looks at the many query_formats callbacks in existence,
one will immediately recognize that there is one type of default
callback for video and a slightly different default callback for
audio: It is "return ff_set_common_formats_from_list(ctx, pix_fmts);"
for video with a filter-specific pix_fmts list. For audio, it is
the same with a filter-specific sample_fmts list together with
ff_set_common_all_samplerates() and ff_set_common_all_channel_counts().

This commit allows to remove the boilerplate query_formats callbacks
by replacing said callback with a union consisting the old callback
and pointers for pixel and sample format arrays. For the not uncommon
case in which these lists only contain a single entry (besides the
sentinel) enum AVPixelFormat and enum AVSampleFormat fields are also
added to the union to store them directly in the AVFilter,
thereby avoiding a relocation.

The state of said union will be contained in a new, dedicated AVFilter
field (the nb_inputs and nb_outputs fields have been shrunk to uint8_t
in order to create a hole for this new field; this is no problem, as
the maximum of all the nb_inputs is four; for nb_outputs it is only
two).

The state's default value coincides with the earlier default of
query_formats being unset, namely that the filter accepts all formats
(and also sample rates and channel counts/layouts for audio)
provided that these properties agree coincide for all inputs and
outputs.

By using different union members for audio and video filters
the type-unsafety of using the same functions for audio and video
lists will furthermore be more confined to formats.c than before.

When the new fields are used, they will also avoid allocations:
Currently something nearly equivalent to ff_default_query_formats()
is called after every successful call to a query_formats callback;
yet in the common case that the newly allocated AVFilterFormats
are not used at all (namely if there are no free links) these newly
allocated AVFilterFormats are freed again without ever being used.
Filters no longer using the callback will not exhibit this any more.

Reviewed-by: Paul B Mahol <onemda@gmail.com>
Reviewed-by: Nicolas George <george@nsup.org>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
2021-10-05 17:48:25 +02:00

203 lines
5.7 KiB
C

/*
* This file is part of FFmpeg.
*
* FFmpeg is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2.1 of the License, or (at your option) any later version.
*
* FFmpeg is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with FFmpeg; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
*/
#include "libavutil/buffer.h"
#include "libavutil/hwcontext.h"
#include "libavutil/log.h"
#include "libavutil/mem.h"
#include "libavutil/opt.h"
#include "libavutil/pixdesc.h"
#include "avfilter.h"
#include "formats.h"
#include "internal.h"
#include "video.h"
typedef struct HWDownloadContext {
const AVClass *class;
AVBufferRef *hwframes_ref;
AVHWFramesContext *hwframes;
} HWDownloadContext;
static int hwdownload_query_formats(AVFilterContext *avctx)
{
int err;
if ((err = ff_formats_ref(ff_formats_pixdesc_filter(AV_PIX_FMT_FLAG_HWACCEL, 0),
&avctx->inputs[0]->outcfg.formats)) ||
(err = ff_formats_ref(ff_formats_pixdesc_filter(0, AV_PIX_FMT_FLAG_HWACCEL),
&avctx->outputs[0]->incfg.formats)))
return err;
return 0;
}
static int hwdownload_config_input(AVFilterLink *inlink)
{
AVFilterContext *avctx = inlink->dst;
HWDownloadContext *ctx = avctx->priv;
av_buffer_unref(&ctx->hwframes_ref);
if (!inlink->hw_frames_ctx) {
av_log(ctx, AV_LOG_ERROR, "The input must have a hardware frame "
"reference.\n");
return AVERROR(EINVAL);
}
ctx->hwframes_ref = av_buffer_ref(inlink->hw_frames_ctx);
if (!ctx->hwframes_ref)
return AVERROR(ENOMEM);
ctx->hwframes = (AVHWFramesContext*)ctx->hwframes_ref->data;
return 0;
}
static int hwdownload_config_output(AVFilterLink *outlink)
{
AVFilterContext *avctx = outlink->src;
AVFilterLink *inlink = avctx->inputs[0];
HWDownloadContext *ctx = avctx->priv;
enum AVPixelFormat *formats;
int err, i, found;
if (!ctx->hwframes_ref)
return AVERROR(EINVAL);
err = av_hwframe_transfer_get_formats(ctx->hwframes_ref,
AV_HWFRAME_TRANSFER_DIRECTION_FROM,
&formats, 0);
if (err < 0)
return err;
found = 0;
for (i = 0; formats[i] != AV_PIX_FMT_NONE; i++) {
if (formats[i] == outlink->format) {
found = 1;
break;
}
}
av_freep(&formats);
if (!found) {
av_log(ctx, AV_LOG_ERROR, "Invalid output format %s for hwframe "
"download.\n", av_get_pix_fmt_name(outlink->format));
return AVERROR(EINVAL);
}
outlink->w = inlink->w;
outlink->h = inlink->h;
return 0;
}
static int hwdownload_filter_frame(AVFilterLink *link, AVFrame *input)
{
AVFilterContext *avctx = link->dst;
AVFilterLink *outlink = avctx->outputs[0];
HWDownloadContext *ctx = avctx->priv;
AVFrame *output = NULL;
int err;
if (!ctx->hwframes_ref || !input->hw_frames_ctx) {
av_log(ctx, AV_LOG_ERROR, "Input frames must have hardware context.\n");
err = AVERROR(EINVAL);
goto fail;
}
if ((void*)ctx->hwframes != input->hw_frames_ctx->data) {
av_log(ctx, AV_LOG_ERROR, "Input frame is not the in the configured "
"hwframe context.\n");
err = AVERROR(EINVAL);
goto fail;
}
output = ff_get_video_buffer(outlink, ctx->hwframes->width,
ctx->hwframes->height);
if (!output) {
err = AVERROR(ENOMEM);
goto fail;
}
err = av_hwframe_transfer_data(output, input, 0);
if (err < 0) {
av_log(ctx, AV_LOG_ERROR, "Failed to download frame: %d.\n", err);
goto fail;
}
output->width = outlink->w;
output->height = outlink->h;
err = av_frame_copy_props(output, input);
if (err < 0)
goto fail;
av_frame_free(&input);
return ff_filter_frame(avctx->outputs[0], output);
fail:
av_frame_free(&input);
av_frame_free(&output);
return err;
}
static av_cold void hwdownload_uninit(AVFilterContext *avctx)
{
HWDownloadContext *ctx = avctx->priv;
av_buffer_unref(&ctx->hwframes_ref);
}
static const AVClass hwdownload_class = {
.class_name = "hwdownload",
.item_name = av_default_item_name,
.option = NULL,
.version = LIBAVUTIL_VERSION_INT,
};
static const AVFilterPad hwdownload_inputs[] = {
{
.name = "default",
.type = AVMEDIA_TYPE_VIDEO,
.config_props = hwdownload_config_input,
.filter_frame = hwdownload_filter_frame,
},
};
static const AVFilterPad hwdownload_outputs[] = {
{
.name = "default",
.type = AVMEDIA_TYPE_VIDEO,
.config_props = hwdownload_config_output,
},
};
const AVFilter ff_vf_hwdownload = {
.name = "hwdownload",
.description = NULL_IF_CONFIG_SMALL("Download a hardware frame to a normal frame"),
.uninit = hwdownload_uninit,
.priv_size = sizeof(HWDownloadContext),
.priv_class = &hwdownload_class,
FILTER_INPUTS(hwdownload_inputs),
FILTER_OUTPUTS(hwdownload_outputs),
FILTER_QUERY_FUNC(hwdownload_query_formats),
.flags_internal = FF_FILTER_FLAG_HWFRAME_AWARE,
};