mirror of
https://github.com/FFmpeg/FFmpeg.git
synced 2024-12-28 20:53:54 +02:00
f440c422b7
In this case the current code tries to warn once; to do so, it uses ordinary static ints to store whether the warning has already been emitted. This is both a data race (and therefore undefined behaviour) as well as a race condition, because it is really possible for multiple threads to be the one thread to emit the warning. This is actually common since the introduction of the new multithreaded scaling API. This commit fixes this by using atomic integers for the state; furthermore, these are not static anymore, but rather contained in the user-facing SwsContext (i.e. the parent SwsContext in case of slice-threading). Given that these atomic variables are not intended for synchronization at all (but only for atomicity, i.e. only to output the warning once), the atomic operations use memory_order_relaxed. This affected the nv12, nv21, yuv420, yuv420p10, yuv422, yuv422p10 and yuv444 filter-overlay FATE-tests. Reviewed-by: Michael Niedermayer <michael@niedermayer.cc> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> |
||
|---|---|---|
| .. | ||
| aarch64 | ||
| arm | ||
| ppc | ||
| tests | ||
| x86 | ||
| alphablend.c | ||
| bayer_template.c | ||
| gamma.c | ||
| hscale_fast_bilinear.c | ||
| hscale.c | ||
| input.c | ||
| libswscale.v | ||
| log2_tab.c | ||
| Makefile | ||
| options.c | ||
| output.c | ||
| rgb2rgb_template.c | ||
| rgb2rgb.c | ||
| rgb2rgb.h | ||
| slice.c | ||
| swscale_internal.h | ||
| swscale_unscaled.c | ||
| swscale.c | ||
| swscale.h | ||
| swscaleres.rc | ||
| utils.c | ||
| version.h | ||
| vscale.c | ||
| yuv2rgb.c | ||