From 5fc74c67f33a324f29e01a43fd09f85fe4fb8efd Mon Sep 17 00:00:00 2001 From: Jan N Rose Date: Wed, 4 Aug 2021 10:23:20 +0200 Subject: [PATCH] Remove executable flag from file mode (#6185) * Remove executable flag from file mode Affected: dgraph, django, homebrew, pagekit, uikit * Add lint step to CI to reject executable icons Co-authored-by: Eric Cornelissen --- .github/workflows/verify.yml | 18 ++++++++++++++++++ icons/dgraph.svg | 0 icons/django.svg | 0 icons/homebrew.svg | 0 icons/pagekit.svg | 0 icons/uikit.svg | 0 6 files changed, 18 insertions(+) mode change 100755 => 100644 icons/dgraph.svg mode change 100755 => 100644 icons/django.svg mode change 100755 => 100644 icons/homebrew.svg mode change 100755 => 100644 icons/pagekit.svg mode change 100755 => 100644 icons/uikit.svg diff --git a/.github/workflows/verify.yml b/.github/workflows/verify.yml index dfc600cee..701f8e410 100644 --- a/.github/workflows/verify.yml +++ b/.github/workflows/verify.yml @@ -44,6 +44,24 @@ jobs: run: npm ci - name: Run linter run: npm run lint + - name: Verify file permissions + run: | + CHECK_DIRS="icons/ _data/" + echo "Searching the following directories for executable files:" + echo "${CHECK_DIRS}" + echo "" + EXE_FILES=$(find ${CHECK_DIRS} -type f -executable) + if test -n "${EXE_FILES-}" + then + echo "Some files were detected to have their executable bit set." + echo "To fix this, you can use 'chmod -x PATH/TO/FILE' on the following files:" + echo "" + echo "${EXE_FILES}" + exit 1 + else + echo "All clear." + exit 0 + fi test: name: Test package runs-on: ubuntu-latest diff --git a/icons/dgraph.svg b/icons/dgraph.svg old mode 100755 new mode 100644 diff --git a/icons/django.svg b/icons/django.svg old mode 100755 new mode 100644 diff --git a/icons/homebrew.svg b/icons/homebrew.svg old mode 100755 new mode 100644 diff --git a/icons/pagekit.svg b/icons/pagekit.svg old mode 100755 new mode 100644 diff --git a/icons/uikit.svg b/icons/uikit.svg old mode 100755 new mode 100644