web/simple-icons
1
0
Fork 0
mirror of https://github.com/simple-icons/simple-icons.git synced 2025-11-23 21:34:49 +02:00
Code Releases Activity

Standarize locale comparisons and sort icons by title in package (#7854)

Browse Source 
* Use Intl.Collator for locale comparisons

* Sort icons by title in package
This commit is contained in:
Álvaro Mondéjar
2022-09-24 17:29:43 +02:00
committed by GitHub
parent fdc707bf81
commit ad7de0434e
4 changed files with 20 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
scripts/lint/ourlint.js
View File

@@ -6,7 +6,7 @@
*/
import fakeDiff from 'fake-diff';
import { getIconsDataString, normalizeNewlines } from '../utils.js';
import { getIconsDataString, normalizeNewlines, collator } from '../utils.js';
/**
* Contains our tests so they can be isolated from each other.
@@ -18,12 +18,12 @@ const TESTS = {
const collector = (invalidEntries, icon, index, array) => {
if (index > 0) {
const prev = array[index - 1];
const compare = icon.title.localeCompare(prev.title);
if (compare < 0) {
const comparison = collator.compare(icon.title, prev.title);
if (comparison < 0) {
invalidEntries.push(icon);
} else if (compare === 0) {
} else if (comparison === 0) {
if (prev.slug) {
if (!icon.slug || icon.slug.localeCompare(prev.slug) < 0) {
if (!icon.slug || collator.compare(icon.slug, prev.slug) < 0) {
invalidEntries.push(icon);
}
}