1
0
mirror of https://github.com/simple-icons/simple-icons.git synced 2024-11-16 00:59:07 +02:00
Commit Graph

18 Commits

Author SHA1 Message Date
Sachin Raja
374297eaad
include rank requirements in issue template (#7401)
* include rank requirements in issue template

* clarify

* remove extra space
2022-05-09 20:22:59 -07:00
Sachin Raja
b3f4375a4d
remove alexa rank references (#7400)
* Update icon_request.yml

* Update icon_request.yml
2022-05-09 20:14:44 -07:00
Álvaro Mondéjar
c05890dc5f
Fix error in issue templates links (#7220) 2022-03-14 14:57:01 +01:00
Sachin Raja
d6612085c4
prefer similarweb for website ranks (#7154)
* prefer similarweb for website ranks

* Update icon_request.yml

* Update icon_request.yml

* update CONTRIBUTING.md

* format yaml

* update pull request template

* update example

* fix formatting errors
2022-02-21 12:29:48 -08:00
Álvaro Mondéjar
2a87f98d3b
Fix link in issue template for icon requests (#7159) 2022-02-18 06:15:11 -08:00
Sachin Raja
dd0cc815a1
fix: wrap yes and no in quotes in issue templates (#6779) 2021-10-27 18:32:32 -07:00
Sachin Raja
aef101d726
Remove default titles from issue templates (#6775) 2021-10-26 18:38:25 +02:00
Eric Cornelissen
e0df400494
Setup prettier (#6758)
* Add prettier as a dependency

* Add format command and configure prettier

I opted for single quotes to be in line with other simple-icons projects

I ignore the data file because changing its formatting is quite a bit of
trouble for all open PRs.

* Run prettier

* Replace all functions by arrow functions

* Move prettier configuration to config file

Move it to a file so editors (and other software) can pick up on the
configuration. I went with .js because (a) it allows for comments and
(2) it seems most of the config files are in JavaScript already.

* Add prettier --check when running npm run lint (This adds it to the CI as well)

* Add husky and format changes before committing

* Use object destructuring for imports consistently

* Add shebang and fileoverview to jsonlint.js
2021-10-25 21:13:10 +02:00
Sachin Raja
231b7a4723
add removal form (#6552)
* add removal form

* use removal request label

* add description asking reporter to include links

* add breaking change label

* Update description

* search for breaking change label too

* update disclaimer links

* change to icon outdated issues

Co-authored-by: Eric Cornelissen <ericornelissen@gmail.com>
2021-09-25 12:59:53 +02:00
Sachin Raja
73f6483337
Issue forms (#6303)
* create issue form for icon requests

* cleanup old issue template

* create issue form for icon updates

* create package and documentation forms

* fix: description strings

* remove "render" from textarea

* add additional comments section to icon request/update form

* fix: grammar

* fix: more grammar

* feat: default issue titles

* move contributing guidelines to top, make resources required

* fix contributing guidelines link

* remove unnecessary queustion from documentation form

* add description for website field

* trim trailing whitespace

* fix linting errors

* add examples to additional comments description

* simplify fields to specify issue type

* update examples in documentation description

* align icon update with icon request

* fix: grammar

* align package and documentation forms

* require "Kind of issue"

* clarify kind of issue description

* better grammar in kind of issue description

* allow issue authors to specify if they would like to contribute

* use dropdown in contributing field

* update form notice for duplicate issues

link searches open issues by default

* update contributing description and make field required

* add different contributing descriptions

* add placeholders

* change "Alexa rank" to "Popularity Metric"

* change "insufficient" to "too low"

* add backticks around hex color in placeholder

* reword license question

* convert popularity metric to textarea

* update all descriptions

* no more inline links

* fix links

* remove trailing whitespace

* proper newline

* proper newline 2

* capitalize options

* capitalize options

* add to additional comments description

* fix icon request resources description

* fix sentences structure

* consistent wording - "docs," not "documentation"

* remove contributing field from package form

* separate inputs for version information

* better wording for software input

* fix link formatting

* more link formatting

* update additional comments description

* align resources description across forms

* remove unnecessary questions from icon update description

* format

* fix icon request links

* add version to chrome example in placeholder

* change Simple Icons to Package in label

* consistent "None" across forms

* consistent "None" across forms

* consistent additional comments field

* improve wording in version description

* fix wording in icon request popularity metric description

* minor placeholder updates

* fix "this issue concerns..." label

* add improvement option to package form

* add performance option

* consistency

Co-authored-by: Eric Cornelissen <ericornelissen@gmail.com>
2021-08-25 22:22:30 +02:00
Eric Cornelissen
6577913ec3
Add issue templated for docs and update existing issue templates (#5676)
* Add issue template for documentation

* Add missing space to the "Icon request" template's description

* Update issue template descriptios
2021-05-31 19:13:05 +02:00
Eric Cornelissen
c368b14e62
Remove (old) website source files (#5553)
* Remove files directly related to the website

Remove all the files directly related to the Jekyll-based website in
this repository. This includes the HTML, CSS and JS for the website, the
assets that can be found in the images/ folder, Jekyll-related files
(_config.yml, Gemfile, Gemfile.lock) and the CNAME file.

* Remove website-related configurations

Remove website-related files from ignore files, update the EditorConfig
configuration to remove any mention of website files, and update
.gitattributes to omit removed files.

* Update issue templates

Remove the issue templates for issues regarding the website and replace
it with a issue templates configuration file [1] that provides a link to
a the equivalent issue template in the simple-icons-website repository.

--
1. https://docs.github.com/en/github/building-a-strong-community/configuring-issue-templates-for-your-repository


* Remove building website from verify workflow

* Remove mentions of website from Contributing Guidelines

* Remove mention of GitPod

I believe the main advantage of GitPod was that it allows you to preview
a contribution in the context of the website. Now that the website is no
longer in the repository this is not a thing anymore (unless someone
can configure GitPod to pull in the website from its repo), so I removed
any mention of it.

I'm open to reverting this change if contributors still want to use
GitPod.

* Add CI job for building the NodeJS package
2021-05-29 18:00:40 +02:00
Peter Noble
9e09db7324
Change "Name" to "Brand Name" in Issue Templates (#4682) 2021-01-08 08:44:42 -05:00
Peter Noble
af4024cc4c
Add Alexa ranks to GitHub Templates (#3207)
* Add Alexa ranks to GitHub Templates

* Add trailing newline to icon_request.md

* Remove excess space from icon_request.md

* Updates from review

* Remove choice between issue & rank

* Fix typo in issue template

Co-authored-by: Eric Cornelissen <ericornelissen@gmail.com>

* Improve wording in issue template and close last comment

Co-authored-by: Lucas Becker <runxel@users.noreply.github.com>
Co-authored-by: Eric Cornelissen <ericornelissen@gmail.com>
2020-06-22 18:31:12 +03:00
Eric Cornelissen
0c005de777 Split issue templates for website and package (#2409)
* Separate Website and Package issue templates

* Add dedicated labels to package and website issue templates
2020-01-20 13:54:25 +01:00
Eric Cornelissen
3129166158
Add composer.json (#1611)
* Add composer.json

* Update issue template to include Packagist

* Update README.md
2019-09-26 09:04:33 +03:00
Eric Cornelissen
712c355484
Add predefined labels to issue templates (#1471) 2019-06-15 12:43:28 +01:00
Eric Cornelissen
2e8b064d51 Update Github templates (#1023)
* Add Pull Request template

* Use multiple issue templates

* Add item about referencing issues in the Pull Request template

* Update issue templates based on suggestions by @birjolaxew

* Update issue templates based on suggestions by @birjolaxew

* Combine package and website template

* Update Pull Request template

Co-Authored-By: Johan Fagerberg <birjolaxew@users.noreply.github.com>

* Change template style for pull requests

* Add "etc." to lists of examples
2018-10-23 22:10:46 +02:00