web/video.js
1
0
Fork 0
mirror of https://github.com/videojs/video.js.git synced 2025-01-29 11:23:10 +02:00
Code Releases Activity

fix: disable title attribute on menu items (#4019)

Browse Source 
Prevents a title attribute from being applied to MenuItems.
MenuItem indicates to ClickableComponent that the control is not just an icon, so it shouldn't have a title attribute.

Fixes #3699
This commit is contained in:
Owen Edwards 2017-02-02 11:45:39 -08:00 committed by Gary Katsevman
parent 29c6141de9
commit 04f23c1a62
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/js/clickable-component.js
View File

@ -121,7 +121,10 @@ class ClickableComponent extends Component {
this.controlText_ = text; this.controlText_ = text;
this.controlTextEl_.innerHTML = localizedText; this.controlTextEl_.innerHTML = localizedText;
el.setAttribute('title', localizedText); if (!this.nonIconControl) {
// Set title attribute if only an icon is shown
el.setAttribute('title', localizedText);
}
} }
/** /**

3
src/js/menu/menu-item.js
View File

@ -54,6 +54,9 @@ class MenuItem extends ClickableComponent {
* The element that gets created. * The element that gets created.
*/ */
createEl(type, props, attrs) { createEl(type, props, attrs) {
// The control is textual, not just an icon
this.nonIconControl = true;
return super.createEl('li', assign({ return super.createEl('li', assign({
className: 'vjs-menu-item', className: 'vjs-menu-item',
innerHTML: this.localize(this.options_.label), innerHTML: this.localize(this.options_.label),