web/video.js
1
0
Fork 0
mirror of https://github.com/videojs/video.js.git synced 2025-07-17 01:42:41 +02:00
Code Releases Activity

feat: split overrideNative method into separate methods (#5107)

Browse Source 
Split overrideNative method into one for Audio and Video. Fixes issues with differing track support in IE11.
This commit is contained in:
Oshin Karamian
2018-04-19 20:11:11 -04:00
committed by Gary Katsevman
parent 97db94e8a6
commit 083a86c363
3 changed files with 123 additions and 100 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
test/unit/tech/html5.test.js
View File

@ -550,15 +550,10 @@ if (Html5.supportsNativeAudioTracks()) {
rems.push({ type, fn });
}
};
const vt = {
length: 0,
addEventListener: (type, fn) => null,
removeEventListener: (type, fn) => null
};
const el = document.createElement('div');
el.audioTracks = at;
el.videoTracks = vt;
const htmlTech = new Html5({el});
@ -567,21 +562,21 @@ if (Html5.supportsNativeAudioTracks()) {
assert.equal(rems.length, 0,
'no listeners should be removed');
htmlTech.overrideNativeTracks(true);
htmlTech.overrideNativeAudioTracks(true);
assert.equal(adds.length, 3,
'should not have added additional listeners');
assert.equal(rems.length, 3,
'should have removed previous three listeners');
htmlTech.overrideNativeTracks(true);
htmlTech.overrideNativeAudioTracks(true);
assert.equal(adds.length, 3,
'no state change so do not add listeners');
assert.equal(rems.length, 3,
'no state change so do not remove listeners');
htmlTech.overrideNativeTracks(false);
htmlTech.overrideNativeAudioTracks(false);
assert.equal(adds.length, 6,
'should add listeners because native tracks should be proxied');
@ -673,14 +668,8 @@ if (Html5.supportsNativeVideoTracks()) {
rems.push({ type, fn });
}
};
const at = {
length: 0,
addEventListener: (type, fn) => null,
removeEventListener: (type, fn) => null
};
const el = document.createElement('div');
el.audioTracks = at;
el.videoTracks = vt;
const htmlTech = new Html5({el});
@ -690,21 +679,21 @@ if (Html5.supportsNativeVideoTracks()) {
assert.equal(rems.length, 0,
'no listeners should be removed');
htmlTech.overrideNativeTracks(true);
htmlTech.overrideNativeVideoTracks(true);
assert.equal(adds.length, 3,
'should not have added additional listeners');
assert.equal(rems.length, 3,
'should have removed previous three listeners');
htmlTech.overrideNativeTracks(true);
htmlTech.overrideNativeVideoTracks(true);
assert.equal(adds.length, 3,
'no state change so do not add listeners');
assert.equal(rems.length, 3,
'no state change so do not remove listeners');
htmlTech.overrideNativeTracks(false);
htmlTech.overrideNativeVideoTracks(false);
assert.equal(adds.length, 6,
'should add listeners because native tracks should be proxied');