web/video.js
1
0
Fork 0
mirror of https://github.com/videojs/video.js.git synced 2025-03-25 22:01:11 +02:00
Code Releases Activity

fix(cues): only copy cue props that don't exist (#4145)

Browse Source
This commit is contained in:
Gary Katsevman 2017-03-02 11:16:12 -05:00 committed by GitHub
parent dacf0ca133
commit 0f57341e38
2 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/js/tracks/text-track.js
View File

@ -343,7 +343,9 @@ class TextTrack extends Track {
cue = new window.vttjs.VTTCue(originalCue.startTime, originalCue.endTime, originalCue.text);
for (const prop in originalCue) {
cue[prop] = originalCue[prop];
if (!(prop in cue)) {
cue[prop] = originalCue[prop];
}
}
}

12
test/unit/tracks/text-track.test.js
View File

@ -19,7 +19,17 @@ const defaultTech = {
currentTime() {}
};
QUnit.module('Text Track');
QUnit.module('Text Track', {
beforeEach() {
this.oldVttjs = window.vttjs;
window.vttjs = {
VTTCue: Object
};
},
afterEach() {
window.vttjs = this.oldVttjs;
}
});
// do baseline track testing
TrackBaseline(TextTrack, {