From 180c75b3a2ddda69909f50e887e02b59da9afb6e Mon Sep 17 00:00:00 2001 From: Dan Connor <danconn@danconnor.com> Date: Tue, 6 Nov 2012 16:38:35 -0800 Subject: [PATCH] fix for loading spinner persisting on screen after programatic seek in Chrome --- src/controls.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/controls.js b/src/controls.js index 2b38631b1..a04caf1fb 100644 --- a/src/controls.js +++ b/src/controls.js @@ -239,6 +239,12 @@ _V_.LoadingSpinner = _V_.Component.extend({ player.addEvent("playing", _V_.proxy(this, this.hide)); player.addEvent("seeking", _V_.proxy(this, this.show)); + + // in some browsers seeking does not trigger the 'playing' event, + // so we also need to trap 'seeked' if we are going to set a + // 'seeking' event + player.addEvent("seeked", _V_.proxy(this, this.hide)); + player.addEvent("error", _V_.proxy(this, this.show)); // Not showing spinner on stalled any more. Browsers may stall and then not trigger any events that would remove the spinner. @@ -843,4 +849,4 @@ _V_.MenuItem = _V_.Button.extend({ } } -}); \ No newline at end of file +});