web/video.js
1
0
Fork 0
mirror of https://github.com/videojs/video.js.git synced 2025-01-13 10:32:26 +02:00
Code Releases Activity

fix(html5): exit early on emulated tracks in html5 (#3772)

Browse Source 
addRemoteTextTrack and removeRemoteTextTrack in Html5 tech assumed that
they are always called for native text tracks. However, Html5 tech can
have emulated text tracks. For those, we just exit early after the super
methods are called.
This commit is contained in:
Gary Katsevman 2016-11-11 14:35:04 -05:00 committed by GitHub
parent 6b477bb737
commit 252bcee959
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/js/tech/html5.js
View File

@ -657,7 +657,9 @@ class Html5 extends Tech {
addRemoteTextTrack(options, manualCleanup) {
const htmlTrackElement = super.addRemoteTextTrack(options, manualCleanup);
this.el().appendChild(htmlTrackElement);
if (this.featuresNativeTextTracks) {
this.el().appendChild(htmlTrackElement);
}
return htmlTrackElement;
}
@ -670,13 +672,15 @@ class Html5 extends Tech {
removeRemoteTextTrack(track) {
super.removeRemoteTextTrack(track);
const tracks = this.$$('track');
if (this.featuresNativeTextTracks) {
const tracks = this.$$('track');
let i = tracks.length;
let i = tracks.length;
while (i--) {
if (track === tracks[i] || track === tracks[i].track) {
this.el().removeChild(tracks[i]);
while (i--) {
if (track === tracks[i] || track === tracks[i].track) {
this.el().removeChild(tracks[i]);
}
}
}
}