web/video.js
1
0
Fork 0
mirror of https://github.com/videojs/video.js.git synced 2025-01-08 07:00:10 +02:00
Code Releases Activity

fix: showing custom poster with controls disabled (#3933)

Browse Source 
We previously hid the poster image when controls were disabled because
the poster image had a click handler on it. However, this meant that in
the case of Flash, which doesn't have a native poster image ability, we
lost the poster.

Fixes #1625.
This commit is contained in:
Gary Katsevman 2017-01-11 16:26:35 -05:00 committed by GitHub
parent 94fd5c12c8
commit 305e5ea192
2 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/css/components/_poster.scss
View File

@ -36,12 +36,6 @@
display: block;
}
// Hide the poster when controls are disabled because it's clickable
// and the native poster can take over
.vjs-controls-disabled .vjs-poster {
display: none;
}
// Hide the poster when native controls are used otherwise it covers them
.vjs-using-native-controls .vjs-poster {
display: none;

5
src/js/poster-image.js
View File

@ -121,7 +121,10 @@ class PosterImage extends ClickableComponent {
*/
handleClick(event) {
// We don't want a click to trigger playback when controls are disabled
// but CSS should be hiding the poster to prevent that from happening
if (!this.player_.controls()) {
return;
}
if (this.player_.paused()) {
this.player_.play();
} else {