web/video.js
1
0
Fork 0
mirror of https://github.com/videojs/video.js.git synced 2024-12-25 02:42:10 +02:00
Code Releases Activity

fix: use Screen Orientation API where supported (#8031)

Browse Source 
* feat:  introduces Screen Orientation API for detecting orientation change

* feat:  add missing unit tests
This commit is contained in:
Grzegorz Blaszczyk 2023-02-01 18:05:41 +01:00 committed by GitHub
parent 267b5c6bff
commit 33b476d7cc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 44 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/js/tracks/text-track-display.js
View File

@ -118,8 +118,11 @@ class TextTrackDisplay extends Component {
player.on('fullscreenchange', updateDisplayHandler);
player.on('playerresize', updateDisplayHandler);
window.addEventListener('orientationchange', updateDisplayHandler);
player.on('dispose', () => window.removeEventListener('orientationchange', updateDisplayHandler));
const screenOrientation = window.screen.orientation || window;
const changeOrientationEvent = window.screen.orientation ? 'change' : 'orientationchange';
screenOrientation.addEventListener(changeOrientationEvent, updateDisplayHandler);
player.on('dispose', () => screenOrientation.removeEventListener(changeOrientationEvent, updateDisplayHandler));
const tracks = this.options_.playerOptions.tracks || [];

39
test/unit/tracks/text-track-display.test.js
View File

@ -1,4 +1,5 @@
/* eslint-env qunit */
import window from 'global/window';
import Html5 from '../../../src/js/tech/html5.js';
import { constructColor } from '../../../src/js/tracks/text-track-display.js';
import Component from '../../../src/js/component.js';
@ -105,6 +106,44 @@ QUnit.test('shows the default caption track first', function(assert) {
});
if (!Html5.supportsNativeTextTracks()) {
QUnit.test('text track display should attach screen orientation change event handler', function(assert) {
const oldScreen = window.screen;
const removeHandlerSpy = sinon.spy();
let changeHandlerSpy;
let changeHandlerAttached;
window.screen = {
orientation: {
addEventListener: (type, func) => {
changeHandlerAttached = true;
changeHandlerSpy = sinon.spy();
},
dispatchEvent: (type) => changeHandlerSpy(),
removeEventListener: removeHandlerSpy
}
};
const player = TestHelpers.makePlayer();
this.clock.tick(1);
assert.true(changeHandlerAttached, 'screen orientation change event handler was not attached');
assert.strictEqual(changeHandlerSpy.callCount, 0, 'screen orientation change event handler should not be called');
window.screen.orientation.dispatchEvent('change');
assert.strictEqual(changeHandlerSpy.callCount, 1, 'screen orientation change event handler was not called');
player.dispose();
assert.strictEqual(
removeHandlerSpy.callCount,
1,
'screen orientation change event handler was not removed during player dispose'
);
window.screen = oldScreen;
});
QUnit.test('selectedlanguagechange is triggered by a track mode change', function(assert) {
const player = TestHelpers.makePlayer();
const track1 = {