web/video.js
1
0
Fork 0
mirror of https://github.com/videojs/video.js.git synced 2025-03-17 21:18:27 +02:00
Code Releases Activity

fix: try enabling liveui on canplay (#7114)

Browse Source 
On native playback engines, like Safari, for some streams, seekable and
currentTime won't have correct values until video data has started
loading. Previously, we only tried to turn toggle tracking on
durationchange, now we also do it on canplay.

This is a followup to #7034 which helped prevent the live tracker from
showing up in some cases.
This commit is contained in:
Gary Katsevman 2021-03-08 16:27:53 -05:00 committed by GitHub
parent 0b467041c7
commit 3d676d68ca
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/js/live-tracker.js
View File

@ -47,6 +47,9 @@ class LiveTracker extends Component {
this.reset_();
this.on(this.player_, 'durationchange', this.handleDurationchange);
// we should try to toggle tracking on canplay as native playback engines, like Safari
// may not have the proper values for things like seekableEnd until then
this.one(this.player_, 'canplay', () => this.toggleTracking());
// we don't need to track live playback if the document is hidden,
// also, tracking when the document is hidden can
@ -119,6 +122,13 @@ class LiveTracker extends Component {
* and start/stop tracking accordingly.
*/
handleDurationchange() {
this.toggleTracking();
}
/**
* start/stop tracking
*/
toggleTracking() {
if (this.player_.duration() === Infinity && this.liveWindow() >= this.options_.trackingThreshold) {
if (this.player_.options_.liveui) {
this.player_.addClass('vjs-liveui');