1
0
mirror of https://github.com/videojs/video.js.git synced 2025-01-02 06:32:07 +02:00

refactor: Reorder SASS styles to address deprecation (#8821)

## Description
Some of the existing rules would be interpreted differently in a future
version of SASS. In the current version, they trigger a deprecation
warning. See
https://sass-lang.com/documentation/breaking-changes/mixed-decls/

## Specific Changes proposed
Re-orders rules to maintain current output and remove warnings. The
output of video-js.css and video-js.min.css remains the same.

## Requirements Checklist
- [x] Feature implemented / Bug fixed
- [ ] If necessary, more likely in a feature request than a bug fix
- [x] Change has been verified in an actual browser (Chrome, Firefox,
IE)
  - [ ] Unit Tests updated or fixed
  - [ ] Docs/guides updated
- [ ] Example created ([starter template on
JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0))
- [x] Has no DOM changes which impact accessiblilty or trigger warnings
(e.g. Chrome issues tab)
  - [x] Has no changes to JSDoc which cause `npm run docs:api` to error
- [ ] Reviewed by Two Core Contributors
This commit is contained in:
mister-ben 2024-07-31 22:04:23 +02:00 committed by GitHub
parent c4007dbea3
commit 57c27f8e5c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 15 additions and 14 deletions

View File

@ -1,12 +1,12 @@
.video-js .vjs-control.vjs-close-button { .video-js .vjs-control.vjs-close-button {
& .vjs-icon-placeholder {
@extend .vjs-icon-cancel;
}
cursor: pointer; cursor: pointer;
height: 3em; height: 3em;
position: absolute; position: absolute;
right: 0; right: 0;
top: 0.5em; top: 0.5em;
z-index: 2; z-index: 2;
& .vjs-icon-placeholder {
@extend .vjs-icon-cancel;
}
} }

View File

@ -21,6 +21,9 @@
// Avoiding helvetica: issue #376 // Avoiding helvetica: issue #376
font-family: $text-font-family; font-family: $text-font-family;
// reset word-break inside the player div
word-break: initial;
// Fix for Firefox 9 fullscreen (only if it is enabled). Not needed when // Fix for Firefox 9 fullscreen (only if it is enabled). Not needed when
// checking fullScreenEnabled. // checking fullScreenEnabled.
&:-moz-full-screen { position: absolute; } &:-moz-full-screen { position: absolute; }
@ -29,9 +32,6 @@
width: 100% !important; width: 100% !important;
height: 100% !important; height: 100% !important;
} }
// reset word-break inside the player div
word-break: initial;
} }
.video-js[tabindex="-1"] { .video-js[tabindex="-1"] {

View File

@ -35,27 +35,30 @@
} }
.video-js .vjs-volume-panel { .video-js .vjs-volume-panel {
@include transition(width 1s);
&.vjs-hover .vjs-volume-control, &.vjs-hover .vjs-volume-control,
&:active .vjs-volume-control, &:active .vjs-volume-control,
&:focus .vjs-volume-control, &:focus .vjs-volume-control,
& .vjs-volume-control:active, & .vjs-volume-control:active,
&.vjs-hover .vjs-mute-control ~ .vjs-volume-control, &.vjs-hover .vjs-mute-control ~ .vjs-volume-control,
& .vjs-volume-control.vjs-slider-active { & .vjs-volume-control.vjs-slider-active {
visibility: visible;
opacity: 1;
position: relative;
$transition-property: visibility 0.1s, opacity 0.1s, height 0.1s, width 0.1s, left 0s, top 0s;
@include transition($transition-property);
&.vjs-volume-horizontal { &.vjs-volume-horizontal {
width: 5em; width: 5em;
height: 3em; height: 3em;
margin-right: 0; margin-right: 0;
} }
visibility: visible;
opacity: 1;
position: relative;
&.vjs-volume-vertical { &.vjs-volume-vertical {
left: -3.5em; left: -3.5em;
@include transition(left 0s); @include transition(left 0s);
} }
$transition-property: visibility 0.1s, opacity 0.1s, height 0.1s, width 0.1s, left 0s, top 0s;
@include transition($transition-property);
} }
&.vjs-volume-panel-horizontal { &.vjs-volume-panel-horizontal {
@ -70,8 +73,6 @@
width: 4em; width: 4em;
} }
} }
@include transition(width 1s);
} }
.video-js .vjs-volume-panel .vjs-volume-control.vjs-volume-vertical { .video-js .vjs-volume-panel .vjs-volume-control.vjs-volume-vertical {