web/video.js
1
0
Fork 0
mirror of https://github.com/videojs/video.js.git synced 2025-04-11 11:42:08 +02:00
Code Releases Activity

Bind 'onKeyPress' during keydown instead of keyup.

Browse Source 
Binding during keydown will be more effective at preventing certain default behavior like moving the page down as these events may happen prior to keyup. Addresses #1452
This commit is contained in:
Pete Song 2014-08-26 20:45:39 -04:00
parent 055d81dc3a
commit 58c081f154
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/js/button.js
View File

@ -65,7 +65,7 @@ vjs.Button.prototype.onClick = function(){};
// Focus - Add keyboard functionality to element
vjs.Button.prototype.onFocus = function(){
vjs.on(document, 'keyup', vjs.bind(this, this.onKeyPress));
vjs.on(document, 'keydown', vjs.bind(this, this.onKeyPress));
};
// KeyPress (document level) - Trigger click when keys are pressed
@ -79,5 +79,5 @@ vjs.Button.prototype.onKeyPress = function(event){
// Blur - Remove keyboard triggers
vjs.Button.prototype.onBlur = function(){
vjs.off(document, 'keyup', vjs.bind(this, this.onKeyPress));
vjs.off(document, 'keydown', vjs.bind(this, this.onKeyPress));
};