From 5d859a92b5dc6bd1edc223aae1cbdeae062ebfd9 Mon Sep 17 00:00:00 2001 From: Steve Heffernan Date: Thu, 30 Oct 2014 13:57:34 -0700 Subject: [PATCH] Fixed the VolumeMenuButton options to allow passing 'vertical' to the VolumeBar. closes #1631 --- CHANGELOG.md | 3 ++- src/js/control-bar/volume-menu-button.js | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c0031ee59..9035d5973 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,7 +2,8 @@ CHANGELOG ========= ## HEAD (Unreleased) -* @heff fixed checking for child options in the parent options to allow for 'false'; ([view](https://github.com/videojs/video.js/pull/1630)) +* @heff fixed checking for child options in the parent options to allow for 'false' ([view](https://github.com/videojs/video.js/pull/1630)) +* @heff fixed the VolumeMenuButton options to allow passing 'vertical' to the VolumeBar ([view](https://github.com/videojs/video.js/pull/1631)) -------------------- diff --git a/src/js/control-bar/volume-menu-button.js b/src/js/control-bar/volume-menu-button.js index 2785a40da..ddc39a0c8 100644 --- a/src/js/control-bar/volume-menu-button.js +++ b/src/js/control-bar/volume-menu-button.js @@ -29,7 +29,7 @@ vjs.VolumeMenuButton.prototype.createMenu = function(){ var menu = new vjs.Menu(this.player_, { contentElType: 'div' }); - var vc = new vjs.VolumeBar(this.player_, this.options_.volumeBar); + var vc = new vjs.VolumeBar(this.player_, this.options_['volumeBar']); vc.on('focus', function() { menu.lockShowing(); });