From 6317395e0cf9314aaade845203e81818c532b0be Mon Sep 17 00:00:00 2001 From: Owen Edwards Date: Mon, 25 Jan 2016 19:38:28 -0500 Subject: [PATCH] @OwenEdwards fixed double-localization of mute toggle control text. closes #3017 --- CHANGELOG.md | 1 + src/js/control-bar/mute-toggle.js | 5 ++--- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index cd8f819bc..18dd0c7c0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,7 @@ CHANGELOG * @OwenEdwards Fixed menu keyboard access and ARIA labeling for screen readers ([view](https://github.com/videojs/video.js/pull/3033)) * @OwenEdwards Fixed volume menu keyboard access ([view](https://github.com/videojs/video.js/pull/3034)) * @mister-ben made $primary-foreground-color a !default sass var ([view](https://github.com/videojs/video.js/pull/3003)) +* @OwenEdwards fixed double-localization of mute toggle control text ([view](https://github.com/videojs/video.js/pull/3017)) -------------------- diff --git a/src/js/control-bar/mute-toggle.js b/src/js/control-bar/mute-toggle.js index f9d298652..aa063ecc2 100644 --- a/src/js/control-bar/mute-toggle.js +++ b/src/js/control-bar/mute-toggle.js @@ -76,9 +76,8 @@ class MuteToggle extends Button { // This causes unnecessary and confusing information for screen reader users. // This check is needed because this function gets called every time the volume level is changed. let toMute = this.player_.muted() ? 'Unmute' : 'Mute'; - let localizedMute = this.localize(toMute); - if (this.controlText() !== localizedMute) { - this.controlText(localizedMute); + if (this.controlText() !== toMute) { + this.controlText(toMute); } /* TODO improve muted icon classes */