web/video.js
1
0
Fork 0
mirror of https://github.com/videojs/video.js.git synced 2024-12-12 11:15:04 +02:00
Code Releases Activity

refactor: remove un-needed contructor and function overrides (#3721)

Browse Source
This commit is contained in:
Brandon Casey 2016-11-04 14:18:30 -04:00 committed by Gary Katsevman
parent b2c5b2a412
commit 6889e925b4
3 changed files with 0 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/js/big-play-button.js
View File

@ -15,10 +15,6 @@ import Component from './component.js';
*/ */
class BigPlayButton extends Button { class BigPlayButton extends Button {
constructor(player, options) {
super(player, options);
}
/** /**
* Allow sub components to stack CSS class names * Allow sub components to stack CSS class names
* *

4
src/js/button.js
View File

@ -16,10 +16,6 @@ import assign from 'object.assign';
*/ */
class Button extends ClickableComponent { class Button extends ClickableComponent {
constructor(player, options) {
super(player, options);
}
/** /**
* Create the component's DOM element * Create the component's DOM element
* *

20
src/js/clickable-component.js
View File

@ -116,26 +116,6 @@ class ClickableComponent extends Component {
return `vjs-control vjs-button ${super.buildCSSClass()}`; return `vjs-control vjs-button ${super.buildCSSClass()}`;
} }
/**
* Adds a child component inside this clickable-component
*
* @param {String|Component} child The class name or instance of a child to add
* @param {Object=} options Options, including options to be passed to children of the child.
* @return {Component} The child component (created by this process if a string was used)
* @method addChild
*/
addChild(child, options = {}) {
// TODO: Fix adding an actionable child to a ClickableComponent; currently
// it will cause issues with assistive technology (e.g. screen readers)
// which support ARIA, since an element with role="button" cannot have
// actionable child elements.
// let className = this.constructor.name;
// log.warn(`Adding a child to a ClickableComponent (${className}) can cause issues with assistive technology which supports ARIA, since an element with role="button" cannot have actionable child elements.`);
return super.addChild(child, options);
}
/** /**
* Enable the component element * Enable the component element
* *