From 7b7452ff9f1b67feefe719b19cd7e8357f6f5ab2 Mon Sep 17 00:00:00 2001 From: Jim Whisenant Date: Fri, 29 Mar 2013 18:13:49 -0400 Subject: [PATCH 1/2] added a note to advise users to stick with an earlier version of Node.js until the known issue with phantomjs is fixed. fixes #477 --- CONTRIBUTING.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e2bb5512f..708f322d9 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -10,6 +10,7 @@ Don't miss the [code style guide](#code-style). # Getting started 1. [Download and install Node.js](http://nodejs.org/download/). Video.js uses Node for build and test automation. + Note that there is a known issue between Node.js version 0.10.x and phantomjs. This will manifest itself during the node module installation (see step 4 below). For the time being, please install Node.js version 0.8.22 or earlier. You can find earlier versions of Node.js [here](http://nodejs.org/dist/). 2. [Fork](http://help.github.com/fork-a-repo/) and clone the video.js git repository. From ece4f7e5e9afa83371af160f9a3c662e61e95c32 Mon Sep 17 00:00:00 2001 From: Jim Whisenant Date: Tue, 2 Apr 2013 21:58:37 -0400 Subject: [PATCH 2/2] Added a note about the known issue between phantomjs and Node 0.10.x --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 708f322d9..99a2ec9de 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -10,7 +10,7 @@ Don't miss the [code style guide](#code-style). # Getting started 1. [Download and install Node.js](http://nodejs.org/download/). Video.js uses Node for build and test automation. - Note that there is a known issue between Node.js version 0.10.x and phantomjs. This will manifest itself during the node module installation (see step 4 below). For the time being, please install Node.js version 0.8.22 or earlier. You can find earlier versions of Node.js [here](http://nodejs.org/dist/). + There is a known issue between Node.js version 0.10.x and phantomjs. This will manifest itself during the node module installation (see step 4 below). For the time being, please install Node.js version 0.8.22 or earlier. You can find earlier versions of Node.js [here](http://nodejs.org/dist/). 2. [Fork](http://help.github.com/fork-a-repo/) and clone the video.js git repository.