web/video.js
1
0
Fork 0
mirror of https://github.com/videojs/video.js.git synced 2024-11-28 08:58:46 +02:00
Code Releases Activity

fix: call component dispose in resize manager to fix leak (#5369)

Browse Source 
Because we add Touch Activity in the parent class and those don't actually get removed in Resize Manager we leak on every dispose. Calling super.dispose() cleans them up because we remove our list of handlers via a call to DomData.removeData

Fixes #5339
This commit is contained in:
Brandon Casey 2018-08-10 16:21:13 -04:00 committed by Gary Katsevman
parent db4b89434a
commit 6f072d8e2f
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/js/resize-manager.js
View File

@ -47,7 +47,10 @@ class ResizeManager extends Component {
}
// Only create an element when ResizeObserver isn't available
const options_ = mergeOptions({createEl: !RESIZE_OBSERVER_AVAILABLE}, options);
const options_ = mergeOptions({
createEl: !RESIZE_OBSERVER_AVAILABLE,
reportTouchActivity: false
}, options);
super(player, options_);
@ -115,6 +118,7 @@ class ResizeManager extends Component {
this.resizeObserver = null;
this.debouncedHandler_ = null;
this.loadListener_ = null;
super.dispose();
}
}