From 7171ea8d4238bab5099686cd2255b77c20523206 Mon Sep 17 00:00:00 2001 From: Garrett Singer Date: Wed, 25 Nov 2015 16:00:49 -0500 Subject: [PATCH] @gesinger checked for track changes before tech started listening. closes #2835 --- CHANGELOG.md | 2 +- src/js/tech/tech.js | 1 + test/unit/tracks/tracks.test.js | 10 ++++++++++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 95337e507..c196c36f6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,7 +2,7 @@ CHANGELOG ========= ## HEAD (Unreleased) -_(none)_ +* @gesinger checked for track changes before tech started listening ([view](https://github.com/videojs/video.js/pull/2835)) -------------------- diff --git a/src/js/tech/tech.js b/src/js/tech/tech.js index 866bf81a9..b7d76dd28 100644 --- a/src/js/tech/tech.js +++ b/src/js/tech/tech.js @@ -335,6 +335,7 @@ class Tech extends Component { } }); + textTracksChanges(); tracks.addEventListener('change', textTracksChanges); this.on('dispose', function() { diff --git a/test/unit/tracks/tracks.test.js b/test/unit/tracks/tracks.test.js index 7a51f465b..7b0663259 100644 --- a/test/unit/tracks/tracks.test.js +++ b/test/unit/tracks/tracks.test.js @@ -342,3 +342,13 @@ if (Html5.supportsNativeTextTracks()) { emulatedTt.on('addtrack', addtrack); }); } + +test('should check for text track changes when emulating text tracks', function() { + let tech = new Tech(); + let numTextTrackChanges = 0; + tech.on('texttrackchange', function() { + numTextTrackChanges++; + }); + tech.emulateTextTracks(); + equal(numTextTrackChanges, 1, 'we got a texttrackchange event'); +});