web/video.js
1
0
Fork 0
mirror of https://github.com/videojs/video.js.git synced 2025-02-08 12:05:47 +02:00
Code Releases Activity

fix(middleware): do a null check in mediator methods (#4913)

Browse Source
This commit is contained in:
Gary Katsevman 2018-01-31 10:46:58 -05:00 committed by GitHub
parent 4404e071ba
commit 7670db63cd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/js/tech/middleware.js
View File

@ -96,8 +96,10 @@ function executeRight(mws, method, value, terminated) {
for (let i = mws.length - 1; i >= 0; i--) { for (let i = mws.length - 1; i >= 0; i--) {
const mw = mws[i]; const mw = mws[i];
if (mw[method]) {
mw[method](terminated, value); mw[method](terminated, value);
} }
}
} }
function setSourceHelper(src = {}, middleware = [], next, player, acc = [], lastRun = false) { function setSourceHelper(src = {}, middleware = [], next, player, acc = [], lastRun = false) {

15
test/unit/tech/middleware.test.js
View File

@ -394,3 +394,18 @@ QUnit.test('setSource will select all middleware of a given type, until src chan
middleware.getMiddleware('video/foo').pop(); middleware.getMiddleware('video/foo').pop();
middleware.getMiddleware('video/foo').pop(); middleware.getMiddleware('video/foo').pop();
}); });
QUnit.test('a middleware without a mediator method will not throw an error', function(assert) {
let pauseCalled = 0;
const myMw = {};
const mwFactory = () => myMw;
const mwFactory2 = () => ({
pause() {
pauseCalled++;
}
});
middleware.mediate([mwFactory(), mwFactory2()], {pause: () => {}}, 'pause');
assert.equal(pauseCalled, 1, 'pauseCalled was called once and no error was thrown');
});