web/video.js
1
0
Fork 0
mirror of https://github.com/videojs/video.js.git synced 2025-02-10 12:08:14 +02:00
Code Releases Activity

fix(text-tracks): keep showing captions even if the text track settings were disabled (#4974)

Browse Source 
If a user disabled the text track setting component, trying to play emulated captions would crash. Add a null check before applying the text track settings.

Fixes #4964.
This commit is contained in:
ookami125 2018-03-05 17:11:51 -05:00 committed by Gary Katsevman
parent 9c4ded8899
commit 7facc44893
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/js/tracks/text-track-display.js
View File

@ -270,7 +270,6 @@ class TextTrackDisplay extends Component {
return;
}
const overrides = this.player_.textTrackSettings.getValues();
const cues = [];
for (let i = 0; i < track.activeCues.length; i++) {
@ -279,6 +278,12 @@ class TextTrackDisplay extends Component {
window.WebVTT.processCues(window, cues, this.el_);
if (!this.player_.textTrackSettings) {
return;
}
const overrides = this.player_.textTrackSettings.getValues();
let i = cues.length;
while (i--) {