web/video.js
1
0
Fork 0
mirror of https://github.com/videojs/video.js.git synced 2024-12-02 09:11:54 +02:00
Code Releases Activity

Fixed an issue where the tag player reference wasn't getting killed in the minified version

Browse Source
This commit is contained in:
Steve Heffernan 2013-06-28 15:42:47 -07:00
parent c616695e4d
commit 9f647ef081
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/js/player.js
View File

@ -210,7 +210,7 @@ vjs.Player.prototype.loadTech = function(techName, source){
// So we need to remove it if we're not loading HTML5 // So we need to remove it if we're not loading HTML5
} else if (techName !== 'Html5' && this.tag) { } else if (techName !== 'Html5' && this.tag) {
this.el_.removeChild(this.tag); this.el_.removeChild(this.tag);
this.tag.player = null; this.tag['player'] = null;
this.tag = null; this.tag = null;
} }

3
test/unit/player.js
View File

@ -108,7 +108,8 @@ test('should get tag, source, and track settings', function(){
player.dispose(); player.dispose();
ok(tag['player'] === null, 'tag player ref killed');
ok(tag['player'] !== player, 'tag player ref killed');
ok(!vjs.players['example_1'], 'global player ref killed'); ok(!vjs.players['example_1'], 'global player ref killed');
ok(player.el() === null, 'player el killed'); ok(player.el() === null, 'player el killed');
}); });