web/video.js
1
0
Fork 0
mirror of https://github.com/videojs/video.js.git synced 2025-01-19 10:54:16 +02:00
Code Releases Activity

@misteroneill fixed tsml to be used as a tag for template strings. closes #2629

Browse Source
This commit is contained in:
Pat O'Neill 2015-09-25 14:13:56 -04:00 committed by Gary Katsevman
parent 992e5e63f5
commit ad0820cfa3
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -145,6 +145,7 @@ CHANGELOG
* @heff fixed timeranges deprecation warnings in tests ([view](https://github.com/videojs/video.js/pull/2627)) * @heff fixed timeranges deprecation warnings in tests ([view](https://github.com/videojs/video.js/pull/2627))
* @misteroneill updated play control to use its state for icon ([view](https://github.com/videojs/video.js/pull/2636)) * @misteroneill updated play control to use its state for icon ([view](https://github.com/videojs/video.js/pull/2636))
* @gkatsev exposed isCrossOrigin and used it to enable CORS for textTrack XHRs ([view](https://github.com/videojs/video.js/pull/2633)) * @gkatsev exposed isCrossOrigin and used it to enable CORS for textTrack XHRs ([view](https://github.com/videojs/video.js/pull/2633))
* @misteroneill fixed tsml to be used as a tag for template strings ([view](https://github.com/videojs/video.js/pull/2629))
-------------------- --------------------

4
src/js/utils/dom.js
View File

@ -41,9 +41,9 @@ export function createEl(tagName='div', properties={}, attributes={}){
// We originally were accepting both properties and attributes in the // We originally were accepting both properties and attributes in the
// same object, but that doesn't work so well. // same object, but that doesn't work so well.
if (propName.indexOf('aria-') !== -1 || propName === 'role' || propName === 'type') { if (propName.indexOf('aria-') !== -1 || propName === 'role' || propName === 'type') {
log.warn(tsml(`Setting attributes in the second argument of createEl() log.warn(tsml`Setting attributes in the second argument of createEl()
has been deprecated. Use the third argument instead. has been deprecated. Use the third argument instead.
createEl(type, properties, attributes). Attempting to set ${propName} to ${val}.`)); createEl(type, properties, attributes). Attempting to set ${propName} to ${val}.`);
el.setAttribute(propName, val); el.setAttribute(propName, val);
} else { } else {
el[propName] = val; el[propName] = val;