web/video.js
1
0
Fork 0
mirror of https://github.com/videojs/video.js.git synced 2025-07-15 01:34:23 +02:00
Code Releases Activity

fix: need to determine featuresVideoFrameCallback before setting source (#7812)

Browse Source 
the tech needs to know whether or not the underlying element supports requestVideoFrameCallback before calling setSource

Fixes #7807
This commit is contained in:
Joe Flateau
2022-06-28 16:01:00 -04:00
committed by GitHub
parent fb43a69e70
commit b22a08aad0
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/js/tech/html5.js
View File

@ -39,6 +39,8 @@ class Html5 extends Tech {
const source = options.source; const source = options.source;
let crossoriginTracks = false; let crossoriginTracks = false;
this.featuresVideoFrameCallback = this.featuresVideoFrameCallback && this.el_.tagName === 'VIDEO';
// Set the source if one is provided // Set the source if one is provided
// 1) Check if the source is new (if not, we want to keep the original so playback isn't interrupted) // 1) Check if the source is new (if not, we want to keep the original so playback isn't interrupted)
// 2) Check to see if the network state of the tag was failed at init, and if so, reset the source // 2) Check to see if the network state of the tag was failed at init, and if so, reset the source
@ -114,8 +116,6 @@ class Html5 extends Tech {
// into a `fullscreenchange` event // into a `fullscreenchange` event
this.proxyWebkitFullscreen_(); this.proxyWebkitFullscreen_();
this.featuresVideoFrameCallback = this.featuresVideoFrameCallback && this.el_.tagName === 'VIDEO';
this.triggerReady(); this.triggerReady();
} }

5
test/unit/tech/html5.test.js
View File

@ -1035,7 +1035,10 @@ QUnit.test('supports getting available media playback quality metrics', function
QUnit.test('featuresVideoFrameCallback is false for audio elements', function(assert) { QUnit.test('featuresVideoFrameCallback is false for audio elements', function(assert) {
const el = document.createElement('audio'); const el = document.createElement('audio');
const audioTech = new Html5({el}); const audioTech = new Html5({
el,
source: [{src: 'https://example.org/stream.m3u8'}]
});
assert.strictEqual(audioTech.featuresVideoFrameCallback, false, 'Html5 with audio element should not support rvf'); assert.strictEqual(audioTech.featuresVideoFrameCallback, false, 'Html5 with audio element should not support rvf');