web/video.js
1
0
Fork 0
mirror of https://github.com/videojs/video.js.git synced 2025-01-15 10:39:58 +02:00
Code Releases Activity

refactor: Buttons will always use a button element (#3828)

Browse Source 
BREAKING CHANGE: button component will always use a button element.
This commit is contained in:
Pat O'Neill 2017-01-18 00:28:01 -05:00 committed by Gary Katsevman
parent 20141202c1
commit c340dbcccd
1 changed files with 6 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/js/button.js
View File

@ -16,8 +16,9 @@ class Button extends ClickableComponent {
/**
* Create the `Button`s DOM element.
*
* @param {string} [tag=button]
* Element's node type. e.g. 'button'
* @param {string} [tag="button"]
* The element's node type. This argument is IGNORED: no matter what
* is passed, it will always create a `button` element.
*
* @param {Object} [props={}]
* An object of properties that should be set on the element.
@ -28,25 +29,13 @@ class Button extends ClickableComponent {
* @return {Element}
* The element that gets created.
*/
createEl(tag = 'button', props = {}, attributes = {}) {
createEl(tag, props = {}, attributes = {}) {
tag = 'button';
props = assign({
className: this.buildCSSClass()
}, props);
if (tag !== 'button') {
log.warn(`Creating a Button with an HTML element of ${tag} is deprecated; use ClickableComponent instead.`);
// Add properties for clickable element which is not a native HTML button
props = assign({
tabIndex: 0
}, props);
// Add ARIA attributes for clickable element which is not a native HTML button
attributes = assign({
role: 'button'
}, attributes);
}
// Add attributes for button element
attributes = assign({