web/video.js
1
0
Fork 0
mirror of https://github.com/videojs/video.js.git synced 2024-12-21 01:39:04 +02:00
Code Releases Activity

Implement feedback

Browse Source 
- fix typos
- remove `parseInt`
- DRY
This commit is contained in:
Sarah Rimron-Soutter 2023-09-29 11:27:04 +01:00
parent c2599dea22
commit c4aedef0bc
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/js/clickable-component.js
View File

@ -34,7 +34,7 @@ class ClickableComponent extends Component {
* A class or space separated list of classes to add the component * A class or space separated list of classes to add the component
* *
* @param {number | boolean} [options.throttle] * @param {number | boolean} [options.throttle]
* A throttle will be applied to the clickHander if the number is >= 1 or the value is `true` * A throttle will be applied to the clickHandler if the number is >= 1 or the value is `true`
* A number specifies the desired wait time in ms or a default wait of 50ms will be applied * A number specifies the desired wait time in ms or a default wait of 50ms will be applied
* *
*/ */
@ -46,20 +46,22 @@ class ClickableComponent extends Component {
this.controlText(this.options_.controlText); this.controlText(this.options_.controlText);
} }
const throttleIsNumber = typeof this.options_.throttle === 'number';
const boundClick = this.handleClick.bind(this);
const selectClickHandler = () => { const selectClickHandler = () => {
if (typeof this.options_.throttle === 'number' || this.options_.throttle === true) { if (throttleIsNumber || this.options_.throttle === true) {
const wait = typeof this.options_.throttle === 'number' ? parseInt(this.options_.throttle, 10) : 50; const wait = throttleIsNumber ? this.options_.throttle : 50;
return throttle(this.handleClick.bind(this), wait); return throttle(boundClick, wait);
} }
return this.handleClick.bind(this); return boundClick;
}; };
const selectedClickHander = selectClickHandler(); const selectedClickHandler = selectClickHandler();
this.handleMouseOver_ = (e) => this.handleMouseOver(e); this.handleMouseOver_ = (e) => this.handleMouseOver(e);
this.handleMouseOut_ = (e) => this.handleMouseOut(e); this.handleMouseOut_ = (e) => this.handleMouseOut(e);
this.handleClick_ = (e) => selectedClickHander(e); this.handleClick_ = (e) => selectedClickHandler(e);
this.handleKeyDown_ = (e) => this.handleKeyDown(e); this.handleKeyDown_ = (e) => this.handleKeyDown(e);
this.emitTapEvents(); this.emitTapEvents();