web/video.js
1
0
Fork 0
mirror of https://github.com/videojs/video.js.git synced 2025-02-02 11:34:50 +02:00
Code Releases Activity

@forbesjo updated emulated tracks to have listeners removed when they are removed. closes #3046

Browse Source
This commit is contained in:
jforbes 2016-02-02 14:29:31 -05:00 committed by Gary Katsevman
parent 58f76136e5
commit c8646aa02b
3 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGELOG.md
View File

@ -2,7 +2,7 @@ CHANGELOG
=========
## HEAD (Unreleased)
_(none)_
* @forbesjo updated emulated tracks to have listeners removed when they are removed ([view](https://github.com/videojs/video.js/pull/3046))
--------------------

3
src/js/tracks/text-track-list.js
View File

@ -111,6 +111,9 @@ TextTrackList.prototype.removeTrack_ = function(rtrack) {
for (let i = 0, l = this.length; i < l; i++) {
if (this[i] === rtrack) {
track = this[i];
if (track.off) {
track.off();
}
this.tracks_.splice(i, 1);

19
test/unit/tracks/text-track-list.test.js
View File

@ -6,13 +6,16 @@ var noop = Function.prototype;
var genericTracks = [
{
id: '1',
addEventListener: noop
addEventListener: noop,
off: noop
}, {
id: '2',
addEventListener: noop
addEventListener: noop,
off: noop
}, {
id: '3',
addEventListener: noop
addEventListener: noop,
off: noop
}
];
@ -36,9 +39,9 @@ test('can get text tracks by id', function() {
test('length is updated when new tracks are added or removed', function() {
var ttl = new TextTrackList(genericTracks);
ttl.addTrack_({id: '100', addEventListener: noop});
ttl.addTrack_({id: '100', addEventListener: noop, off: noop});
equal(ttl.length, genericTracks.length + 1, 'the length is ' + (genericTracks.length + 1));
ttl.addTrack_({id: '101', addEventListener: noop});
ttl.addTrack_({id: '101', addEventListener: noop, off: noop});
equal(ttl.length, genericTracks.length + 2, 'the length is ' + (genericTracks.length + 2));
ttl.removeTrack_(ttl.getTrackById('101'));
@ -71,8 +74,8 @@ test('can access new items by index', function() {
test('cannot access removed items by index', function() {
var ttl = new TextTrackList(genericTracks);
ttl.addTrack_({id: '100', addEventListener: noop});
ttl.addTrack_({id: '101', addEventListener: noop});
ttl.addTrack_({id: '100', addEventListener: noop, off: noop});
ttl.addTrack_({id: '101', addEventListener: noop, off: noop});
equal(ttl[3].id, '100', 'id of item at index 3 is 100');
equal(ttl[4].id, '101', 'id of item at index 4 is 101');
@ -86,7 +89,7 @@ test('cannot access removed items by index', function() {
test('new item available at old index', function() {
var ttl = new TextTrackList(genericTracks);
ttl.addTrack_({id: '100', addEventListener: noop});
ttl.addTrack_({id: '100', addEventListener: noop, off: noop});
equal(ttl[3].id, '100', 'id of item at index 3 is 100');
ttl.removeTrack_(ttl.getTrackById('100'));