From d38806dacd8d451fbb30a83e599ab58659ddcd27 Mon Sep 17 00:00:00 2001 From: Garrett Singer Date: Tue, 30 Nov 2021 00:40:59 -0500 Subject: [PATCH] chore: fix typo in COLLABORATOR_GUIDE (#7537) --- COLLABORATOR_GUIDE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 75bc6f86f..ef89b36f5 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -65,7 +65,7 @@ If you are unsure about the modification and cannot take responsibility for it, Before merging the change, it should be left open for other core committers to comment on. At least 24 hours during a weekday, and the 48 hours on a weekend. Trivial changes or bug fixes that have been reviewed by multiple committers may be merged without delay. -For non-breaking changes, if there is no disagreeming between the collaborators, the PR may be landed assuming it was reviewed. If there is still disagreement, it may need to be [escalated to the TSC](#involving-the-tsc). +For non-breaking changes, if there is no disagreement between the collaborators, the PR may be landed assuming it was reviewed. If there is still disagreement, it may need to be [escalated to the TSC](#involving-the-tsc). Bug fixes require a test case that fails beforehand and succeeds after. All code changes should contain tests and pass on the CI.