web/video.js
1
0
Fork 0
mirror of https://github.com/videojs/video.js.git synced 2025-07-15 01:34:23 +02:00
Code Releases Activity

fix: prevent dispose error and text track duplicate listeners (#6984)

Browse Source
This commit is contained in:
Brandon Casey
2021-01-21 17:02:15 -05:00
committed by GitHub
parent ffb690af6f
commit db46578ac6
6 changed files with 50 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test/unit/tech/tech.test.js
View File

@ -142,8 +142,9 @@ QUnit.test('dispose() should stop time tracking', function(assert) {
QUnit.test('dispose() should clear all tracks that are passed when its created', function(assert) {
const audioTracks = new AudioTrackList([new AudioTrack(), new AudioTrack()]);
const videoTracks = new VideoTrackList([new VideoTrack(), new VideoTrack()]);
const textTracks = new TextTrackList([new TextTrack({tech: {}}),
new TextTrack({tech: {}})]);
const pretech = new Tech();
const textTracks = new TextTrackList([new TextTrack({tech: pretech}),
new TextTrack({tech: pretech})]);
assert.equal(audioTracks.length, 2, 'should have two audio tracks at the start');
assert.equal(videoTracks.length, 2, 'should have two video tracks at the start');
@ -167,6 +168,7 @@ QUnit.test('dispose() should clear all tracks that are passed when its created',
'should hold text tracks that we passed'
);
pretech.dispose();
tech.dispose();
assert.equal(audioTracks.length, 0, 'should have zero audio tracks after dispose');