web/video.js
1
0
Fork 0
mirror of https://github.com/videojs/video.js.git synced 2024-11-24 08:42:25 +02:00
Code Releases Activity

@nickygerritsen Add title to all clickable components. closes #3296

Browse Source
This commit is contained in:
Nicky Gerritsen 2016-05-17 10:17:12 +02:00
parent b1e7bfd8f8
commit ed39b68f13
3 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -6,6 +6,7 @@ CHANGELOG
* @hartman Correct documentation to refer to nativeTextTracks option ([view](https://github.com/videojs/video.js/pull/3309))
* @nickygerritsen Also pass tech options to canHandleSource ([view](https://github.com/videojs/video.js/pull/3303))
* @misteroneill Un-deprecate the videojs.players property ([view](https://github.com/videojs/video.js/pull/3299))
* @nickygerritsen Add title to all clickable components ([view](https://github.com/videojs/video.js/pull/3296))
--------------------

12
src/js/clickable-component.js
View File

@ -78,7 +78,7 @@ class ClickableComponent extends Component {
el.appendChild(this.controlTextEl_);
}
this.controlText(this.controlText_);
this.controlText(this.controlText_, el);
return this.controlTextEl_;
}
@ -86,15 +86,19 @@ class ClickableComponent extends Component {
/**
* Controls text - both request and localize
*
* @param {String} text Text for element
* @param {String} text Text for element
* @param {Element=} el Element to set the title on
* @return {String}
* @method controlText
*/
controlText(text) {
controlText(text, el=this.el()) {
if (!text) return this.controlText_ || 'Need Text';
const localizedText = this.localize(text);
this.controlText_ = text;
this.controlTextEl_.innerHTML = this.localize(this.controlText_);
this.controlTextEl_.innerHTML = localizedText;
el.setAttribute('title', localizedText);
return this;
}

5
test/unit/button.test.js
View File

@ -4,7 +4,7 @@ import TestHelpers from './test-helpers.js';
q.module('Button');
test('should localize its text', function(){
expect(2);
expect(3);
var player, testButton, el;
@ -22,5 +22,6 @@ test('should localize its text', function(){
el = testButton.createEl();
ok(el.nodeName.toLowerCase().match('button'));
ok(el.innerHTML.match('Juego'));
ok(el.innerHTML.match('vjs-control-text">Juego'));
equal(el.getAttribute('title'), 'Juego');
});