web/video.js
1
0
Fork 0
mirror of https://github.com/videojs/video.js.git synced 2024-11-24 08:42:25 +02:00
Code Releases Activity

Move language methods into externs

Browse Source 
Trying to create a player-like subclass of component requires overriding languages() but that method was being minified. Add it to externs so that it can be overridden after minification. Fixes #1420.
This commit is contained in:
David LaPalomento 2014-09-04 13:13:58 -04:00 committed by Steve Heffernan
parent 54b175d988
commit eec1fc13fe
3 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/js/exports.js
View File

@ -77,8 +77,6 @@ goog.exportProperty(vjs.Player.prototype, 'preload', vjs.Player.prototype.preloa
goog.exportProperty(vjs.Player.prototype, 'remainingTime', vjs.Player.prototype.remainingTime);
goog.exportProperty(vjs.Player.prototype, 'supportsFullScreen', vjs.Player.prototype.supportsFullScreen);
goog.exportProperty(vjs.Player.prototype, 'currentType', vjs.Player.prototype.currentType);
goog.exportProperty(vjs.Player.prototype, 'language', vjs.Player.prototype.language);
goog.exportProperty(vjs.Player.prototype, 'languages', vjs.Player.prototype.languages);
goog.exportSymbol('videojs.MediaLoader', vjs.MediaLoader);
goog.exportSymbol('videojs.TextTrackDisplay', vjs.TextTrackDisplay);

6
src/js/player.externs.js
View File

@ -62,6 +62,12 @@ videojs.Player.prototype.cancelFullScreen = function(){}; /* deprecated */
*/
videojs.Player.prototype.textTracks = function(){};
/**
* Language support
*/
videojs.Player.prototype.language = function(){};
videojs.Player.prototype.languages = function(){};
/**
* Component functions
*/

13
test/unit/api.js
View File

@ -208,3 +208,16 @@ test('fullscreenToggle does not depend on minified player methods', function(){
ok(exitFullscreen, 'exitFullscreen called');
});
test('component can be subclassed externally', function(){
var player = new (videojs.Component.extend({
languages: function(){},
reportUserActivity: function(){},
language: function(){},
textTracks: function(){ return []; }
}))({
id: function(){},
reportUserActivity: function(){}
});
ok(new videojs.ControlBar(player), 'created a control bar without throwing');
});