mirror of
https://github.com/videojs/video.js.git
synced 2024-12-21 01:39:04 +02:00
a10d25861d
## Description Prevents a duplicate id in text track settings. Fixes #8754 ## Specific Changes proposed The text edge settings were erroneously duplicating the id generated for the background colour. Changes to a unique name. Adds a general test for duplicate ids. ## Requirements Checklist - [x] Feature implemented / Bug fixed - [ ] If necessary, more likely in a feature request than a bug fix - [x] Change has been verified in an actual browser (Chrome, Firefox, IE) - [x] Unit Tests updated or fixed - [ ] Docs/guides updated - [ ] Example created ([starter template on JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0)) - [x] Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab) - [x] Has no changes to JSDoc which cause `npm run docs:api` to error - [ ] Reviewed by Two Core Contributors |
||
---|---|---|
.. | ||
api | ||
require | ||
unit | ||
karma.conf.js | ||
sinon.js |