1
0
mirror of https://github.com/videojs/video.js.git synced 2024-12-21 01:39:04 +02:00
video.js/test
mister-ben a10d25861d
fix: removes duplicate id in text track settings (#8755)
## Description
Prevents a duplicate id in text track settings.
Fixes #8754

## Specific Changes proposed
The text edge settings were erroneously duplicating the id generated for
the background colour. Changes to a unique name.
Adds a general test for duplicate ids.

## Requirements Checklist
- [x] Feature implemented / Bug fixed
- [ ] If necessary, more likely in a feature request than a bug fix
- [x] Change has been verified in an actual browser (Chrome, Firefox,
IE)
  - [x] Unit Tests updated or fixed
  - [ ] Docs/guides updated
- [ ] Example created ([starter template on
JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0))
- [x] Has no DOM changes which impact accessiblilty or trigger warnings
(e.g. Chrome issues tab)
  - [x] Has no changes to JSDoc which cause `npm run docs:api` to error
- [ ] Reviewed by Two Core Contributors
2024-06-01 23:11:52 +02:00
..
api refactor: remove internal Map, Set, and WeakMap shams, assume window.performance and requestAnimationFrame support (#7775) 2022-11-23 09:49:24 -05:00
require feat: built-in HLS playback support (#5057) 2018-03-30 14:01:16 -04:00
unit fix: removes duplicate id in text track settings (#8755) 2024-06-01 23:11:52 +02:00
karma.conf.js fix: Replace Object.values with ponyfill (#8267) 2023-05-11 18:57:13 -04:00
sinon.js fix: properly return promise from requestFullscreen and exitFullscreen (#7299) 2021-07-06 14:56:02 -04:00