1c/v8-code-style
1
0
Fork 0
mirror of https://github.com/1C-Company/v8-code-style.git synced 2025-04-05 10:05:38 +02:00
Code Issues Releases Activity

Merge pull request #1111 from 1C-Company/fix-filter-redundant-export

Browse Source 
Добавлена фильтрация модулей для проверки
This commit is contained in:
Dmitriy Marmyshev 2022-08-10 10:24:20 +03:00 committed by GitHub
commit 58e921623a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
bundles/com.e1c.v8codestyle.bsl/src/com/e1c/v8codestyle/bsl/check/RedundantExportMethodCheck.java
View File

@ -70,9 +70,6 @@ public final class RedundantExportMethodCheck
private static final String USER_DATA = "methodName"; //$NON-NLS-1$
private static final Set<ModuleType> CHECKED_MODULES =
Set.of(ModuleType.MANAGER_MODULE, ModuleType.COMMON_MODULE, ModuleType.OBJECT_MODULE);
private static final String DEFAULT_EXCLUDE_REGION_NAME_LIST =
String.join(",", ModuleStructureSection.PUBLIC.getNames()); //$NON-NLS-1$
@ -119,6 +116,8 @@ public final class RedundantExportMethodCheck
.severity(IssueSeverity.MINOR)
.issueType(IssueType.WARNING)
.disable()
.extension(ModuleTypeFilter.onlyTypes(ModuleType.MANAGER_MODULE, ModuleType.COMMON_MODULE,
ModuleType.OBJECT_MODULE))
//.extension(new StandardCheckExtension(getCheckId(), BslPlugin.PLUGIN_ID))
.module()
.checkedObjectType(METHOD)
@ -143,12 +142,6 @@ public final class RedundantExportMethodCheck
}
Module module = EcoreUtil2.getContainerOfType(method, Module.class);
//TODO #1091 move to common filter by module type
ModuleType moduleType = module.getModuleType();
if (!CHECKED_MODULES.contains(moduleType))
{
return;
}
String name = method.getName();
if (isNotExclusion(parameters, method, monitor) && !isScheduledJobOrEventSubscription(module, name, monitor)