1c/v8-code-style
1
0
Fork 0
mirror of https://github.com/1C-Company/v8-code-style.git synced 2025-01-21 05:21:23 +02:00
Code Issues Releases Activity
v8-code-style/bundles/com.e1c.v8codestyle.bsl/markdown/method-too-many-params.md

1.6 KiB
Raw Blame History

Method has to many parameters

It is not recommended to declare many parameters in methods (you need to focus on the number of no more than seven parameters), while there should not be many parameters with default values (you need to focus on the number of no more than three such parameters). Otherwise, the readability of the calling code is greatly reduced. For example, you can easily make a mistake in the number of commas when passing optional parameters.

Noncompliant Code Example

// Adds a new field to a form and initializes it with default values.
Function AddFormField(Name,
      Heading = Undefined,
      OnChangeHandler = "",
      OnBeginSelectionHandler = "",
      MarginWidth,
      Backcolor = Undefined,
      TitleBackColor = Undefined,
      Parent = Undefined,
      HeaderPicture = Undefined,
      DataPath = Undefined,
      FieldReadOnly = False,
      ChoiceParameterLinks = Undefined)
…
EndFunction
­
// calling the function
NewField = AddFormField("OldPrice" + ColumnName, NStr("en='Price'"),,, 12, BackColor, TitleColor, NewFolder,,,True);
NewField.TextColor = WebColors.Gray;

Compliant Solution

// Adds a new field to a form and initializes it with default values.
Function NewFormField(FieldName) 
…
EndFunction
­
// calling the function
NewField = NewFormField("OldPrice" + ColumnName);
NewField.Heading = NStr("en='Price'");
NewField.BackColor = BackColor;
NewField.TextColor = WebColors.Gray;
NewField.… = …
…

See