1
0
mirror of https://gitlab.com/depesz/explain.depesz.com.git synced 2024-11-28 08:58:52 +02:00

Fix mistake in links generated from hints

per report from sheng yan
This commit is contained in:
Hubert depesz Lubaczewski 2024-09-24 17:20:55 +02:00
parent c5637aabb1
commit 0586b12fe4

View File

@ -857,7 +857,7 @@
% my $node_num = $explain_node_id_to_table_node_id->{ $hint->node->id };
<li>
% if ( $hint->type eq 'DISK_SORT' ) {
<p>You have <a href="#<%= $node_num %>" target="_new">sort node (#<%= $node_num %>)</a> that is using disk space to sort.</p>
<p>You have <a href="#l<%= $node_num %>" target="_new">sort node (#<%= $node_num %>)</a> that is using disk space to sort.</p>
<p>This is because your <a href="https://www.postgresql.org/docs/current/runtime-config-<%= $guc_docs->{ 'work_mem' } %>" target='_new'>work_mem</a> setting is too low.</p>
<p>Increasing it can make the sort run in memory, or, at least, use less of disk. Sort used <%= $hint->details->[0] %>kB, so you would need to set your work_mem to <em>at least</em> that much to have a chance at sorting in memory only.</p>
% } elsif ( $hint->type eq 'INDEXABLE_SEQSCAN_SIMPLE' ) {
@ -866,7 +866,7 @@
% my $operator = $hint->details->[1];
% my $fetched_rows = $hint->node->total_rows + $hint->node->total_rows_removed;
% my $dropped_rows = $hint->node->total_rows_removed;
<p>You have <a href="#<%= $node_num %>" target="_new"><%= $hint->node->type %> (#<%= $node_num %>)</a> that could use an index.</p>
<p>You have <a href="#l<%= $node_num %>" target="_new"><%= $hint->node->type %> (#<%= $node_num %>)</a> that could use an index.</p>
<p>This node searches in table <em><%= $table_name %></em> using <em><%= $operator %></em> operator on column <em><%= $column_name %></em>. In process it fetches from disk <%= commify_number( $fetched_rows ) %> rows, just to drop
% if ( $fetched_rows == $dropped_rows ) {
<em>all</em>
@ -881,7 +881,7 @@
% my @columns = map { $_->{'column'} } @{ $hint->details };
% my $fetched_rows = $hint->node->total_rows + $hint->node->total_rows_removed;
% my $dropped_rows = $hint->node->total_rows_removed;
<p>You have <a href="#<%= $node_num %>" target="_new"><%= $hint->node->type %> (#<%= $node_num %>)</a> that could use an index.</p>
<p>You have <a href="#l<%= $node_num %>" target="_new"><%= $hint->node->type %> (#<%= $node_num %>)</a> that could use an index.</p>
<p>This node searches in table <em><%= $table_name %></em> using many comparisons using <em>=</em> operator, on columns:
% for my $column_no ( 0 .. $#columns ) {
% if ($column_no == $#columns ) {