db/pgbackrest
1
0
Fork 0
mirror of https://github.com/pgbackrest/pgbackrest.git synced 2024-12-16 10:20:02 +02:00
Code Issues Releases Activity
77853d3c13
pgbackrest/test/lib/pgBackRestTest/Module/Mock/MockAllTest.pm

975 lines
53 KiB
Perl
Raw Normal View History

Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
####################################################################################################################################
Split full module into mock and real to allow better test combinations and save time in CI.
2017-06-20 00:55:00 +02:00
# Test All Commands on Mock Data
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
####################################################################################################################################
Split full module into mock and real to allow better test combinations and save time in CI.
2017-06-20 00:55:00 +02:00
package pgBackRestTest::Module::Mock::MockAllTest;
Moved test and env modules to new directories to avoid namespace conflicts with common tests.
2017-05-12 22:43:04 +02:00
use parent 'pgBackRestTest::Env::HostEnvTest';
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
####################################################################################################################################
# Perl includes
####################################################################################################################################
use strict;
use warnings FATAL => qw(all);
use Carp qw(confess);
Improvements to Ini.pm. * Refactor Ini.pm to facilitate testing. * Complete statement/branch coverage for Ini.pm. * Improved functions used to test/munge manifest and info files.
2017-04-10 19:24:45 +02:00
use File::Basename qw(basename dirname);
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
Rename Archive modules to remove redundancy.
2017-06-21 14:02:21 +02:00
use pgBackRest::Archive::Info;
Move backup modules into Backup directory.
2017-05-15 22:01:00 +02:00
use pgBackRest::Backup::Common;
use pgBackRest::Backup::Info;
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
use pgBackRest::DbVersion;
use pgBackRest::Common::Exception;
use pgBackRest::Common::Ini;
use pgBackRest::Common::Log;
use pgBackRest::Common::Wait;
use pgBackRest::Config::Config;
Added stanza-upgrade command. The stanza-upgrade command provides a mechanism for upgrading a stanza after upgrading to a new major version of PostgreSQL. Contributed by Cynthia Shang.
2017-04-03 16:42:55 +02:00
use pgBackRest::InfoCommon;
Reduced the likelihood of torn pages causing a false positive in page checksums by filtering on start backup LSN.
2017-01-30 20:59:00 +02:00
use pgBackRest::LibC qw(:checksum);
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
use pgBackRest::Manifest;
Storage and IO layer refactor: Refactor storage layer to allow for new repository filesystems using drivers. (Reviewed by Cynthia Shang.) Refactor IO layer to allow for new compression formats, checksum types, and other capabilities using filters. (Reviewed by Cynthia Shang.)
2017-06-09 23:51:41 +02:00
use pgBackRest::Protocol::Storage::Helper;
pgBackRest is now pure C. Remove embedded Perl from the distributed binary. This includes code, configure, Makefile, and packages. The distributed binary is now pure C. Remove storagePathEnforceSet() from the C Storage object which allowed Perl to write outside of the storage base directory. Update mock/all and real/all integration tests to use storageLocal() where they were violating this rule. Remove "c" option that allowed the remote to tell if it was being called from C or Perl. Code to convert options to JSON for passing to Perl (perl/config.c) has been moved to LibC since it is still required for Perl integration tests. Update build and installation instructions in the user guide. Remove all Perl unit tests. Remove obsolete Perl code. In particular this included all the Perl protocol code which required modifications to the Perl storage, manifest, and db objects that are still required for integration testing but only run locally. Any remaining Perl code is required for testing, documentation, or code generation. Rename perlReq to binReq in define.yaml to indicate that the binary is required for a test. This had been the actual meaning for quite some time but the key was never renamed.
2019-12-14 00:55:41 +02:00
use pgBackRest::Storage::Helper;
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
use pgBackRest::Version;
use pgBackRestTest::Common::ContainerTest;
use pgBackRestTest::Common::ExecuteTest;
use pgBackRestTest::Common::FileTest;
use pgBackRestTest::Common::RunTest;
Create test matrix for mock/all to increase coverage and reduce tests. The same test configurations are run on all four test VMs, which seems a real waste of resources. Vary the tests per VM to increase coverage while reducing the total number of tests. Be sure to include each major feature (remote, s3, encryption) in each VM at least once.
2019-03-02 15:01:02 +02:00
use pgBackRestTest::Common::VmTest;
Moved test and env modules to new directories to avoid namespace conflicts with common tests.
2017-05-12 22:43:04 +02:00
use pgBackRestTest::Env::Host::HostBackupTest;
S3 repository support.
2017-06-12 16:52:32 +02:00
use pgBackRestTest::Env::Host::HostS3Test;
use pgBackRestTest::Env::HostEnvTest;
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
Reduced the likelihood of torn pages causing a false positive in page checksums by filtering on start backup LSN.
2017-01-30 20:59:00 +02:00
####################################################################################################################################
# Build PostgreSQL pages for testing
####################################################################################################################################
sub pageBuild
{
my $tPageSource = shift;
my $iBlockNo = shift;
my $iWalId = shift;
my $iWalOffset = shift;
my $tPage = defined($iWalId) ? pack('I', $iWalId) . pack('I', $iWalOffset) . substr($tPageSource, 8) : $tPageSource;
Use PG_PAGE_SIZE_DEFAULT constant instead of pageSize variable. Page size is passed around a lot but in fact it can only have one value, PG_PAGE_SIZE_DEFAULT, which is checked when pg_control is loaded. There may be an argument for supporting multiple page sizes in the future but for now just use the constant to simplify the code. There is also a significant performance benefit. Because pageSize was being used in pageChecksumBlock() the main loop was neither unrolled nor vectorized (-funroll-loops -ftree-vectorize) as it is now with a constant loop boundary.
2020-03-05 16:14:27 +02:00
my $iChecksum = pgPageChecksum($tPage, $iBlockNo);
Reduced the likelihood of torn pages causing a false positive in page checksums by filtering on start backup LSN.
2017-01-30 20:59:00 +02:00
return substr($tPage, 0, 8) . pack('S', $iChecksum) . substr($tPage, 10);
}
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
####################################################################################################################################
# run
####################################################################################################################################
sub run
{
my $self = shift;
Create test matrix for mock/all to increase coverage and reduce tests. The same test configurations are run on all four test VMs, which seems a real waste of resources. Vary the tests per VM to increase coverage while reducing the total number of tests. Be sure to include each major feature (remote, s3, encryption) in each VM at least once.
2019-03-02 15:01:02 +02:00
foreach my $rhRun
(
{vm => VM1, remote => false, s3 => true, encrypt => false, delta => true},
{vm => VM1, remote => true, s3 => false, encrypt => true, delta => false},
{vm => VM2, remote => false, s3 => false, encrypt => true, delta => true},
{vm => VM2, remote => true, s3 => true, encrypt => false, delta => false},
{vm => VM3, remote => false, s3 => false, encrypt => false, delta => true},
{vm => VM3, remote => true, s3 => true, encrypt => true, delta => false},
Disable S3 and encryption on u18 integration tests for mock/all/1. This test is commonly used for sanity checking but the combination of S3 and encryption makes it hard to use and encourages temporary changes to make it usable. Acknowledge this and disable S3 and encryption for this test and move them to mock/all/2.
2019-09-03 01:06:12 +02:00
{vm => VM4, remote => false, s3 => false, encrypt => false, delta => false},
{vm => VM4, remote => true, s3 => true, encrypt => true, delta => true},
Create test matrix for mock/all to increase coverage and reduce tests. The same test configurations are run on all four test VMs, which seems a real waste of resources. Vary the tests per VM to increase coverage while reducing the total number of tests. Be sure to include each major feature (remote, s3, encryption) in each VM at least once.
2019-03-02 15:01:02 +02:00
)
S3 repository support.
2017-06-12 16:52:32 +02:00
{
Create test matrix for mock/all to increase coverage and reduce tests. The same test configurations are run on all four test VMs, which seems a real waste of resources. Vary the tests per VM to increase coverage while reducing the total number of tests. Be sure to include each major feature (remote, s3, encryption) in each VM at least once.
2019-03-02 15:01:02 +02:00
# Only run tests for this vm
Allow mock integration tests for all VM types. Previously the mock integration tests would be skipped for VMs other than the standard four used in CI. Now VMs outside the standard four will run the same tests as VM4 (currently U18).
2019-11-02 11:35:48 +02:00
next if ($rhRun->{vm} ne vmTest($self->vm()));
Create test matrix for mock/all to increase coverage and reduce tests. The same test configurations are run on all four test VMs, which seems a real waste of resources. Vary the tests per VM to increase coverage while reducing the total number of tests. Be sure to include each major feature (remote, s3, encryption) in each VM at least once.
2019-03-02 15:01:02 +02:00
# Increment the run, log, and decide whether this unit test should be run
my $bRemote = $rhRun->{remote};
my $bS3 = $rhRun->{s3};
my $bEncrypt = $rhRun->{encrypt};
my $bDeltaBackup = $rhRun->{delta};
Repository encryption support. Contributed by Cynthia Shang.
2017-11-06 19:51:12 +02:00
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Increment the run, log, and decide whether this unit test should be run
Create test matrix for mock/all to increase coverage and reduce tests. The same test configurations are run on all four test VMs, which seems a real waste of resources. Vary the tests per VM to increase coverage while reducing the total number of tests. Be sure to include each major feature (remote, s3, encryption) in each VM at least once.
2019-03-02 15:01:02 +02:00
if (!$self->begin("rmt ${bRemote}, s3 ${bS3}, enc ${bEncrypt}, delta ${bDeltaBackup}")) {next}
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Create hosts, file object, and config
S3 repository support.
2017-06-12 16:52:32 +02:00
my ($oHostDbMaster, $oHostDbStandby, $oHostBackup, $oHostS3) = $self->setup(
Create test matrix for mock/all to increase coverage and reduce tests. The same test configurations are run on all four test VMs, which seems a real waste of resources. Vary the tests per VM to increase coverage while reducing the total number of tests. Be sure to include each major feature (remote, s3, encryption) in each VM at least once.
2019-03-02 15:01:02 +02:00
true, $self->expect(), {bHostBackup => $bRemote, bCompress => false, bS3 => $bS3, bRepoEncrypt => $bEncrypt});
Reduce process redundancy in mock tests.
2017-06-22 00:47:25 +02:00
# If S3 set process max to 2. This seems like the best place for parallel testing since it will help speed S3 processing
# without slowing down the other tests too much.
if ($bS3)
{
Configuration rules are now pulled from the C library when present.
2017-08-25 22:47:47 +02:00
$oHostBackup->configUpdate({&CFGDEF_SECTION_GLOBAL => {cfgOptionName(CFGOPT_PROCESS_MAX) => 2}});
$oHostDbMaster->configUpdate({&CFGDEF_SECTION_GLOBAL => {cfgOptionName(CFGOPT_PROCESS_MAX) => 2}});
Reduce process redundancy in mock tests.
2017-06-22 00:47:25 +02:00
Reduce log level for all expect tests to detail. The C code is designed to be efficient rather than deterministic at the debug log level. As we move more testing from integration to unit tests it makes less sense to try and maintain the expect logs at this log level. Most of the expect logs have already been moved to detail level but mock/all still had tests at debug level. Change the logging defaults in the config file and remove as many references to log-level-console as possible.
2019-05-23 00:23:44 +02:00
# Reduce log level to warn because parallel tests do not create deterministic logs
Configuration rules are now pulled from the C library when present.
2017-08-25 22:47:47 +02:00
$oHostBackup->configUpdate({&CFGDEF_SECTION_GLOBAL => {cfgOptionName(CFGOPT_LOG_LEVEL_CONSOLE) => lc(WARN)}});
$oHostDbMaster->configUpdate({&CFGDEF_SECTION_GLOBAL => {cfgOptionName(CFGOPT_LOG_LEVEL_CONSOLE) => lc(WARN)}});
Reduce process redundancy in mock tests.
2017-06-22 00:47:25 +02:00
}
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Get base time
my $lTime = time() - 10000;
# Build the manifest
my %oManifest;
Rename PGBACKREST/BACKREST constants to PROJECT. This brings consistency between the C and Perl constants and allows for easier code reuse.
2018-11-25 02:05:03 +02:00
$oManifest{&INI_SECTION_BACKREST}{&INI_KEY_VERSION} = PROJECT_VERSION;
$oManifest{&INI_SECTION_BACKREST}{&INI_KEY_FORMAT} = REPOSITORY_FORMAT;
Set archive-check option in manifest correctly when offline. Archive check does not run when in offline backup mode but the option was set to true in the manifest. It's harmless since these options are informational only but it could cause confusion when debugging.
2019-11-28 15:27:21 +02:00
$oManifest{&MANIFEST_SECTION_BACKUP_OPTION}{&MANIFEST_KEY_ARCHIVE_CHECK} = JSON::PP::false;
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$oManifest{&MANIFEST_SECTION_BACKUP_OPTION}{&MANIFEST_KEY_ARCHIVE_COPY} = JSON::PP::true;
$oManifest{&MANIFEST_SECTION_BACKUP_OPTION}{&MANIFEST_KEY_BACKUP_STANDBY} = JSON::PP::false;
Add additional options to backup.manifest for debugging purposes. Add the buffer-size, compress-level, compress-level-network, and process-max options to the backup:option section in backup.manifest to aid in debugging. It may also make sense to propagate these options up to backup.info so they can be displayed in the info command, but for now this is deemed sufficient. Contributed by blogh.
2019-03-10 11:03:52 +02:00
$oManifest{&MANIFEST_SECTION_BACKUP_OPTION}{&MANIFEST_KEY_BUFFER_SIZE} = 16384;
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$oManifest{&MANIFEST_SECTION_BACKUP_OPTION}{&MANIFEST_KEY_CHECKSUM_PAGE} = JSON::PP::true;
Full/Synthetic test refactor. * Combine hardlink and non/compressed in synthetic tests to reduce test time and improve coverage. * Change log level of hardlink logging to detail. * Cast size in S3 manifest to integer.
2017-06-15 21:32:10 +02:00
$oManifest{&MANIFEST_SECTION_BACKUP_OPTION}{&MANIFEST_KEY_COMPRESS} = JSON::PP::false;
Add additional options to backup.manifest for debugging purposes. Add the buffer-size, compress-level, compress-level-network, and process-max options to the backup:option section in backup.manifest to aid in debugging. It may also make sense to propagate these options up to backup.info so they can be displayed in the info command, but for now this is deemed sufficient. Contributed by blogh.
2019-03-10 11:03:52 +02:00
$oManifest{&MANIFEST_SECTION_BACKUP_OPTION}{&MANIFEST_KEY_COMPRESS_LEVEL} = 3;
$oManifest{&MANIFEST_SECTION_BACKUP_OPTION}{&MANIFEST_KEY_COMPRESS_LEVEL_NETWORK} = $bRemote ? 1 : 3;
Full/Synthetic test refactor. * Combine hardlink and non/compressed in synthetic tests to reduce test time and improve coverage. * Change log level of hardlink logging to detail. * Cast size in S3 manifest to integer.
2017-06-15 21:32:10 +02:00
$oManifest{&MANIFEST_SECTION_BACKUP_OPTION}{&MANIFEST_KEY_HARDLINK} = JSON::PP::false;
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$oManifest{&MANIFEST_SECTION_BACKUP_OPTION}{&MANIFEST_KEY_ONLINE} = JSON::PP::false;
Add additional options to backup.manifest for debugging purposes. Add the buffer-size, compress-level, compress-level-network, and process-max options to the backup:option section in backup.manifest to aid in debugging. It may also make sense to propagate these options up to backup.info so they can be displayed in the info command, but for now this is deemed sufficient. Contributed by blogh.
2019-03-10 11:03:52 +02:00
$oManifest{&MANIFEST_SECTION_BACKUP_OPTION}{&MANIFEST_KEY_PROCESS_MAX} = $bS3 ? 2 : 1;
Add checksum delta for incremental backups. Use checksums rather than timestamps to determine if files have changed. This is useful in cases where the timestamps may not be trustworthy, e.g. when performing an incremental after failing over to a standby. If checksum delta is enabled then checksums will be used for verification of resumed backups, even if they are full. Resumes have always used checksums to verify the files in the repository, enabling delta performs checksums on the database files as well. Note that the user must manually enable this feature in cases were it would be useful or just keep in enabled all the time. A future commit will address automatically enabling the feature in cases where it seems likely to be useful. Contributed by Cynthia Shang.
2018-09-19 17:12:45 +02:00
$oManifest{&MANIFEST_SECTION_BACKUP_OPTION}{&MANIFEST_KEY_DELTA} = JSON::PP::false;
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
Create test matrix for mock/all to increase coverage and reduce tests. The same test configurations are run on all four test VMs, which seems a real waste of resources. Vary the tests per VM to increase coverage while reducing the total number of tests. Be sure to include each major feature (remote, s3, encryption) in each VM at least once.
2019-03-02 15:01:02 +02:00
if ($bEncrypt)
Repository encryption support. Contributed by Cynthia Shang.
2017-11-06 19:51:12 +02:00
{
$oManifest{&INI_SECTION_CIPHER}{&INI_KEY_CIPHER_PASS} = 'REPLACEME';
}
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$oManifest{&MANIFEST_SECTION_BACKUP_DB}{&MANIFEST_KEY_CATALOG} = 201409291;
$oManifest{&MANIFEST_SECTION_BACKUP_DB}{&MANIFEST_KEY_CONTROL} = 942;
Automate generation of WAL and pg_control test files. The existing static files would not work with 32-bit or big-endian systems so create functions to generate these files dynamically rather than creating a bunch of new static files.
2017-11-19 03:02:54 +02:00
$oManifest{&MANIFEST_SECTION_BACKUP_DB}{&MANIFEST_KEY_SYSTEM_ID} = 1000000000000000094;
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$oManifest{&MANIFEST_SECTION_BACKUP_DB}{&MANIFEST_KEY_DB_VERSION} = PG_VERSION_94;
$oManifest{&MANIFEST_SECTION_BACKUP_DB}{&MANIFEST_KEY_DB_ID} = 1;
$oManifest{&MANIFEST_SECTION_BACKUP_TARGET}{&MANIFEST_TARGET_PGDATA}{&MANIFEST_SUBKEY_PATH} =
$oHostDbMaster->dbBasePath();
$oManifest{&MANIFEST_SECTION_BACKUP_TARGET}{&MANIFEST_TARGET_PGDATA}{&MANIFEST_SUBKEY_TYPE} = MANIFEST_VALUE_PATH;
$oHostDbMaster->manifestPathCreate(\%oManifest, MANIFEST_TARGET_PGDATA);
$oHostDbMaster->manifestFileCreate(\%oManifest, MANIFEST_TARGET_PGDATA, DB_FILE_PGVERSION, PG_VERSION_94,
'184473f470864e067ee3a22e64b47b0a1c356f29', $lTime, undef, true);
# Load sample page
pgBackRest is now pure C. Remove embedded Perl from the distributed binary. This includes code, configure, Makefile, and packages. The distributed binary is now pure C. Remove storagePathEnforceSet() from the C Storage object which allowed Perl to write outside of the storage base directory. Update mock/all and real/all integration tests to use storageLocal() where they were violating this rule. Remove "c" option that allowed the remote to tell if it was being called from C or Perl. Code to convert options to JSON for passing to Perl (perl/config.c) has been moved to LibC since it is still required for Perl integration tests. Update build and installation instructions in the user guide. Remove all Perl unit tests. Remove obsolete Perl code. In particular this included all the Perl protocol code which required modifications to the Perl storage, manifest, and db objects that are still required for integration testing but only run locally. Any remaining Perl code is required for testing, documentation, or code generation. Rename perlReq to binReq in define.yaml to indicate that the binary is required for a test. This had been the actual meaning for quite some time but the key was never renamed.
2019-12-14 00:55:41 +02:00
my $tBasePage = ${storageLocal()->get($self->dataPath() . '/page.bin')};
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
my $iBasePageChecksum = 0x1B99;
# Create base path
$oHostDbMaster->manifestPathCreate(\%oManifest, MANIFEST_TARGET_PGDATA, 'base');
$oHostDbMaster->manifestPathCreate(\%oManifest, MANIFEST_TARGET_PGDATA, 'base/1');
$oHostDbMaster->manifestFileCreate(\%oManifest, MANIFEST_TARGET_PGDATA, 'base/1/12000', $tBasePage,
'22c98d248ff548311eda88559e4a8405ed77c003', $lTime);
$oHostDbMaster->manifestFileCreate(\%oManifest, MANIFEST_TARGET_PGDATA, 'base/1/' . DB_FILE_PGVERSION,
PG_VERSION_94, '184473f470864e067ee3a22e64b47b0a1c356f29', $lTime, '660');
Full/Synthetic test refactor. * Combine hardlink and non/compressed in synthetic tests to reduce test time and improve coverage. * Change log level of hardlink logging to detail. * Cast size in S3 manifest to integer.
2017-06-15 21:32:10 +02:00
if (!$bRemote)
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
{
Update last tests that required sudo. All tests should now run in a sudo-less environment.
2019-10-16 17:05:24 +02:00
$oHostDbMaster->executeSimple(
'chown 7777 ' . $oHostDbMaster->dbBasePath() . '/base/1/' . DB_FILE_PGVERSION, undef, 'root');
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$oManifest{&MANIFEST_SECTION_TARGET_FILE}{MANIFEST_TARGET_PGDATA . '/base/1/' . DB_FILE_PGVERSION}
{&MANIFEST_SUBKEY_USER} = INI_FALSE;
}
my $tPageInvalid17000 = $tBasePage . $tBasePage;
$oHostDbMaster->manifestPathCreate(\%oManifest, MANIFEST_TARGET_PGDATA, 'base/16384');
$oHostDbMaster->manifestFileCreate(
\%oManifest, MANIFEST_TARGET_PGDATA, 'base/16384/17000', $tPageInvalid17000,
'e0101dd8ffb910c9c202ca35b5f828bcb9697bed', $lTime, undef, undef, '1');
$oHostDbMaster->manifestFileCreate(\%oManifest, MANIFEST_TARGET_PGDATA, 'base/16384/' . DB_FILE_PGVERSION,
PG_VERSION_94, '184473f470864e067ee3a22e64b47b0a1c356f29', $lTime);
Full/Synthetic test refactor. * Combine hardlink and non/compressed in synthetic tests to reduce test time and improve coverage. * Change log level of hardlink logging to detail. * Cast size in S3 manifest to integer.
2017-06-15 21:32:10 +02:00
if (!$bRemote)
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
{
Update last tests that required sudo. All tests should now run in a sudo-less environment.
2019-10-16 17:05:24 +02:00
$oHostDbMaster->executeSimple(
'chown :7777 ' . $oHostDbMaster->dbBasePath() . '/base/16384/' . DB_FILE_PGVERSION, undef, 'root');
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$oManifest{&MANIFEST_SECTION_TARGET_FILE}{MANIFEST_TARGET_PGDATA . '/base/16384/' . DB_FILE_PGVERSION}
{&MANIFEST_SUBKEY_GROUP} = INI_FALSE;
}
$oHostDbMaster->manifestPathCreate(\%oManifest, MANIFEST_TARGET_PGDATA, 'base/32768');
my $tPageValid =
Reduced the likelihood of torn pages causing a false positive in page checksums by filtering on start backup LSN.
2017-01-30 20:59:00 +02:00
pageBuild($tBasePage, 0) .
pageBuild($tBasePage, 1) .
pageBuild($tBasePage, 2) .
Fix incorrect offline upper bound for ignoring page checksum errors. For offline backups the upper bound was being set to 0x0000FFFF0000FFFF rather than UINT64_MAX. This meant that page checksum errors might be ignored for databases with a lot of past WAL in offline mode. Online mode is not affected since the upper bound is retrieved from pg_start_backup().
2019-07-11 15:13:56 +02:00
pageBuild($tBasePage, 0, 0xFFFFFFFF, 0xFFFFFFFF);
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
Reduced the likelihood of torn pages causing a false positive in page checksums by filtering on start backup LSN.
2017-01-30 20:59:00 +02:00
$oHostDbMaster->manifestFileCreate(
Fix incorrect offline upper bound for ignoring page checksum errors. For offline backups the upper bound was being set to 0x0000FFFF0000FFFF rather than UINT64_MAX. This meant that page checksum errors might be ignored for databases with a lot of past WAL in offline mode. Online mode is not affected since the upper bound is retrieved from pg_start_backup().
2019-07-11 15:13:56 +02:00
\%oManifest, MANIFEST_TARGET_PGDATA, 'base/32768/33000', $tPageValid, '7a16d165e4775f7c92e8cdf60c0af57313f0bf90',
Reduced the likelihood of torn pages causing a false positive in page checksums by filtering on start backup LSN.
2017-01-30 20:59:00 +02:00
$lTime);
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
Fixed an issue where tables over 1GB would report page checksum errors after the first segment. Reported by Stephen Frost.
2017-03-01 21:15:46 +02:00
my $iBlockOffset = 32767 * 131072;
my $tPageValidSeg32767 =
pageBuild($tBasePage, $iBlockOffset + 0) .
pageBuild($tBasePage, $iBlockOffset + 1) .
Fixed an issue where newly initialized (but unused) pages would cause page checksum warnings. Reported by Stephen Frost.
2017-03-13 21:50:13 +02:00
("\0" x 8192) .
Fix incorrect offline upper bound for ignoring page checksum errors. For offline backups the upper bound was being set to 0x0000FFFF0000FFFF rather than UINT64_MAX. This meant that page checksum errors might be ignored for databases with a lot of past WAL in offline mode. Online mode is not affected since the upper bound is retrieved from pg_start_backup().
2019-07-11 15:13:56 +02:00
pageBuild($tBasePage, 0, 0xFFFFFFFF, 0xFFFFFFFF);
Fixed an issue where tables over 1GB would report page checksum errors after the first segment. Reported by Stephen Frost.
2017-03-01 21:15:46 +02:00
$oHostDbMaster->manifestFileCreate(
\%oManifest, MANIFEST_TARGET_PGDATA, 'base/32768/33000.32767', $tPageValidSeg32767,
Fix incorrect offline upper bound for ignoring page checksum errors. For offline backups the upper bound was being set to 0x0000FFFF0000FFFF rather than UINT64_MAX. This meant that page checksum errors might be ignored for databases with a lot of past WAL in offline mode. Online mode is not affected since the upper bound is retrieved from pg_start_backup().
2019-07-11 15:13:56 +02:00
'6e99b589e550e68e934fd235ccba59fe5b592a9e', $lTime);
Fixed an issue where tables over 1GB would report page checksum errors after the first segment. Reported by Stephen Frost.
2017-03-01 21:15:46 +02:00
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
my $tPageInvalid33001 =
Reduced the likelihood of torn pages causing a false positive in page checksums by filtering on start backup LSN.
2017-01-30 20:59:00 +02:00
pageBuild($tBasePage, 1) .
pageBuild($tBasePage, 1) .
pageBuild($tBasePage, 2) .
pageBuild($tBasePage, 0) .
pageBuild($tBasePage, 0) .
pageBuild($tBasePage, 0) .
pageBuild($tBasePage, 6) .
pageBuild($tBasePage, 0);
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$oHostDbMaster->manifestFileCreate(
\%oManifest, MANIFEST_TARGET_PGDATA, 'base/32768/33001', $tPageInvalid33001,
'6bf316f11d28c28914ea9be92c00de9bea6d9a6b', $lTime, undef, undef, '0, [3, 5], 7');
$oHostDbMaster->manifestFileCreate(\%oManifest, MANIFEST_TARGET_PGDATA, 'base/32768/' . DB_FILE_PGVERSION,
PG_VERSION_94, '184473f470864e067ee3a22e64b47b0a1c356f29', $lTime);
# Create global path
$oHostDbMaster->manifestPathCreate(\%oManifest, MANIFEST_TARGET_PGDATA, 'global');
Support configurable WAL segment size. PostgreSQL 11 introduces configurable WAL segment sizes, from 1MB to 1GB. There are two areas that needed to be updated to support this: building the archive-get queue and checking that WAL has been archived after a backup. Both operations require the WAL segment size to properly build a list. Checking the archive after a backup is still implemented in Perl and has an active database connection, so just get the WAL segment size from the database. The archive-get command does not have a connection to the database, so get the WAL segment size from pg_control instead. This requires a deeper inspection of pg_control than has been done in the past, so it seemed best to copy the relevant data structures from each version of PostgreSQL and build a generic interface layer to address them. While this approach is a bit verbose, it has the advantage of being relatively simple, and can easily be updated for new versions of PostgreSQL. Since the integration tests generate pg_control files for testing, teach Perl how to generate files with the correct offsets for both 32-bit and 64-bit architectures.
2018-09-25 11:24:42 +02:00
$oHostDbMaster->manifestFileCreate(
\%oManifest, MANIFEST_TARGET_PGDATA, DB_FILE_PGCONTROL, '[replaceme]',
$self->archBits() == 32 ? '8107e546c59c72a8c1818fc3610d7cc1e5623660' : '4c77c900f7af0d9ab13fa9982051a42e0b637f6c',
$lTime - 100, undef, true);
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Copy pg_control
Automate generation of WAL and pg_control test files. The existing static files would not work with 32-bit or big-endian systems so create functions to generate these files dynamically rather than creating a bunch of new static files.
2017-11-19 03:02:54 +02:00
$self->controlGenerate($oHostDbMaster->dbBasePath(), PG_VERSION_94);
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
utime($lTime - 100, $lTime - 100, $oHostDbMaster->dbBasePath() . '/' . DB_FILE_PGCONTROL)
or confess &log(ERROR, "unable to set time");
$oManifest{&MANIFEST_SECTION_TARGET_FILE}{MANIFEST_TARGET_PGDATA . '/' . DB_FILE_PGCONTROL}
{&MANIFEST_SUBKEY_SIZE} = 8192;
# Create tablespace path
$oHostDbMaster->manifestPathCreate(\%oManifest, MANIFEST_TARGET_PGDATA, DB_PATH_PGTBLSPC);
# Create paths/files to ignore
Full/Synthetic test refactor. * Combine hardlink and non/compressed in synthetic tests to reduce test time and improve coverage. * Change log level of hardlink logging to detail. * Cast size in S3 manifest to integer.
2017-06-15 21:32:10 +02:00
if (!$bRemote)
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
{
# Create temp dir and file that will be ignored
$oHostDbMaster->dbPathCreate(\%oManifest, MANIFEST_TARGET_PGDATA, 'base/' . DB_FILE_PREFIX_TMP);
$oHostDbMaster->dbFileCreate(
\%oManifest, MANIFEST_TARGET_PGDATA, 'base/' . DB_FILE_PREFIX_TMP . '/' . DB_FILE_PREFIX_TMP . '.1', 'IGNORE');
# Create pg_dynshmem dir and file - only file will be ignored
$oHostDbMaster->manifestPathCreate(\%oManifest, MANIFEST_TARGET_PGDATA, DB_PATH_PGDYNSHMEM);
Additional backup exclusions. * Exclude contents of pg_snapshots, pg_serial, pg_notify, and pg_dynshmem from backup since they are rebuilt on startup. * Exclude pg_internal.init files from backup since they are rebuilt on startup.
2017-09-04 14:26:57 +02:00
$oHostDbMaster->dbFileCreate(\%oManifest, MANIFEST_TARGET_PGDATA, DB_PATH_PGDYNSHMEM . '/anything.tmp', 'IGNORE');
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Create pg_notify dir and file - only file will be ignored
$oHostDbMaster->manifestPathCreate(\%oManifest, MANIFEST_TARGET_PGDATA, DB_PATH_PGNOTIFY);
Additional backup exclusions. * Exclude contents of pg_snapshots, pg_serial, pg_notify, and pg_dynshmem from backup since they are rebuilt on startup. * Exclude pg_internal.init files from backup since they are rebuilt on startup.
2017-09-04 14:26:57 +02:00
$oHostDbMaster->dbFileCreate(\%oManifest, MANIFEST_TARGET_PGDATA, DB_PATH_PGNOTIFY . '/anything.tmp', 'IGNORE');
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Create pg_replslot dir and file - only file will be ignored
$oHostDbMaster->manifestPathCreate(\%oManifest, MANIFEST_TARGET_PGDATA, DB_PATH_PGREPLSLOT);
$oHostDbMaster->dbFileCreate(\%oManifest, MANIFEST_TARGET_PGDATA, DB_PATH_PGREPLSLOT . '/anything.tmp', 'IGNORE');
# Create pg_serial dir and file - only file will be ignored
$oHostDbMaster->manifestPathCreate(\%oManifest, MANIFEST_TARGET_PGDATA, DB_PATH_PGSERIAL);
Additional backup exclusions. * Exclude contents of pg_snapshots, pg_serial, pg_notify, and pg_dynshmem from backup since they are rebuilt on startup. * Exclude pg_internal.init files from backup since they are rebuilt on startup.
2017-09-04 14:26:57 +02:00
$oHostDbMaster->dbFileCreate(\%oManifest, MANIFEST_TARGET_PGDATA, DB_PATH_PGSERIAL . '/anything.tmp', 'IGNORE');
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
Fix comment typos. This includes some variable names in tests which don't seem important enough for their own commits. Contributed by Josh Soref.
2019-08-26 18:05:36 +02:00
# Create pg_snapshots dir and file - only file will be ignored
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$oHostDbMaster->manifestPathCreate(\%oManifest, MANIFEST_TARGET_PGDATA, DB_PATH_PGSNAPSHOTS);
Additional backup exclusions. * Exclude contents of pg_snapshots, pg_serial, pg_notify, and pg_dynshmem from backup since they are rebuilt on startup. * Exclude pg_internal.init files from backup since they are rebuilt on startup.
2017-09-04 14:26:57 +02:00
$oHostDbMaster->dbFileCreate(\%oManifest, MANIFEST_TARGET_PGDATA, DB_PATH_PGSNAPSHOTS . '/anything.tmp', 'IGNORE');
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Create pg_stat_tmp dir and file - only file will be ignored
$oHostDbMaster->manifestPathCreate(\%oManifest, MANIFEST_TARGET_PGDATA, DB_PATH_PGSTATTMP);
$oHostDbMaster->dbFileCreate(\%oManifest, MANIFEST_TARGET_PGDATA, DB_PATH_PGSTATTMP . '/anything.tmp', 'IGNORE');
# Create pg_subtrans dir and file - only file will be ignored
$oHostDbMaster->manifestPathCreate(\%oManifest, MANIFEST_TARGET_PGDATA, DB_PATH_PGSUBTRANS);
$oHostDbMaster->dbFileCreate(\%oManifest, MANIFEST_TARGET_PGDATA, DB_PATH_PGSUBTRANS . '/anything.tmp', 'IGNORE');
# More files to ignore
$oHostDbMaster->dbFileCreate(\%oManifest, MANIFEST_TARGET_PGDATA, DB_FILE_POSTGRESQLAUTOCONFTMP, 'IGNORE');
$oHostDbMaster->dbFileCreate(\%oManifest, MANIFEST_TARGET_PGDATA, DB_FILE_POSTMASTEROPTS, 'IGNORE');
$oHostDbMaster->dbFileCreate(\%oManifest, MANIFEST_TARGET_PGDATA, DB_FILE_RECOVERYCONF, 'IGNORE');
$oHostDbMaster->dbFileCreate(\%oManifest, MANIFEST_TARGET_PGDATA, DB_FILE_RECOVERYDONE, 'IGNORE');
Additional backup exclusions. * Exclude contents of pg_snapshots, pg_serial, pg_notify, and pg_dynshmem from backup since they are rebuilt on startup. * Exclude pg_internal.init files from backup since they are rebuilt on startup.
2017-09-04 14:26:57 +02:00
$oHostDbMaster->dbFileCreate(\%oManifest, MANIFEST_TARGET_PGDATA, 'global/' . DB_FILE_PGINTERNALINIT, 'IGNORE');
Exclude temporary and unlogged relation (table/index) files from backup. Implemented using the same logic as the patches adding this feature to PostgreSQL, 8694cc96 and 920a5e50. Temporary relation exclusion is enabled in PostgreSQL ≥ 9.0. Unlogged relation exclusion is enabled in PostgreSQL ≥ 9.1, where the feature was introduced. Contributed by Cynthia Shang.
2018-07-31 00:53:34 +02:00
# Unlog and temp files to ignore (unlog _init will NOT be ignored)
$oHostDbMaster->manifestFileCreate(\%oManifest, MANIFEST_TARGET_PGDATA, 'base/32768/44000_init', $tPageValid,
Fix incorrect offline upper bound for ignoring page checksum errors. For offline backups the upper bound was being set to 0x0000FFFF0000FFFF rather than UINT64_MAX. This meant that page checksum errors might be ignored for databases with a lot of past WAL in offline mode. Online mode is not affected since the upper bound is retrieved from pg_start_backup().
2019-07-11 15:13:56 +02:00
'7a16d165e4775f7c92e8cdf60c0af57313f0bf90', $lTime);
Exclude temporary and unlogged relation (table/index) files from backup. Implemented using the same logic as the patches adding this feature to PostgreSQL, 8694cc96 and 920a5e50. Temporary relation exclusion is enabled in PostgreSQL ≥ 9.0. Unlogged relation exclusion is enabled in PostgreSQL ≥ 9.1, where the feature was introduced. Contributed by Cynthia Shang.
2018-07-31 00:53:34 +02:00
$oHostDbMaster->dbFileCreate(\%oManifest, MANIFEST_TARGET_PGDATA, 'base/32768/44000', 'IGNORE');
$oHostDbMaster->dbFileCreate(\%oManifest, MANIFEST_TARGET_PGDATA, 'base/32768/t333_44000', 'IGNORE');
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
}
Move help/version integration tests to mock/all. Help and version are covered by unit tests, so we really just to need to make sure there is output when called from the command line.
2018-04-08 18:16:32 +02:00
# Help and Version. These have complete unit tests, so here just make sure there is output from the command line.
#---------------------------------------------------------------------------------------------------------------------------
if ($self->runCurrent() == 1)
{
$oHostDbMaster->executeSimple($self->backrestExe() . " version", {oLogTest => $self->expect()});
$oHostDbMaster->executeSimple($self->backrestExe() . " help version", {oLogTest => $self->expect()});
}
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Full backup
Configuration rules are now pulled from the C library when present.
2017-08-25 22:47:47 +02:00
#---------------------------------------------------------------------------------------------------------------------------
my $strType = CFGOPTVAL_BACKUP_TYPE_FULL;
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
my $strOptionalParam = '--manifest-save-threshold=3';
my $strTestPoint;
# Create the archive info file
Configuration rules are now pulled from the C library when present.
2017-08-25 22:47:47 +02:00
$oHostBackup->stanzaCreate('create required data for stanza', {strOptionalParam => '--no-' . cfgOptionName(CFGOPT_ONLINE)});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
Fix failure in manifest build when two or more files in PGDATA are linked to the same directory. Reported by Vitaliy Kukharik.
2018-05-02 18:19:54 +02:00
# Create a link to postgresql.conf
Storage and IO layer refactor: Refactor storage layer to allow for new repository filesystems using drivers. (Reviewed by Cynthia Shang.) Refactor IO layer to allow for new compression formats, checksum types, and other capabilities using filters. (Reviewed by Cynthia Shang.)
2017-06-09 23:51:41 +02:00
storageTest()->pathCreate($oHostDbMaster->dbPath() . '/pg_config', {strMode => '0700', bCreateParent => true});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
testFileCreate(
$oHostDbMaster->dbPath() . '/pg_config/postgresql.conf', "listen_addresses = *\n", $lTime - 100);
testLinkCreate($oHostDbMaster->dbPath() . '/pg_config/postgresql.conf.link', './postgresql.conf');
$oHostDbMaster->manifestLinkCreate(\%oManifest, MANIFEST_TARGET_PGDATA, 'postgresql.conf',
'../pg_config/postgresql.conf', true);
Fix failure in manifest build when two or more files in PGDATA are linked to the same directory. Reported by Vitaliy Kukharik.
2018-05-02 18:19:54 +02:00
# Create a link to pg_hba.conf
testFileCreate(
$oHostDbMaster->dbPath() . '/pg_config/pg_hba.conf', "CONTENTS\n", $lTime - 100);
testLinkCreate($oHostDbMaster->dbPath() . '/pg_config/pg_hba.conf.link', './pg_hba.conf');
$oHostDbMaster->manifestLinkCreate(\%oManifest, MANIFEST_TARGET_PGDATA, 'pg_hba.conf',
'../pg_config/pg_hba.conf', true);
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Create stat directory link and file
Storage and IO layer refactor: Refactor storage layer to allow for new repository filesystems using drivers. (Reviewed by Cynthia Shang.) Refactor IO layer to allow for new compression formats, checksum types, and other capabilities using filters. (Reviewed by Cynthia Shang.)
2017-06-09 23:51:41 +02:00
storageTest()->pathCreate($oHostDbMaster->dbPath() . '/pg_stat', {strMode => '0700', bCreateParent => true});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$oHostDbMaster->manifestLinkCreate(\%oManifest, MANIFEST_TARGET_PGDATA, 'pg_stat', '../pg_stat');
$oHostDbMaster->manifestFileCreate(\%oManifest, MANIFEST_TARGET_PGDATA . '/pg_stat', 'global.stat', 'stats',
'e350d5ce0153f3e22d5db21cf2a4eff00f3ee877', $lTime - 100, undef, true);
$oHostDbMaster->manifestPathCreate(\%oManifest, MANIFEST_TARGET_PGDATA, 'pg_clog');
Improve support for special characters in filenames. % characters caused issues in backup/restore due to filenames being appended directly into a format string. Reserved XML characters (<>&') caused issues in the S3 driver due to improper escaping. Add a file with all common special characters to regression testing.
2018-09-10 16:54:34 +02:00
# Create file with special characters
$oHostDbMaster->manifestFileCreate(
Use minio for integration testing. ScalityS3 has not received any maintenance in years and is slow to start which is bad for testing. Replace it with minio which starts quickly and ships as a single executable or a tiny container. Minio has stricter limits on allowable characters but should still provide enough coverage to show that our encoding is working correctly. This commit also includes the upgrade to openssl 1.1.1 in the Ubuntu 18.04 container.
2019-07-03 04:20:35 +02:00
\%oManifest, MANIFEST_TARGET_PGDATA, 'special-!_.*\'()&!@;:+,?', undef, undef, $lTime, undef, true);
Improve support for special characters in filenames. % characters caused issues in backup/restore due to filenames being appended directly into a format string. Reserved XML characters (<>&') caused issues in the S3 driver due to improper escaping. Add a file with all common special characters to regression testing.
2018-09-10 16:54:34 +02:00
Add additional options to backup.manifest for debugging purposes. Add the buffer-size, compress-level, compress-level-network, and process-max options to the backup:option section in backup.manifest to aid in debugging. It may also make sense to propagate these options up to backup.info so they can be displayed in the info command, but for now this is deemed sufficient. Contributed by blogh.
2019-03-10 11:03:52 +02:00
$oManifest{&MANIFEST_SECTION_BACKUP_OPTION}{&MANIFEST_KEY_PROCESS_MAX} = 1;
Remove integration tests that are now covered in the unit tests. Most of these tests are just checking that errors are thrown when required. These are well covered in various unit tests. The "cannot resume" tests are also well covered in the backup unit tests. Finally, config warnings are well covered in the config unit tests. There is more to be done here, but this accounts for the low-hanging fruit.
2019-12-18 03:14:45 +02:00
my $strFullBackup = $oHostBackup->backup(
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$strType, 'create pg_stat link, pg_clog dir',
{oExpectedManifest => \%oManifest,
Fixed an issue where some db-* options (e.g. db-port) were not being passed to remotes.
2017-09-19 16:14:18 +02:00
strOptionalParam => $strOptionalParam .
# Pass ssh path to make sure it is used
($bRemote ? ' --' . cfgOptionName(CFGOPT_CMD_SSH) . '=/usr/bin/ssh' : '') .
# Pass bogus ssh port to make sure it is passed through the protocol layer (it won't be used)
Rename db-* options to pg-* and backup-* options to repo-* to improve consistency. * repo-* options are now indexed although only one is allowed. * List deprecated option names in documentation and command-line help.
2018-02-04 01:27:38 +02:00
($bRemote ? ' --' . cfgOptionName(CFGOPT_PG_PORT) . '=9999' : '') .
Fixed an issue where some db-* options (e.g. db-port) were not being passed to remotes.
2017-09-19 16:14:18 +02:00
# Pass bogus socket path to make sure it is passed through the protocol layer (it won't be used)
Fix issues when a path option is / terminated. This condition was not being properly checked for in the C code and it caused problems in the info command, at the very least. Instead of applying a local fix, introduce a new path option type that will rigorously check the format of any incoming paths. Reported by Marc Cousin.
2019-03-14 11:48:33 +02:00
($bRemote ? ' --' . cfgOptionName(CFGOPT_PG_SOCKET_PATH) . '=/test_socket_path' : '') .
Fixed an issue where some db-* options (e.g. db-port) were not being passed to remotes.
2017-09-19 16:14:18 +02:00
' --' . cfgOptionName(CFGOPT_BUFFER_SIZE) . '=16384 --' . cfgOptionName(CFGOPT_CHECKSUM_PAGE) .
' --' . cfgOptionName(CFGOPT_PROCESS_MAX) . '=1',
Configuration rules are now pulled from the C library when present.
2017-08-25 22:47:47 +02:00
strRepoType => $bS3 ? undef : CFGOPTVAL_REPO_TYPE_CIFS, strTest => $strTestPoint, fTestDelay => 0});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
Add additional options to backup.manifest for debugging purposes. Add the buffer-size, compress-level, compress-level-network, and process-max options to the backup:option section in backup.manifest to aid in debugging. It may also make sense to propagate these options up to backup.info so they can be displayed in the info command, but for now this is deemed sufficient. Contributed by blogh.
2019-03-10 11:03:52 +02:00
$oManifest{&MANIFEST_SECTION_BACKUP_OPTION}{&MANIFEST_KEY_PROCESS_MAX} = $bS3 ? 2 : 1;
Integration test improvements for disk and memory efficiency. Set log-level-file=off when more that one test will run. In this case is it impossible to see the logs anyway since they will be automatically cleaned up after the test. This improves performance pretty dramatically since trace-level logging is expensive. If a singe integration test is run then log-level-file is trace by default but can be changed with the --log-level-test-file option. Reduce buffer-size to 64k to save memory during testing and allow more processes to run in parallel. Update log replacement rules so that these options can change without affecting expect logs.
2019-12-17 22:23:07 +02:00
$oManifest{&MANIFEST_SECTION_BACKUP_OPTION}{&MANIFEST_KEY_BUFFER_SIZE} = 65536;
Add additional options to backup.manifest for debugging purposes. Add the buffer-size, compress-level, compress-level-network, and process-max options to the backup:option section in backup.manifest to aid in debugging. It may also make sense to propagate these options up to backup.info so they can be displayed in the info command, but for now this is deemed sufficient. Contributed by blogh.
2019-03-10 11:03:52 +02:00
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Stop operations and make sure the correct error occurs
Configuration rules are now pulled from the C library when present.
2017-08-25 22:47:47 +02:00
#---------------------------------------------------------------------------------------------------------------------------
Full/Synthetic test refactor. * Combine hardlink and non/compressed in synthetic tests to reduce test time and improve coverage. * Change log level of hardlink logging to detail. * Cast size in S3 manifest to integer.
2017-06-15 21:32:10 +02:00
if (!$bS3)
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
{
Remove start/stop --force integration tests in mock/all. These tests require test points which are not being implemented in the C code. This functionality is fully tested in the command/control unit tests so integration tests are no longer required.
2019-11-25 14:45:58 +02:00
# Test global stop
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$oHostDbMaster->stop({bForce => true});
$oHostBackup->backup(
$strType, 'global stop',
{oExpectedManifest => \%oManifest, iExpectedExitStatus => ERROR_STOP});
# Test stanza stop
$oHostDbMaster->stop({strStanza => $oHostDbMaster->stanza()});
# This time a warning should be generated
$oHostDbMaster->stop({strStanza => $oHostDbMaster->stanza()});
$oHostBackup->backup(
$strType, 'stanza stop',
{oExpectedManifest => \%oManifest, iExpectedExitStatus => ERROR_STOP});
$oHostDbMaster->start({strStanza => $self->stanza()});
$oHostDbMaster->start();
# This time a warning should be generated
$oHostDbMaster->start();
}
# Resume Full Backup
Configuration rules are now pulled from the C library when present.
2017-08-25 22:47:47 +02:00
#---------------------------------------------------------------------------------------------------------------------------
$strType = CFGOPTVAL_BACKUP_TYPE_FULL;
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# These files should never be backed up (this requires the next backup to do --force)
testFileCreate($oHostDbMaster->dbBasePath() . '/' . DB_FILE_POSTMASTERPID, 'JUNK');
testFileCreate($oHostDbMaster->dbBasePath() . '/' . DB_FILE_BACKUPLABELOLD, 'JUNK');
testFileCreate($oHostDbMaster->dbBasePath() . '/' . DB_FILE_RECOVERYCONF, 'JUNK');
testFileCreate($oHostDbMaster->dbBasePath() . '/' . DB_FILE_RECOVERYDONE, 'JUNK');
# Create files in root tblspc paths that should not be copied or deleted.
# This will be checked later after a --force restore.
my $strDoNotDeleteFile = $oHostDbMaster->tablespacePath(1, 2) . '/donotdelete.txt';
Storage and IO layer refactor: Refactor storage layer to allow for new repository filesystems using drivers. (Reviewed by Cynthia Shang.) Refactor IO layer to allow for new compression formats, checksum types, and other capabilities using filters. (Reviewed by Cynthia Shang.)
2017-06-09 23:51:41 +02:00
storageTest()->pathCreate(dirname($strDoNotDeleteFile), {strMode => '0700', bCreateParent => true});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
testFileCreate($strDoNotDeleteFile, 'DONOTDELETE-1-2');
Storage and IO layer refactor: Refactor storage layer to allow for new repository filesystems using drivers. (Reviewed by Cynthia Shang.) Refactor IO layer to allow for new compression formats, checksum types, and other capabilities using filters. (Reviewed by Cynthia Shang.)
2017-06-09 23:51:41 +02:00
storageTest()->pathCreate($oHostDbMaster->tablespacePath(1), {strMode => '0700', bCreateParent => true});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
testFileCreate($oHostDbMaster->tablespacePath(1) . '/donotdelete.txt', 'DONOTDELETE-1');
Storage and IO layer refactor: Refactor storage layer to allow for new repository filesystems using drivers. (Reviewed by Cynthia Shang.) Refactor IO layer to allow for new compression formats, checksum types, and other capabilities using filters. (Reviewed by Cynthia Shang.)
2017-06-09 23:51:41 +02:00
storageTest()->pathCreate($oHostDbMaster->tablespacePath(2), {strMode => '0700', bCreateParent => true});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
testFileCreate($oHostDbMaster->tablespacePath(2) . '/donotdelete.txt', 'DONOTDELETE-2');
Storage and IO layer refactor: Refactor storage layer to allow for new repository filesystems using drivers. (Reviewed by Cynthia Shang.) Refactor IO layer to allow for new compression formats, checksum types, and other capabilities using filters. (Reviewed by Cynthia Shang.)
2017-06-09 23:51:41 +02:00
storageTest()->pathCreate($oHostDbMaster->tablespacePath(2, 2), {strMode => '0700', bCreateParent => true});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
testFileCreate($oHostDbMaster->tablespacePath(2, 2) . '/donotdelete.txt', 'DONOTDELETE-2-2');
Storage and IO layer refactor: Refactor storage layer to allow for new repository filesystems using drivers. (Reviewed by Cynthia Shang.) Refactor IO layer to allow for new compression formats, checksum types, and other capabilities using filters. (Reviewed by Cynthia Shang.)
2017-06-09 23:51:41 +02:00
storageTest()->pathCreate($oHostDbMaster->tablespacePath(11), {strMode => '0700', bCreateParent => true});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
Storage and IO layer refactor: Refactor storage layer to allow for new repository filesystems using drivers. (Reviewed by Cynthia Shang.) Refactor IO layer to allow for new compression formats, checksum types, and other capabilities using filters. (Reviewed by Cynthia Shang.)
2017-06-09 23:51:41 +02:00
# Resume by copying the valid full backup over the last aborted full backup if it exists, or by creating a new path
my $strResumeBackup = (storageRepo()->list(
STORAGE_REPO_BACKUP, {strExpression => backupRegExpGet(true, true, true), strSortOrder => 'reverse'}))[0];
Fix backup labels in mock/all resume integration tests. These were not getting updated to match the directory name when the manifests were copied. The Perl code didn't care but the C code expects labels to be set correctly.
2019-12-06 18:48:41 +02:00
my $strResumeLabel = $strResumeBackup ne $strFullBackup ?
$strResumeBackup : backupLabel(storageRepo(), $strType, undef, time());
my $strResumePath = storageRepo()->pathGet('backup/' . $self->stanza() . '/' . $strResumeLabel);
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
Storage and IO layer refactor: Refactor storage layer to allow for new repository filesystems using drivers. (Reviewed by Cynthia Shang.) Refactor IO layer to allow for new compression formats, checksum types, and other capabilities using filters. (Reviewed by Cynthia Shang.)
2017-06-09 23:51:41 +02:00
forceStorageRemove(storageRepo(), $strResumePath, {bRecurse => true});
forceStorageMove(storageRepo(), 'backup/' . $self->stanza() . "/${strFullBackup}", $strResumePath);
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
Fixed an issue with invalid backup groups being set correctly on restore. If the backup cannot map a group to a name it stores the group in the manifest as false then uses either the owner of $PGDATA to set the group during restore or failing that the group of the current user. This logic was not working correctly because the selected group was overwriting the user on restore leaving the group undefined and the user incorrectly set to the group. (Reported by Jeff McCormick.)
2017-11-20 19:46:35 +02:00
# Set ownership on base directory to bogus values
if (!$bRemote)
{
Update last tests that required sudo. All tests should now run in a sudo-less environment.
2019-10-16 17:05:24 +02:00
$oHostDbMaster->executeSimple('chown 7777:7777 ' . $oHostDbMaster->dbBasePath(), undef, 'root');
$oHostDbMaster->executeSimple('chmod 777 ' . $oHostDbMaster->dbBasePath(), undef, 'root');
Fixed an issue with invalid backup groups being set correctly on restore. If the backup cannot map a group to a name it stores the group in the manifest as false then uses either the owner of $PGDATA to set the group during restore or failing that the group of the current user. This logic was not working correctly because the selected group was overwriting the user on restore leaving the group undefined and the user incorrectly set to the group. (Reported by Jeff McCormick.)
2017-11-20 19:46:35 +02:00
$oManifest{&MANIFEST_SECTION_TARGET_PATH}{&MANIFEST_TARGET_PGDATA}{&MANIFEST_SUBKEY_USER} = INI_FALSE;
$oManifest{&MANIFEST_SECTION_TARGET_PATH}{&MANIFEST_TARGET_PGDATA}{&MANIFEST_SUBKEY_GROUP} = INI_FALSE;
$oManifest{&MANIFEST_SECTION_TARGET_PATH}{&MANIFEST_TARGET_PGDATA}{&MANIFEST_SUBKEY_MODE} = '0777';
}
Storage and IO layer refactor: Refactor storage layer to allow for new repository filesystems using drivers. (Reviewed by Cynthia Shang.) Refactor IO layer to allow for new compression formats, checksum types, and other capabilities using filters. (Reviewed by Cynthia Shang.)
2017-06-09 23:51:41 +02:00
$oHostBackup->manifestMunge(
basename($strResumePath),
Fix backup labels in mock/all resume integration tests. These were not getting updated to match the directory name when the manifests were copied. The Perl code didn't care but the C code expects labels to be set correctly.
2019-12-06 18:48:41 +02:00
{&MANIFEST_SECTION_BACKUP => {&MANIFEST_KEY_LABEL => $strResumeLabel},
&MANIFEST_SECTION_TARGET_FILE =>
{(&MANIFEST_TARGET_PGDATA . '/' . &DB_FILE_PGVERSION) => {&MANIFEST_SUBKEY_CHECKSUM => undef}}},
Improvements to Ini.pm. * Refactor Ini.pm to facilitate testing. * Complete statement/branch coverage for Ini.pm. * Improved functions used to test/munge manifest and info files.
2017-04-10 19:24:45 +02:00
false);
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
Storage and IO layer refactor: Refactor storage layer to allow for new repository filesystems using drivers. (Reviewed by Cynthia Shang.) Refactor IO layer to allow for new compression formats, checksum types, and other capabilities using filters. (Reviewed by Cynthia Shang.)
2017-06-09 23:51:41 +02:00
# Remove the main manifest so the backup appears aborted
forceStorageRemove(storageRepo(), "${strResumePath}/" . FILE_MANIFEST);
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Create a temp file in backup temp root to be sure it's deleted correctly
Full/Synthetic test refactor. * Combine hardlink and non/compressed in synthetic tests to reduce test time and improve coverage. * Change log level of hardlink logging to detail. * Cast size in S3 manifest to integer.
2017-06-15 21:32:10 +02:00
my $strTempFile = "${strResumePath}/file.tmp";
S3 repository support.
2017-06-12 16:52:32 +02:00
if ($bS3)
{
Remove dependency on aws cli for testing. This tool was only being used it a few places but was a pretty large dependency. Rework the forceStorageMove() code using our storage layer and replace one aws cli cp with a storage put. Also, remove the Dockerfile that was once used to build the Scality S3 test container.
2019-10-09 20:38:24 +02:00
storageRepo()->put($strTempFile, "TEMP");
S3 repository support.
2017-06-12 16:52:32 +02:00
}
else
{
Remove pgbackrest test user. This user was created before we tested in containers to ensure isolation between the pg and repo hosts which were then just directories. The downside is that this resulted in a lot of sudos to set the pgbackrest user and to remove files which did not belong to the main test user. Containers provide isolation without needing separate users so we can now safely remove the pgbackrest user. This allows us to remove most sudos, except where they are explicitly needed in tests. While we're at it, remove the code that installed the Perl C library (which also required sudo) and simply add the build path to @INC instead.
2019-10-12 15:45:18 +02:00
executeTest("touch ${strTempFile}", {bRemote => $bRemote});
S3 repository support.
2017-06-12 16:52:32 +02:00
}
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
Allow zero-size files in backup manifest to reference a prior manifest regardless of timestamp delta. Contributed by Cynthia Shang.
2018-08-24 22:50:33 +02:00
# Add zero-sized file
$oHostDbMaster->manifestFileCreate(\%oManifest, MANIFEST_TARGET_PGDATA, 'zero_from_start', undef,
undef, $lTime, undef, true);
Add checksum delta for incremental backups. Use checksums rather than timestamps to determine if files have changed. This is useful in cases where the timestamps may not be trustworthy, e.g. when performing an incremental after failing over to a standby. If checksum delta is enabled then checksums will be used for verification of resumed backups, even if they are full. Resumes have always used checksums to verify the files in the repository, enabling delta performs checksums on the database files as well. Note that the user must manually enable this feature in cases were it would be useful or just keep in enabled all the time. A future commit will address automatically enabling the feature in cases where it seems likely to be useful. Contributed by Cynthia Shang.
2018-09-19 17:12:45 +02:00
# Add files for testing backups when time changes but content doesn't, and when content changes but time and size don't
$oHostDbMaster->manifestFileCreate(
\%oManifest, MANIFEST_TARGET_PGDATA, 'changetime.txt', 'SIZE', '88087292ed82e26f3eb824d0bffc05ccf7a30f8d', $lTime,
undef, true);
$oHostDbMaster->manifestFileCreate(
\%oManifest, MANIFEST_TARGET_PGDATA, 'changecontent.txt', 'CONTENT', '238a131a3e8eb98d1fc5b27d882ca40b7618fd2a', $lTime,
undef, true);
Reduce the scope of mock/all exclusion tests. Run exclusions only on the tests where they will have an effect to reduce churn in the expect logs when they change.
2019-12-02 00:47:47 +02:00
# Create files to be excluded with the --exclude option
$oHostBackup->configUpdate(
{(CFGDEF_SECTION_GLOBAL . ':backup') =>
{cfgOptionName(CFGOPT_EXCLUDE) => ['postgresql.auto.conf', 'pg_log/', 'pg_log2', 'apipe']}});
$oHostDbMaster->dbLinkCreate(\%oManifest, MANIFEST_TARGET_PGDATA, 'postgresql.auto.conf',
'../pg_config/postgresql.conf', true);
$oHostDbMaster->manifestPathCreate(\%oManifest, MANIFEST_TARGET_PGDATA, 'pg_log');
$oHostDbMaster->dbFileCreate(\%oManifest, MANIFEST_TARGET_PGDATA, 'pg_log/logfile', 'IGNORE');
$oHostDbMaster->dbPathCreate(\%oManifest, MANIFEST_TARGET_PGDATA, 'pg_log2');
$oHostDbMaster->dbFileCreate(\%oManifest, MANIFEST_TARGET_PGDATA, 'pg_log2/logfile', 'IGNORE');
executeTest('mkfifo ' . $oHostDbMaster->dbBasePath() . '/apipe');
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$strFullBackup = $oHostBackup->backup(
$strType, 'resume',
Remove obsolete integration tests from mock/all. The protocol timeout tests have been superceded by unit tests. The TEST_BACKUP_RESUME test point was incorrectly included into a number of tests, probably a copy pasto. It didn't hurt anything but it did add 200ms to each test where it appeared. Catalog and control version tests were redundant. The database version and system id tests covered the important code paths and the C code gets these values from a lookup table. Finally, fix an incomplete update to the backup.info file while munging for tests.
2019-11-21 23:06:27 +02:00
{oExpectedManifest => \%oManifest,
Add checksum delta for incremental backups. Use checksums rather than timestamps to determine if files have changed. This is useful in cases where the timestamps may not be trustworthy, e.g. when performing an incremental after failing over to a standby. If checksum delta is enabled then checksums will be used for verification of resumed backups, even if they are full. Resumes have always used checksums to verify the files in the repository, enabling delta performs checksums on the database files as well. Note that the user must manually enable this feature in cases were it would be useful or just keep in enabled all the time. A future commit will address automatically enabling the feature in cases where it seems likely to be useful. Contributed by Cynthia Shang.
2018-09-19 17:12:45 +02:00
strOptionalParam => '--force --' . cfgOptionName(CFGOPT_CHECKSUM_PAGE) . ($bDeltaBackup ? ' --delta' : '')});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
Storage and IO layer refactor: Refactor storage layer to allow for new repository filesystems using drivers. (Reviewed by Cynthia Shang.) Refactor IO layer to allow for new compression formats, checksum types, and other capabilities using filters. (Reviewed by Cynthia Shang.)
2017-06-09 23:51:41 +02:00
# Remove postmaster.pid so restore will succeed (the rest will be cleaned up by the delta)
storageDb->remove($oHostDbMaster->dbBasePath() . '/' . DB_FILE_POSTMASTERPID);
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Restore - tests various mode, extra files/paths, missing files/paths
Configuration rules are now pulled from the C library when present.
2017-08-25 22:47:47 +02:00
#---------------------------------------------------------------------------------------------------------------------------
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Munge permissions/modes on files that will be fixed by the restore
Full/Synthetic test refactor. * Combine hardlink and non/compressed in synthetic tests to reduce test time and improve coverage. * Change log level of hardlink logging to detail. * Cast size in S3 manifest to integer.
2017-06-15 21:32:10 +02:00
if (!$bRemote)
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
{
Update last tests that required sudo. All tests should now run in a sudo-less environment.
2019-10-16 17:05:24 +02:00
$oHostDbMaster->executeSimple(
"chown :7777 " . $oHostDbMaster->dbBasePath() . '/base/1/' . DB_FILE_PGVERSION, undef, 'root');
$oHostDbMaster->executeSimple(
"chmod 600 " . $oHostDbMaster->dbBasePath() . '/base/1/' . DB_FILE_PGVERSION, undef, 'root');
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
}
# Create a path and file that are not in the manifest
$oHostDbMaster->dbPathCreate(\%oManifest, MANIFEST_TARGET_PGDATA, 'deleteme');
$oHostDbMaster->dbFileCreate(\%oManifest, MANIFEST_TARGET_PGDATA, 'deleteme/deleteme.txt', 'DELETEME');
# Change path mode
$oHostDbMaster->dbPathMode(\%oManifest, MANIFEST_TARGET_PGDATA, 'base', '0777');
# Remove a path
$oHostDbMaster->dbPathRemove(\%oManifest, MANIFEST_TARGET_PGDATA, 'pg_clog');
# Remove a file
$oHostDbMaster->dbFileRemove(\%oManifest, MANIFEST_TARGET_PGDATA, 'base/16384/17000');
Fixed an issue with invalid backup groups being set correctly on restore. If the backup cannot map a group to a name it stores the group in the manifest as false then uses either the owner of $PGDATA to set the group during restore or failing that the group of the current user. This logic was not working correctly because the selected group was overwriting the user on restore leaving the group undefined and the user incorrectly set to the group. (Reported by Jeff McCormick.)
2017-11-20 19:46:35 +02:00
# Restore will set invalid user and group to root since the base path user/group are also invalid
Full/Synthetic test refactor. * Combine hardlink and non/compressed in synthetic tests to reduce test time and improve coverage. * Change log level of hardlink logging to detail. * Cast size in S3 manifest to integer.
2017-06-15 21:32:10 +02:00
if (!$bRemote)
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
{
The restore command is implemented entirely in C. For the most part this is a direct migration of the Perl code into C. There is one important behavioral change with regard to how file permissions are handled. The Perl code tried to set ownership as it was in the manifest even when running as an unprivileged user. This usually just led to errors and frustration. The C code works like this: If a restore is run as a non-root user (the typical scenario) then all files restored will belong to the user/group executing pgBackRest. If existing files are not owned by the executing user/group then an error will result if the ownership cannot be updated to the executing user/group. In that case the file ownership will need to be updated by a privileged user before the restore can be retried. If a restore is run as the root user then pgBackRest will attempt to recreate the ownership recorded in the manifest when the backup was made. Only user/group names are stored in the manifest so the same names must exist on the restore host for this to work. If the user/group name cannot be found locally then the user/group of the PostgreSQL data directory will be used and finally root if the data directory user/group cannot be mapped to a name. Reviewed by Cynthia Shang.
2019-09-26 13:52:02 +02:00
$oManifest{&MANIFEST_SECTION_TARGET_PATH}{&MANIFEST_TARGET_PGDATA}{&MANIFEST_SUBKEY_USER} = 'root';
$oManifest{&MANIFEST_SECTION_TARGET_PATH}{&MANIFEST_TARGET_PGDATA}{&MANIFEST_SUBKEY_GROUP} = 'root';
Fixed an issue with invalid backup groups being set correctly on restore. If the backup cannot map a group to a name it stores the group in the manifest as false then uses either the owner of $PGDATA to set the group during restore or failing that the group of the current user. This logic was not working correctly because the selected group was overwriting the user on restore leaving the group undefined and the user incorrectly set to the group. (Reported by Jeff McCormick.)
2017-11-20 19:46:35 +02:00
$oManifest{&MANIFEST_SECTION_TARGET_FILE}{MANIFEST_TARGET_PGDATA . '/base/1/' . DB_FILE_PGVERSION}
{&MANIFEST_SUBKEY_USER} = 'root';
$oManifest{&MANIFEST_SECTION_TARGET_FILE}{MANIFEST_TARGET_PGDATA . '/base/16384/' . DB_FILE_PGVERSION}
{&MANIFEST_SUBKEY_GROUP} = 'root';
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
}
$oHostDbMaster->restore(
Move restore test infrastructure to HostBackup.pm. Required to test restores on the backup server, a fairly common scenario. Improve the restore function to accept optional parameters rather than a long list of parameters. In passing, clean up extraneous use of strType and strComment variables.
2017-12-04 00:08:49 +02:00
'add and delete files', $strFullBackup,
{rhExpectedManifest => \%oManifest, bDelta => true, strUser => !$bRemote ? 'root' : undef,
strOptionalParam => ' --link-all' . ($bRemote ? ' --cmd-ssh=/usr/bin/ssh' : '')});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
Reduce the scope of mock/all exclusion tests. Run exclusions only on the tests where they will have an effect to reduce churn in the expect logs when they change.
2019-12-02 00:47:47 +02:00
# Remove excludes now that they just create noise in the log
$oHostBackup->configUpdate({(CFGDEF_SECTION_GLOBAL . ':backup') => {cfgOptionName(CFGOPT_EXCLUDE) => []}});
Fixed an issue with invalid backup groups being set correctly on restore. If the backup cannot map a group to a name it stores the group in the manifest as false then uses either the owner of $PGDATA to set the group during restore or failing that the group of the current user. This logic was not working correctly because the selected group was overwriting the user on restore leaving the group undefined and the user incorrectly set to the group. (Reported by Jeff McCormick.)
2017-11-20 19:46:35 +02:00
# Run again to fix permissions
Full/Synthetic test refactor. * Combine hardlink and non/compressed in synthetic tests to reduce test time and improve coverage. * Change log level of hardlink logging to detail. * Cast size in S3 manifest to integer.
2017-06-15 21:32:10 +02:00
if (!$bRemote)
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
{
Fixed an issue with invalid backup groups being set correctly on restore. If the backup cannot map a group to a name it stores the group in the manifest as false then uses either the owner of $PGDATA to set the group during restore or failing that the group of the current user. This logic was not working correctly because the selected group was overwriting the user on restore leaving the group undefined and the user incorrectly set to the group. (Reported by Jeff McCormick.)
2017-11-20 19:46:35 +02:00
# Reset the base path user and group for the next restore so files will be reset to the base path user/group
Update last tests that required sudo. All tests should now run in a sudo-less environment.
2019-10-16 17:05:24 +02:00
$oHostDbMaster->executeSimple(
'chown ' . TEST_USER . ':' . TEST_GROUP . ' ' . $oHostDbMaster->dbBasePath(), undef, 'root');
Fixed an issue with invalid backup groups being set correctly on restore. If the backup cannot map a group to a name it stores the group in the manifest as false then uses either the owner of $PGDATA to set the group during restore or failing that the group of the current user. This logic was not working correctly because the selected group was overwriting the user on restore leaving the group undefined and the user incorrectly set to the group. (Reported by Jeff McCormick.)
2017-11-20 19:46:35 +02:00
$oHostBackup->manifestMunge(
$strFullBackup,
{&MANIFEST_SECTION_TARGET_PATH =>
{&MANIFEST_TARGET_PGDATA =>
Fix test writing "null" into manifest files. "null" is not allowed in the manifest format (null values should be missing instead) but Perl was treating the invalid values written by this test as if they were missing. Update the test code to remove the values rather than setting them to "null".
2019-08-18 21:29:18 +02:00
{&MANIFEST_SUBKEY_USER => undef, &MANIFEST_SUBKEY_GROUP => undef}}},
Fixed an issue with invalid backup groups being set correctly on restore. If the backup cannot map a group to a name it stores the group in the manifest as false then uses either the owner of $PGDATA to set the group during restore or failing that the group of the current user. This logic was not working correctly because the selected group was overwriting the user on restore leaving the group undefined and the user incorrectly set to the group. (Reported by Jeff McCormick.)
2017-11-20 19:46:35 +02:00
false);
delete($oManifest{&MANIFEST_SECTION_TARGET_PATH}{&MANIFEST_TARGET_PGDATA}{&MANIFEST_SUBKEY_USER});
delete($oManifest{&MANIFEST_SECTION_TARGET_PATH}{&MANIFEST_TARGET_PGDATA}{&MANIFEST_SUBKEY_GROUP});
delete(
$oManifest{&MANIFEST_SECTION_TARGET_FILE}{MANIFEST_TARGET_PGDATA . '/base/1/' . DB_FILE_PGVERSION}
{&MANIFEST_SUBKEY_USER});
delete(
$oManifest{&MANIFEST_SECTION_TARGET_FILE}{MANIFEST_TARGET_PGDATA . '/base/16384/' . DB_FILE_PGVERSION}
{&MANIFEST_SUBKEY_GROUP});
$oHostDbMaster->restore(
Move restore test infrastructure to HostBackup.pm. Required to test restores on the backup server, a fairly common scenario. Improve the restore function to accept optional parameters rather than a long list of parameters. In passing, clean up extraneous use of strType and strComment variables.
2017-12-04 00:08:49 +02:00
'fix permissions', $strFullBackup,
{rhExpectedManifest => \%oManifest, bDelta => true, strUser => 'root',
strOptionalParam => ' --link-all --log-level-console=detail'});
Fixed an issue with invalid backup groups being set correctly on restore. If the backup cannot map a group to a name it stores the group in the manifest as false then uses either the owner of $PGDATA to set the group during restore or failing that the group of the current user. This logic was not working correctly because the selected group was overwriting the user on restore leaving the group undefined and the user incorrectly set to the group. (Reported by Jeff McCormick.)
2017-11-20 19:46:35 +02:00
# Fix and remove files that are now owned by root
Update last tests that required sudo. All tests should now run in a sudo-less environment.
2019-10-16 17:05:24 +02:00
$oHostBackup->executeSimple('chown -R ' . TEST_USER . ':' . TEST_GROUP . ' ' . $oHostBackup->logPath(), undef, 'root');
$oHostDbMaster->executeSimple('rm -rf ' . $oHostDbMaster->lockPath() . '/*', undef, 'root');
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
}
# Change an existing link to the wrong directory
$oHostDbMaster->dbFileRemove(\%oManifest, MANIFEST_TARGET_PGDATA, 'pg_stat');
$oHostDbMaster->dbLinkCreate(\%oManifest, MANIFEST_TARGET_PGDATA, 'pg_stat', '../wrong');
$oHostDbMaster->restore(
Move restore test infrastructure to HostBackup.pm. Required to test restores on the backup server, a fairly common scenario. Improve the restore function to accept optional parameters rather than a long list of parameters. In passing, clean up extraneous use of strType and strComment variables.
2017-12-04 00:08:49 +02:00
'fix broken symlink', $strFullBackup,
{rhExpectedManifest => \%oManifest, bDelta => true,
Reduce log level for all expect tests to detail. The C code is designed to be efficient rather than deterministic at the debug log level. As we move more testing from integration to unit tests it makes less sense to try and maintain the expect logs at this log level. Most of the expect logs have already been moved to detail level but mock/all still had tests at debug level. Change the logging defaults in the config file and remove as many references to log-level-console as possible.
2019-05-23 00:23:44 +02:00
strOptionalParam => ' --link-all' . ($bRemote ? ' --compress-level-network=0' : '')});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
Remove integration tests that are now covered in the unit tests. Most of these tests are just checking that errors are thrown when required. These are well covered in various unit tests. The "cannot resume" tests are also well covered in the backup unit tests. Finally, config warnings are well covered in the config unit tests. There is more to be done here, but this accounts for the low-hanging fruit.
2019-12-18 03:14:45 +02:00
# Restore links as directories
Configuration rules are now pulled from the C library when present.
2017-08-25 22:47:47 +02:00
#---------------------------------------------------------------------------------------------------------------------------
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Munge the user to make sure it gets reset on the next run
$oHostBackup->manifestMunge(
Improvements to Ini.pm. * Refactor Ini.pm to facilitate testing. * Complete statement/branch coverage for Ini.pm. * Improved functions used to test/munge manifest and info files.
2017-04-10 19:24:45 +02:00
$strFullBackup,
{&MANIFEST_SECTION_TARGET_FILE =>
{&MANIFEST_FILE_PGCONTROL => {&MANIFEST_SUBKEY_USER => 'bogus', &MANIFEST_SUBKEY_GROUP => 'bogus'}}},
false);
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Restore succeeds
$oHostDbMaster->manifestLinkMap(\%oManifest, MANIFEST_TARGET_PGDATA . '/pg_stat');
$oHostDbMaster->manifestLinkMap(\%oManifest, MANIFEST_TARGET_PGDATA . '/postgresql.conf');
Fix failure in manifest build when two or more files in PGDATA are linked to the same directory. Reported by Vitaliy Kukharik.
2018-05-02 18:19:54 +02:00
$oHostDbMaster->manifestLinkMap(\%oManifest, MANIFEST_TARGET_PGDATA . '/pg_hba.conf');
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$oHostDbMaster->restore(
Remove integration tests that are now covered in the unit tests. Most of these tests are just checking that errors are thrown when required. These are well covered in various unit tests. The "cannot resume" tests are also well covered in the backup unit tests. Finally, config warnings are well covered in the config unit tests. There is more to be done here, but this accounts for the low-hanging fruit.
2019-12-18 03:14:45 +02:00
'restore links as directories', $strFullBackup,
Reduce log level for all expect tests to detail. The C code is designed to be efficient rather than deterministic at the debug log level. As we move more testing from integration to unit tests it makes less sense to try and maintain the expect logs at this log level. Most of the expect logs have already been moved to detail level but mock/all still had tests at debug level. Change the logging defaults in the config file and remove as many references to log-level-console as possible.
2019-05-23 00:23:44 +02:00
{rhExpectedManifest => \%oManifest, bDelta => true, bForce => true});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
Fix failure in manifest build when two or more files in PGDATA are linked to the same directory. Reported by Vitaliy Kukharik.
2018-05-02 18:19:54 +02:00
# No longer need pg_hba.conf since it is no longer a link and doesn't provide additional coverage
$oHostDbMaster->manifestFileRemove(\%oManifest, MANIFEST_TARGET_PGDATA, 'pg_hba.conf');
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Incr backup
Configuration rules are now pulled from the C library when present.
2017-08-25 22:47:47 +02:00
#---------------------------------------------------------------------------------------------------------------------------
$strType = CFGOPTVAL_BACKUP_TYPE_INCR;
Remove integration tests that are now covered in the unit tests. Most of these tests are just checking that errors are thrown when required. These are well covered in various unit tests. The "cannot resume" tests are also well covered in the backup unit tests. Finally, config warnings are well covered in the config unit tests. There is more to be done here, but this accounts for the low-hanging fruit.
2019-12-18 03:14:45 +02:00
$oHostDbMaster->manifestReference(\%oManifest, $strFullBackup);
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Add tablespace 1
$oHostDbMaster->manifestTablespaceCreate(\%oManifest, 1);
$oHostDbMaster->manifestPathCreate(\%oManifest, MANIFEST_TARGET_PGTBLSPC . '/1', '16384');
$oHostDbMaster->manifestFileCreate(
Fix critical bug in resume that resulted in inconsistent backups. A regression in v0.82 removed the timestamp comparison when deciding which files from the aborted backup to keep on resume. All resumed backups should be considered inconsistent. A resumed backup can be identified by checking the log for the message "aborted backup of same type exists, will be cleaned to remove invalid files and resumed". Reported by David Youatt, Yogesh Sharma, Stephen Frost.
2018-07-03 20:01:57 +02:00
\%oManifest, MANIFEST_TARGET_PGTBLSPC . '/1', '16384/tablespace1.txt', 'TBLSPCB',
'14c44cef6287269b08d41de489fd492bb9fc795d', $lTime - 100, undef, undef, false);
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$oHostDbMaster->manifestFileCreate(\%oManifest, MANIFEST_TARGET_PGDATA, 'badchecksum.txt', 'BADCHECKSUM',
'f927212cd08d11a42a666b2f04235398e9ceeb51', $lTime, undef, true);
Fix critical bug in resume that resulted in inconsistent backups. A regression in v0.82 removed the timestamp comparison when deciding which files from the aborted backup to keep on resume. All resumed backups should be considered inconsistent. A resumed backup can be identified by checking the log for the message "aborted backup of same type exists, will be cleaned to remove invalid files and resumed". Reported by David Youatt, Yogesh Sharma, Stephen Frost.
2018-07-03 20:01:57 +02:00
$oHostDbMaster->manifestFileCreate(
\%oManifest, MANIFEST_TARGET_PGDATA, 'changesize.txt', 'SIZE', '88087292ed82e26f3eb824d0bffc05ccf7a30f8d', $lTime,
undef, true);
Add zero-length file to mock/all test.
2018-07-05 21:40:50 +02:00
$oHostDbMaster->manifestFileCreate(
\%oManifest, MANIFEST_TARGET_PGDATA, 'zerosize.txt', '', undef, $lTime - 100, undef, true);
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Create temp dir and file that will be ignored
Full/Synthetic test refactor. * Combine hardlink and non/compressed in synthetic tests to reduce test time and improve coverage. * Change log level of hardlink logging to detail. * Cast size in S3 manifest to integer.
2017-06-15 21:32:10 +02:00
if (!$bRemote)
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
{
$oHostDbMaster->dbPathCreate(\%oManifest, MANIFEST_TARGET_PGTBLSPC . '/1', DB_FILE_PREFIX_TMP);
$oHostDbMaster->dbFileCreate(
\%oManifest, MANIFEST_TARGET_PGTBLSPC . '/1', DB_FILE_PREFIX_TMP . '/' . DB_FILE_PREFIX_TMP . '.1', 'IGNORE');
}
Remove test point infrastructure. 82df7e6f and 9856fef5 updated tests that used test points in preparation for the feature not being available in the C code. Since tests points are no longer used remove the infrastructure. Also remove one stray --test option in mock/all that was essentially a noop but no longer works now that the option has been removed.
2019-12-10 20:16:47 +02:00
my $strBackup = $oHostBackup->backup($strType, 'add tablespace 1', {oExpectedManifest => \%oManifest});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Resume Incr Backup
Configuration rules are now pulled from the C library when present.
2017-08-25 22:47:47 +02:00
#---------------------------------------------------------------------------------------------------------------------------
$strType = CFGOPTVAL_BACKUP_TYPE_INCR;
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
Storage and IO layer refactor: Refactor storage layer to allow for new repository filesystems using drivers. (Reviewed by Cynthia Shang.) Refactor IO layer to allow for new compression formats, checksum types, and other capabilities using filters. (Reviewed by Cynthia Shang.)
2017-06-09 23:51:41 +02:00
# Create resumable backup from last backup
Fix backup labels in mock/all resume integration tests. These were not getting updated to match the directory name when the manifests were copied. The Perl code didn't care but the C code expects labels to be set correctly.
2019-12-06 18:48:41 +02:00
$strResumeLabel = backupLabel(storageRepo(), $strType, substr($strBackup, 0, 16), time());
$strResumePath = storageRepo()->pathGet('backup/' . $self->stanza() . '/' . $strResumeLabel);
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
Storage and IO layer refactor: Refactor storage layer to allow for new repository filesystems using drivers. (Reviewed by Cynthia Shang.) Refactor IO layer to allow for new compression formats, checksum types, and other capabilities using filters. (Reviewed by Cynthia Shang.)
2017-06-09 23:51:41 +02:00
forceStorageRemove(storageRepo(), $strResumePath);
forceStorageMove(storageRepo(), 'backup/' . $self->stanza() . "/${strBackup}", $strResumePath);
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
Fix critical bug in resume that resulted in inconsistent backups. A regression in v0.82 removed the timestamp comparison when deciding which files from the aborted backup to keep on resume. All resumed backups should be considered inconsistent. A resumed backup can be identified by checking the log for the message "aborted backup of same type exists, will be cleaned to remove invalid files and resumed". Reported by David Youatt, Yogesh Sharma, Stephen Frost.
2018-07-03 20:01:57 +02:00
# Munge manifest so the resumed file in the repo appears to be bad
Create test matrix for mock/all to increase coverage and reduce tests. The same test configurations are run on all four test VMs, which seems a real waste of resources. Vary the tests per VM to increase coverage while reducing the total number of tests. Be sure to include each major feature (remote, s3, encryption) in each VM at least once.
2019-03-02 15:01:02 +02:00
if ($bEncrypt || $bRemote)
Fix critical bug in resume that resulted in inconsistent backups. A regression in v0.82 removed the timestamp comparison when deciding which files from the aborted backup to keep on resume. All resumed backups should be considered inconsistent. A resumed backup can be identified by checking the log for the message "aborted backup of same type exists, will be cleaned to remove invalid files and resumed". Reported by David Youatt, Yogesh Sharma, Stephen Frost.
2018-07-03 20:01:57 +02:00
{
$oHostBackup->manifestMunge(
basename($strResumePath),
{&MANIFEST_SECTION_TARGET_FILE =>
{(&MANIFEST_TARGET_PGDATA . '/badchecksum.txt') => {&MANIFEST_SUBKEY_CHECKSUM => BOGUS}}},
false);
}
# Change contents of resumed file without changing size so it will throw a nasty error about the repo having been corrupted
else
{
storageRepo()->put("${strResumePath}/pg_data/badchecksum.txt", 'BDDCHECKSUM');
}
Fix backup labels in mock/all resume integration tests. These were not getting updated to match the directory name when the manifests were copied. The Perl code didn't care but the C code expects labels to be set correctly.
2019-12-06 18:48:41 +02:00
# Write correct label into resumable manifest
$oHostBackup->manifestMunge(
basename($strResumePath), {&MANIFEST_SECTION_BACKUP => {&MANIFEST_KEY_LABEL => $strResumeLabel}},false);
Fix critical bug in resume that resulted in inconsistent backups. A regression in v0.82 removed the timestamp comparison when deciding which files from the aborted backup to keep on resume. All resumed backups should be considered inconsistent. A resumed backup can be identified by checking the log for the message "aborted backup of same type exists, will be cleaned to remove invalid files and resumed". Reported by David Youatt, Yogesh Sharma, Stephen Frost.
2018-07-03 20:01:57 +02:00
# Change contents/size of a db file to make sure it recopies (and does not resume)
$oHostDbMaster->manifestFileCreate(
\%oManifest, MANIFEST_TARGET_PGDATA, 'changesize.txt', 'SIZE+MORE', '3905d5be2ec8d67f41435dab5e0dcda3ae47455d', $lTime,
undef, true);
# Change contents/time of a db file to make sure it recopies (and does not resume)
$oHostDbMaster->manifestFileCreate(
\%oManifest, MANIFEST_TARGET_PGTBLSPC . '/1', '16384/tablespace1.txt', 'TBLSPC1',
'd85de07d6421d90aa9191c11c889bfde43680f0f', $lTime, undef, undef, false);
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
Storage and IO layer refactor: Refactor storage layer to allow for new repository filesystems using drivers. (Reviewed by Cynthia Shang.) Refactor IO layer to allow for new compression formats, checksum types, and other capabilities using filters. (Reviewed by Cynthia Shang.)
2017-06-09 23:51:41 +02:00
# Remove the main manifest so the backup appears aborted
forceStorageRemove(storageRepo(), "${strResumePath}/" . FILE_MANIFEST);
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Add tablespace 2
$oHostDbMaster->manifestTablespaceCreate(\%oManifest, 2);
$oHostDbMaster->manifestPathCreate(\%oManifest, MANIFEST_TARGET_PGTBLSPC . '/2', '32768');
$oHostDbMaster->manifestFileCreate(
\%oManifest, MANIFEST_TARGET_PGTBLSPC . '/2', '32768/tablespace2.txt', 'TBLSPC2',
'dc7f76e43c46101b47acc55ae4d593a9e6983578', $lTime, undef, undef, false);
Additional backup exclusions. * Exclude contents of pg_snapshots, pg_serial, pg_notify, and pg_dynshmem from backup since they are rebuilt on startup. * Exclude pg_internal.init files from backup since they are rebuilt on startup.
2017-09-04 14:26:57 +02:00
# Make sure pg_internal.init is ignored in tablespaces
$oHostDbMaster->dbFileCreate(\%oManifest, MANIFEST_TARGET_PGTBLSPC . '/2', '32768/' . DB_FILE_PGINTERNALINIT, 'IGNORE');
Fixed an issue where databases created with a non-default tablespace would raise bogus warnings about pg_filenode.map and pg_internal.init not being page aligned. Reported by blogh.
2017-03-02 20:50:29 +02:00
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Also create tablespace 11 to be sure it does not conflict with path of tablespace 1
Full/Synthetic test refactor. * Combine hardlink and non/compressed in synthetic tests to reduce test time and improve coverage. * Change log level of hardlink logging to detail. * Cast size in S3 manifest to integer.
2017-06-15 21:32:10 +02:00
$oHostDbMaster->manifestTablespaceCreate(\%oManifest, 11);
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
Automatically enable backup checksum delta when anomalies (e.g. timeline switch) are detected. There are a number of cases where a checksum delta is more appropriate than the default time-based delta: * Timeline has switched since the prior backup * File timestamp is older than recorded in the prior backup * File size changed but timestamp did not * File timestamp is in the future compared to the start of the backup * Online option has changed since the prior backup A practical example is that checksum delta will be enabled after a failover to standby due to the timeline switch. In this case, timestamps can't be trusted and our recommendation has been to run a full backup, which can impact the retention schedule and requires manual intervention. Now, a checksum delta will be performed if the backup type is incr/diff. This means more CPU will be used during the backup but the backup size will be smaller and the retention schedule will not be impacted. Contributed by Cynthia Shang.
2018-11-01 17:31:25 +02:00
# Change only the time to be in the past on a valid file and update the timestamp in the expected manifest
Add checksum delta for incremental backups. Use checksums rather than timestamps to determine if files have changed. This is useful in cases where the timestamps may not be trustworthy, e.g. when performing an incremental after failing over to a standby. If checksum delta is enabled then checksums will be used for verification of resumed backups, even if they are full. Resumes have always used checksums to verify the files in the repository, enabling delta performs checksums on the database files as well. Note that the user must manually enable this feature in cases were it would be useful or just keep in enabled all the time. A future commit will address automatically enabling the feature in cases where it seems likely to be useful. Contributed by Cynthia Shang.
2018-09-19 17:12:45 +02:00
utime($lTime - 100, $lTime - 100, $oHostDbMaster->dbBasePath() . '/changetime.txt')
or confess &log(ERROR, "unable to set time for file ".$oHostDbMaster->dbBasePath() . '/changetime.txt');
$oManifest{&MANIFEST_SECTION_TARGET_FILE}{'pg_data/changetime.txt'}{&MANIFEST_SUBKEY_TIMESTAMP} = $lTime - 100;
Automatically enable backup checksum delta when anomalies (e.g. timeline switch) are detected. There are a number of cases where a checksum delta is more appropriate than the default time-based delta: * Timeline has switched since the prior backup * File timestamp is older than recorded in the prior backup * File size changed but timestamp did not * File timestamp is in the future compared to the start of the backup * Online option has changed since the prior backup A practical example is that checksum delta will be enabled after a failover to standby due to the timeline switch. In this case, timestamps can't be trusted and our recommendation has been to run a full backup, which can impact the retention schedule and requires manual intervention. Now, a checksum delta will be performed if the backup type is incr/diff. This means more CPU will be used during the backup but the backup size will be smaller and the retention schedule will not be impacted. Contributed by Cynthia Shang.
2018-11-01 17:31:25 +02:00
# Change the content of the changecontent file to be the same size but leave the timestamp the same on the file
Add checksum delta for incremental backups. Use checksums rather than timestamps to determine if files have changed. This is useful in cases where the timestamps may not be trustworthy, e.g. when performing an incremental after failing over to a standby. If checksum delta is enabled then checksums will be used for verification of resumed backups, even if they are full. Resumes have always used checksums to verify the files in the repository, enabling delta performs checksums on the database files as well. Note that the user must manually enable this feature in cases were it would be useful or just keep in enabled all the time. A future commit will address automatically enabling the feature in cases where it seems likely to be useful. Contributed by Cynthia Shang.
2018-09-19 17:12:45 +02:00
storageDb()->put($oHostDbMaster->dbBasePath() . '/changecontent.txt', 'CHGCONT');
utime($lTime, $lTime, $oHostDbMaster->dbBasePath() . '/changecontent.txt')
or confess &log(ERROR, "unable to set time for file ".$oHostDbMaster->dbBasePath() . '/changecontent.txt');
Automatically enable backup checksum delta when anomalies (e.g. timeline switch) are detected. There are a number of cases where a checksum delta is more appropriate than the default time-based delta: * Timeline has switched since the prior backup * File timestamp is older than recorded in the prior backup * File size changed but timestamp did not * File timestamp is in the future compared to the start of the backup * Online option has changed since the prior backup A practical example is that checksum delta will be enabled after a failover to standby due to the timeline switch. In this case, timestamps can't be trusted and our recommendation has been to run a full backup, which can impact the retention schedule and requires manual intervention. Now, a checksum delta will be performed if the backup type is incr/diff. This means more CPU will be used during the backup but the backup size will be smaller and the retention schedule will not be impacted. Contributed by Cynthia Shang.
2018-11-01 17:31:25 +02:00
# The changecontent & changetime files have conditions that will force the delta option to be turned on which should result
# in the reference of changecontent to be removed but the reference to changetime to stay since the checksum wouldn't change
$oManifest{&MANIFEST_SECTION_TARGET_FILE}{'pg_data/changecontent.txt'}{&MANIFEST_SUBKEY_CHECKSUM} =
"a094d94583e209556d03c3c5da33131a065f1689";
delete($oManifest{&MANIFEST_SECTION_TARGET_FILE}{'pg_data/changecontent.txt'}{&MANIFEST_SUBKEY_REFERENCE});
$oManifest{&MANIFEST_SECTION_TARGET_FILE}{'pg_data/changetime.txt'}{&MANIFEST_SUBKEY_TIMESTAMP} = $lTime - 100;
Add checksum delta for incremental backups. Use checksums rather than timestamps to determine if files have changed. This is useful in cases where the timestamps may not be trustworthy, e.g. when performing an incremental after failing over to a standby. If checksum delta is enabled then checksums will be used for verification of resumed backups, even if they are full. Resumes have always used checksums to verify the files in the repository, enabling delta performs checksums on the database files as well. Note that the user must manually enable this feature in cases were it would be useful or just keep in enabled all the time. A future commit will address automatically enabling the feature in cases where it seems likely to be useful. Contributed by Cynthia Shang.
2018-09-19 17:12:45 +02:00
Add additional options to backup.manifest for debugging purposes. Add the buffer-size, compress-level, compress-level-network, and process-max options to the backup:option section in backup.manifest to aid in debugging. It may also make sense to propagate these options up to backup.info so they can be displayed in the info command, but for now this is deemed sufficient. Contributed by blogh.
2019-03-10 11:03:52 +02:00
$oManifest{&MANIFEST_SECTION_BACKUP_OPTION}{&MANIFEST_KEY_PROCESS_MAX} = 1;
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$strBackup = $oHostBackup->backup(
Reduce process redundancy in mock tests.
2017-06-22 00:47:25 +02:00
$strType, 'resume and add tablespace 2',
Remove obsolete integration tests from mock/all. The protocol timeout tests have been superceded by unit tests. The TEST_BACKUP_RESUME test point was incorrectly included into a number of tests, probably a copy pasto. It didn't hurt anything but it did add 200ms to each test where it appeared. Catalog and control version tests were redundant. The database version and system id tests covered the important code paths and the C code gets these values from a lookup table. Finally, fix an incomplete update to the backup.info file while munging for tests.
2019-11-21 23:06:27 +02:00
{oExpectedManifest => \%oManifest,
Add checksum delta for incremental backups. Use checksums rather than timestamps to determine if files have changed. This is useful in cases where the timestamps may not be trustworthy, e.g. when performing an incremental after failing over to a standby. If checksum delta is enabled then checksums will be used for verification of resumed backups, even if they are full. Resumes have always used checksums to verify the files in the repository, enabling delta performs checksums on the database files as well. Note that the user must manually enable this feature in cases were it would be useful or just keep in enabled all the time. A future commit will address automatically enabling the feature in cases where it seems likely to be useful. Contributed by Cynthia Shang.
2018-09-19 17:12:45 +02:00
strOptionalParam => '--' . cfgOptionName(CFGOPT_PROCESS_MAX) . '=1' . ($bDeltaBackup ? ' --delta' : '')});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
Add additional options to backup.manifest for debugging purposes. Add the buffer-size, compress-level, compress-level-network, and process-max options to the backup:option section in backup.manifest to aid in debugging. It may also make sense to propagate these options up to backup.info so they can be displayed in the info command, but for now this is deemed sufficient. Contributed by blogh.
2019-03-10 11:03:52 +02:00
$oManifest{&MANIFEST_SECTION_BACKUP_OPTION}{&MANIFEST_KEY_PROCESS_MAX} = $bS3 ? 2 : 1;
Add checksum delta for incremental backups. Use checksums rather than timestamps to determine if files have changed. This is useful in cases where the timestamps may not be trustworthy, e.g. when performing an incremental after failing over to a standby. If checksum delta is enabled then checksums will be used for verification of resumed backups, even if they are full. Resumes have always used checksums to verify the files in the repository, enabling delta performs checksums on the database files as well. Note that the user must manually enable this feature in cases were it would be useful or just keep in enabled all the time. A future commit will address automatically enabling the feature in cases where it seems likely to be useful. Contributed by Cynthia Shang.
2018-09-19 17:12:45 +02:00
if (!$bRemote)
{
# Remove the size-changed test file to avoid expect log churn
$oHostDbMaster->manifestFileRemove(\%oManifest, MANIFEST_TARGET_PGDATA, 'changesize.txt');
}
Fix critical bug in resume that resulted in inconsistent backups. A regression in v0.82 removed the timestamp comparison when deciding which files from the aborted backup to keep on resume. All resumed backups should be considered inconsistent. A resumed backup can be identified by checking the log for the message "aborted backup of same type exists, will be cleaned to remove invalid files and resumed". Reported by David Youatt, Yogesh Sharma, Stephen Frost.
2018-07-03 20:01:57 +02:00
Remove integration tests that are now covered in the unit tests. Most of these tests are just checking that errors are thrown when required. These are well covered in various unit tests. The "cannot resume" tests are also well covered in the backup unit tests. Finally, config warnings are well covered in the config unit tests. There is more to be done here, but this accounts for the low-hanging fruit.
2019-12-18 03:14:45 +02:00
# Drop tablespace 11
Configuration rules are now pulled from the C library when present.
2017-08-25 22:47:47 +02:00
#---------------------------------------------------------------------------------------------------------------------------
$strType = CFGOPTVAL_BACKUP_TYPE_DIFF;
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Drop tablespace 11
Full/Synthetic test refactor. * Combine hardlink and non/compressed in synthetic tests to reduce test time and improve coverage. * Change log level of hardlink logging to detail. * Cast size in S3 manifest to integer.
2017-06-15 21:32:10 +02:00
$oHostDbMaster->manifestTablespaceDrop(\%oManifest, 11);
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
Add additional options to backup.manifest for debugging purposes. Add the buffer-size, compress-level, compress-level-network, and process-max options to the backup:option section in backup.manifest to aid in debugging. It may also make sense to propagate these options up to backup.info so they can be displayed in the info command, but for now this is deemed sufficient. Contributed by blogh.
2019-03-10 11:03:52 +02:00
$oManifest{&MANIFEST_SECTION_BACKUP_OPTION}{&MANIFEST_KEY_PROCESS_MAX} = 1;
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$strBackup = $oHostBackup->backup(
Remove integration tests that are now covered in the unit tests. Most of these tests are just checking that errors are thrown when required. These are well covered in various unit tests. The "cannot resume" tests are also well covered in the backup unit tests. Finally, config warnings are well covered in the config unit tests. There is more to be done here, but this accounts for the low-hanging fruit.
2019-12-18 03:14:45 +02:00
$strType, 'drop tablespace 11',
Remove obsolete integration tests from mock/all. The protocol timeout tests have been superceded by unit tests. The TEST_BACKUP_RESUME test point was incorrectly included into a number of tests, probably a copy pasto. It didn't hurt anything but it did add 200ms to each test where it appeared. Catalog and control version tests were redundant. The database version and system id tests covered the important code paths and the C code gets these values from a lookup table. Finally, fix an incomplete update to the backup.info file while munging for tests.
2019-11-21 23:06:27 +02:00
{oExpectedManifest => \%oManifest,
Reduce log level for all expect tests to detail. The C code is designed to be efficient rather than deterministic at the debug log level. As we move more testing from integration to unit tests it makes less sense to try and maintain the expect logs at this log level. Most of the expect logs have already been moved to detail level but mock/all still had tests at debug level. Change the logging defaults in the config file and remove as many references to log-level-console as possible.
2019-05-23 00:23:44 +02:00
strOptionalParam => '--' . cfgOptionName(CFGOPT_PROCESS_MAX) . '=1' .
Add checksum delta for incremental backups. Use checksums rather than timestamps to determine if files have changed. This is useful in cases where the timestamps may not be trustworthy, e.g. when performing an incremental after failing over to a standby. If checksum delta is enabled then checksums will be used for verification of resumed backups, even if they are full. Resumes have always used checksums to verify the files in the repository, enabling delta performs checksums on the database files as well. Note that the user must manually enable this feature in cases were it would be useful or just keep in enabled all the time. A future commit will address automatically enabling the feature in cases where it seems likely to be useful. Contributed by Cynthia Shang.
2018-09-19 17:12:45 +02:00
($bDeltaBackup ? ' --delta' : '')});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
Add additional options to backup.manifest for debugging purposes. Add the buffer-size, compress-level, compress-level-network, and process-max options to the backup:option section in backup.manifest to aid in debugging. It may also make sense to propagate these options up to backup.info so they can be displayed in the info command, but for now this is deemed sufficient. Contributed by blogh.
2019-03-10 11:03:52 +02:00
$oManifest{&MANIFEST_SECTION_BACKUP_OPTION}{&MANIFEST_KEY_PROCESS_MAX} = $bS3 ? 2 : 1;
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Restore
Configuration rules are now pulled from the C library when present.
2017-08-25 22:47:47 +02:00
#---------------------------------------------------------------------------------------------------------------------------
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Remap the base and tablespace paths
my %oRemapHash;
$oRemapHash{&MANIFEST_TARGET_PGDATA} = $oHostDbMaster->dbBasePath(2);
Storage and IO layer refactor: Refactor storage layer to allow for new repository filesystems using drivers. (Reviewed by Cynthia Shang.) Refactor IO layer to allow for new compression formats, checksum types, and other capabilities using filters. (Reviewed by Cynthia Shang.)
2017-06-09 23:51:41 +02:00
storageTest()->pathCreate($oHostDbMaster->dbBasePath(2), {strMode => '0700', bCreateParent => true});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$oRemapHash{&MANIFEST_TARGET_PGTBLSPC . '/1'} = $oHostDbMaster->tablespacePath(1, 2);
$oRemapHash{&MANIFEST_TARGET_PGTBLSPC . '/2'} = $oHostDbMaster->tablespacePath(2, 2);
The restore command is implemented entirely in C. For the most part this is a direct migration of the Perl code into C. There is one important behavioral change with regard to how file permissions are handled. The Perl code tried to set ownership as it was in the manifest even when running as an unprivileged user. This usually just led to errors and frustration. The C code works like this: If a restore is run as a non-root user (the typical scenario) then all files restored will belong to the user/group executing pgBackRest. If existing files are not owned by the executing user/group then an error will result if the ownership cannot be updated to the executing user/group. In that case the file ownership will need to be updated by a privileged user before the restore can be retried. If a restore is run as the root user then pgBackRest will attempt to recreate the ownership recorded in the manifest when the backup was made. Only user/group names are stored in the manifest so the same names must exist on the restore host for this to work. If the user/group name cannot be found locally then the user/group of the PostgreSQL data directory will be used and finally root if the data directory user/group cannot be mapped to a name. Reviewed by Cynthia Shang.
2019-09-26 13:52:02 +02:00
# At this point the $PG_DATA permissions have been reset to 0700
Fixed an issue with invalid backup groups being set correctly on restore. If the backup cannot map a group to a name it stores the group in the manifest as false then uses either the owner of $PGDATA to set the group during restore or failing that the group of the current user. This logic was not working correctly because the selected group was overwriting the user on restore leaving the group undefined and the user incorrectly set to the group. (Reported by Jeff McCormick.)
2017-11-20 19:46:35 +02:00
if (!$bRemote)
{
The restore command is implemented entirely in C. For the most part this is a direct migration of the Perl code into C. There is one important behavioral change with regard to how file permissions are handled. The Perl code tried to set ownership as it was in the manifest even when running as an unprivileged user. This usually just led to errors and frustration. The C code works like this: If a restore is run as a non-root user (the typical scenario) then all files restored will belong to the user/group executing pgBackRest. If existing files are not owned by the executing user/group then an error will result if the ownership cannot be updated to the executing user/group. In that case the file ownership will need to be updated by a privileged user before the restore can be retried. If a restore is run as the root user then pgBackRest will attempt to recreate the ownership recorded in the manifest when the backup was made. Only user/group names are stored in the manifest so the same names must exist on the restore host for this to work. If the user/group name cannot be found locally then the user/group of the PostgreSQL data directory will be used and finally root if the data directory user/group cannot be mapped to a name. Reviewed by Cynthia Shang.
2019-09-26 13:52:02 +02:00
$oManifest{&MANIFEST_SECTION_TARGET_PATH}{&MANIFEST_TARGET_PGDATA}{&MANIFEST_SUBKEY_MODE} = '0777';
$oManifest{&MANIFEST_SECTION_TARGET_PATH}{&MANIFEST_TARGET_PGTBLSPC}{&MANIFEST_SUBKEY_MODE} = '0777';
Fixed an issue with invalid backup groups being set correctly on restore. If the backup cannot map a group to a name it stores the group in the manifest as false then uses either the owner of $PGDATA to set the group during restore or failing that the group of the current user. This logic was not working correctly because the selected group was overwriting the user on restore leaving the group undefined and the user incorrectly set to the group. (Reported by Jeff McCormick.)
2017-11-20 19:46:35 +02:00
}
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$oHostDbMaster->restore(
Reduce log level for all expect tests to detail. The C code is designed to be efficient rather than deterministic at the debug log level. As we move more testing from integration to unit tests it makes less sense to try and maintain the expect logs at this log level. Most of the expect logs have already been moved to detail level but mock/all still had tests at debug level. Change the logging defaults in the config file and remove as many references to log-level-console as possible.
2019-05-23 00:23:44 +02:00
'remap all paths', $strBackup, {rhExpectedManifest => \%oManifest, rhRemapHash => \%oRemapHash});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Restore (make sure file in root tablespace path is not deleted by --delta)
Configuration rules are now pulled from the C library when present.
2017-08-25 22:47:47 +02:00
#---------------------------------------------------------------------------------------------------------------------------
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$oHostDbMaster->restore(
Move restore test infrastructure to HostBackup.pm. Required to test restores on the backup server, a fairly common scenario. Improve the restore function to accept optional parameters rather than a long list of parameters. In passing, clean up extraneous use of strType and strComment variables.
2017-12-04 00:08:49 +02:00
'ensure file in tblspc root remains after --delta', $strBackup,
Reduce log level for all expect tests to detail. The C code is designed to be efficient rather than deterministic at the debug log level. As we move more testing from integration to unit tests it makes less sense to try and maintain the expect logs at this log level. Most of the expect logs have already been moved to detail level but mock/all still had tests at debug level. Change the logging defaults in the config file and remove as many references to log-level-console as possible.
2019-05-23 00:23:44 +02:00
{rhExpectedManifest => \%oManifest, rhRemapHash => \%oRemapHash, bDelta => true});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
if (!-e $strDoNotDeleteFile)
{
confess "${strDoNotDeleteFile} was deleted by --delta";
}
# Incr Backup
Configuration rules are now pulled from the C library when present.
2017-08-25 22:47:47 +02:00
#---------------------------------------------------------------------------------------------------------------------------
$strType = CFGOPTVAL_BACKUP_TYPE_INCR;
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$oHostDbMaster->manifestReference(\%oManifest, $strBackup);
$oHostDbMaster->manifestFileCreate(
Update Perl page checksum expression. This expression determines which files contain page checksums but it was also including the directory above the relation directories. In a real PostgreSQL installation this not a problem because these directories don't contain any files. However, our tests place a file in `base` which the Perl code thought should have page checksums while the new C code says no. Update the expression to document the change and avoid churn in the expect logs later.
2019-11-25 14:37:09 +02:00
\%oManifest, MANIFEST_TARGET_PGDATA, 'base/base2.txt', 'BASE2', '09b5e31766be1dba1ec27de82f975c1b6eea2a92', $lTime);
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$oHostDbMaster->manifestTablespaceDrop(\%oManifest, 1, 2);
$oHostDbMaster->manifestFileCreate(
\%oManifest, MANIFEST_TARGET_PGTBLSPC . '/2', '32768/tablespace2b.txt', 'TBLSPC2B',
'e324463005236d83e6e54795dbddd20a74533bf3', $lTime, undef, undef, false);
# Munge the version to make sure it gets corrected on the next run
Improvements to Ini.pm. * Refactor Ini.pm to facilitate testing. * Complete statement/branch coverage for Ini.pm. * Improved functions used to test/munge manifest and info files.
2017-04-10 19:24:45 +02:00
$oHostBackup->manifestMunge($strBackup, {&INI_SECTION_BACKREST => {&INI_KEY_VERSION => '0.00'}}, false);
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
Add additional options to backup.manifest for debugging purposes. Add the buffer-size, compress-level, compress-level-network, and process-max options to the backup:option section in backup.manifest to aid in debugging. It may also make sense to propagate these options up to backup.info so they can be displayed in the info command, but for now this is deemed sufficient. Contributed by blogh.
2019-03-10 11:03:52 +02:00
$oManifest{&MANIFEST_SECTION_BACKUP_OPTION}{&MANIFEST_KEY_PROCESS_MAX} = 1;
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$strBackup = $oHostBackup->backup(
$strType, 'add files and remove tablespace 2',
Reduce log level for all expect tests to detail. The C code is designed to be efficient rather than deterministic at the debug log level. As we move more testing from integration to unit tests it makes less sense to try and maintain the expect logs at this log level. Most of the expect logs have already been moved to detail level but mock/all still had tests at debug level. Change the logging defaults in the config file and remove as many references to log-level-console as possible.
2019-05-23 00:23:44 +02:00
{oExpectedManifest => \%oManifest, strOptionalParam => '--' . cfgOptionName(CFGOPT_PROCESS_MAX) . '=1'});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
Add additional options to backup.manifest for debugging purposes. Add the buffer-size, compress-level, compress-level-network, and process-max options to the backup:option section in backup.manifest to aid in debugging. It may also make sense to propagate these options up to backup.info so they can be displayed in the info command, but for now this is deemed sufficient. Contributed by blogh.
2019-03-10 11:03:52 +02:00
$oManifest{&MANIFEST_SECTION_BACKUP_OPTION}{&MANIFEST_KEY_PROCESS_MAX} = $bS3 ? 2 : 1;
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Incr Backup
Configuration rules are now pulled from the C library when present.
2017-08-25 22:47:47 +02:00
#---------------------------------------------------------------------------------------------------------------------------
$strType = CFGOPTVAL_BACKUP_TYPE_INCR;
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$oHostDbMaster->manifestReference(\%oManifest, $strBackup);
$oHostDbMaster->manifestFileCreate(
\%oManifest, MANIFEST_TARGET_PGDATA, 'base/16384/17000', 'BASEUPDT', '9a53d532e27785e681766c98516a5e93f096a501',
$lTime, undef, undef, false);
# Perform the backup
Reduce log level for all expect tests to detail. The C code is designed to be efficient rather than deterministic at the debug log level. As we move more testing from integration to unit tests it makes less sense to try and maintain the expect logs at this log level. Most of the expect logs have already been moved to detail level but mock/all still had tests at debug level. Change the logging defaults in the config file and remove as many references to log-level-console as possible.
2019-05-23 00:23:44 +02:00
$strBackup =$oHostBackup->backup($strType, 'update files', {oExpectedManifest => \%oManifest});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Diff Backup
Configuration rules are now pulled from the C library when present.
2017-08-25 22:47:47 +02:00
#---------------------------------------------------------------------------------------------------------------------------
$strType = CFGOPTVAL_BACKUP_TYPE_DIFF;
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$oHostDbMaster->manifestReference(\%oManifest, $strFullBackup, true);
Add additional options to backup.manifest for debugging purposes. Add the buffer-size, compress-level, compress-level-network, and process-max options to the backup:option section in backup.manifest to aid in debugging. It may also make sense to propagate these options up to backup.info so they can be displayed in the info command, but for now this is deemed sufficient. Contributed by blogh.
2019-03-10 11:03:52 +02:00
$oManifest{&MANIFEST_SECTION_BACKUP_OPTION}{&MANIFEST_KEY_PROCESS_MAX} = 1;
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$strBackup = $oHostBackup->backup(
Reduce process redundancy in mock tests.
2017-06-22 00:47:25 +02:00
$strType, 'updates since last full', {oExpectedManifest => \%oManifest,
Reduce log level for all expect tests to detail. The C code is designed to be efficient rather than deterministic at the debug log level. As we move more testing from integration to unit tests it makes less sense to try and maintain the expect logs at this log level. Most of the expect logs have already been moved to detail level but mock/all still had tests at debug level. Change the logging defaults in the config file and remove as many references to log-level-console as possible.
2019-05-23 00:23:44 +02:00
strOptionalParam => '--' . cfgOptionName(CFGOPT_PROCESS_MAX) . '=1' . ($bDeltaBackup ? ' --delta' : '')});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
Add additional options to backup.manifest for debugging purposes. Add the buffer-size, compress-level, compress-level-network, and process-max options to the backup:option section in backup.manifest to aid in debugging. It may also make sense to propagate these options up to backup.info so they can be displayed in the info command, but for now this is deemed sufficient. Contributed by blogh.
2019-03-10 11:03:52 +02:00
$oManifest{&MANIFEST_SECTION_BACKUP_OPTION}{&MANIFEST_KEY_PROCESS_MAX} = $bS3 ? 2 : 1;
Remove integration tests that are now covered in the unit tests. Most of these tests are just checking that errors are thrown when required. These are well covered in various unit tests. The "cannot resume" tests are also well covered in the backup unit tests. Finally, config warnings are well covered in the config unit tests. There is more to be done here, but this accounts for the low-hanging fruit.
2019-12-18 03:14:45 +02:00
# Diff Backup with files removed
Configuration rules are now pulled from the C library when present.
2017-08-25 22:47:47 +02:00
#---------------------------------------------------------------------------------------------------------------------------
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$oHostDbMaster->manifestReference(\%oManifest, $strFullBackup, true);
Configuration rules are now pulled from the C library when present.
2017-08-25 22:47:47 +02:00
$strType = CFGOPTVAL_BACKUP_TYPE_DIFF;
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
Remove integration tests that are now covered in the unit tests. Most of these tests are just checking that errors are thrown when required. These are well covered in various unit tests. The "cannot resume" tests are also well covered in the backup unit tests. Finally, config warnings are well covered in the config unit tests. There is more to be done here, but this accounts for the low-hanging fruit.
2019-12-18 03:14:45 +02:00
# Enable compression to ensure a warning is raised
$oHostBackup->configUpdate({&CFGDEF_SECTION_GLOBAL => {cfgOptionName(CFGOPT_COMPRESS) => 'y'}});
Full/Synthetic test refactor. * Combine hardlink and non/compressed in synthetic tests to reduce test time and improve coverage. * Change log level of hardlink logging to detail. * Cast size in S3 manifest to integer.
2017-06-15 21:32:10 +02:00
# Enable hardlinks (except for s3) to ensure a warning is raised
if (!$bS3)
{
Rename db-* options to pg-* and backup-* options to repo-* to improve consistency. * repo-* options are now indexed although only one is allowed. * List deprecated option names in documentation and command-line help.
2018-02-04 01:27:38 +02:00
$oHostBackup->configUpdate({&CFGDEF_SECTION_GLOBAL => {cfgOptionName(CFGOPT_REPO_HARDLINK) => 'y'}});
Full/Synthetic test refactor. * Combine hardlink and non/compressed in synthetic tests to reduce test time and improve coverage. * Change log level of hardlink logging to detail. * Cast size in S3 manifest to integer.
2017-06-15 21:32:10 +02:00
}
Add additional options to backup.manifest for debugging purposes. Add the buffer-size, compress-level, compress-level-network, and process-max options to the backup:option section in backup.manifest to aid in debugging. It may also make sense to propagate these options up to backup.info so they can be displayed in the info command, but for now this is deemed sufficient. Contributed by blogh.
2019-03-10 11:03:52 +02:00
$oManifest{&MANIFEST_SECTION_BACKUP_OPTION}{&MANIFEST_KEY_PROCESS_MAX} = 1;
Update integration tests in mock/all that use test points. Test points will not be available in the C code so update these tests as best as possible without using them. This represents a loss of coverage for the Perl code (soon to be removed) which will be made up in the C code with unit tests.
2019-11-25 14:48:52 +02:00
$oHostDbMaster->manifestFileRemove(\%oManifest, MANIFEST_TARGET_PGTBLSPC . '/2', '32768/tablespace2b.txt', true);
$oHostDbMaster->manifestFileRemove(\%oManifest, MANIFEST_TARGET_PGDATA, 'base/base2.txt', true);
Remove integration tests that are now covered in the unit tests. Most of these tests are just checking that errors are thrown when required. These are well covered in various unit tests. The "cannot resume" tests are also well covered in the backup unit tests. Finally, config warnings are well covered in the config unit tests. There is more to be done here, but this accounts for the low-hanging fruit.
2019-12-18 03:14:45 +02:00
$oHostDbMaster->manifestFileRemove(\%oManifest, MANIFEST_TARGET_PGDATA, 'base/16384/17000');
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$oHostDbMaster->manifestFileCreate(
\%oManifest, MANIFEST_TARGET_PGTBLSPC . '/2', '32768/tablespace2c.txt', 'TBLSPCBIGGER',
'dfcb8679956b734706cf87259d50c88f83e80e66', $lTime, undef, undef, false);
Remove integration tests that are now covered in the unit tests. Most of these tests are just checking that errors are thrown when required. These are well covered in various unit tests. The "cannot resume" tests are also well covered in the backup unit tests. Finally, config warnings are well covered in the config unit tests. There is more to be done here, but this accounts for the low-hanging fruit.
2019-12-18 03:14:45 +02:00
$oHostBackup->backup(
$strType, 'remove files',
Update integration tests in mock/all that use test points. Test points will not be available in the C code so update these tests as best as possible without using them. This represents a loss of coverage for the Perl code (soon to be removed) which will be made up in the C code with unit tests.
2019-11-25 14:48:52 +02:00
{oExpectedManifest => \%oManifest,
strOptionalParam => '--' . cfgOptionName(CFGOPT_PROCESS_MAX) . '=1' . ($bDeltaBackup ? ' --delta' : '')});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
Add additional options to backup.manifest for debugging purposes. Add the buffer-size, compress-level, compress-level-network, and process-max options to the backup:option section in backup.manifest to aid in debugging. It may also make sense to propagate these options up to backup.info so they can be displayed in the info command, but for now this is deemed sufficient. Contributed by blogh.
2019-03-10 11:03:52 +02:00
$oManifest{&MANIFEST_SECTION_BACKUP_OPTION}{&MANIFEST_KEY_PROCESS_MAX} = $bS3 ? 2 : 1;
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Full Backup
Configuration rules are now pulled from the C library when present.
2017-08-25 22:47:47 +02:00
#---------------------------------------------------------------------------------------------------------------------------
$strType = CFGOPTVAL_BACKUP_TYPE_FULL;
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
Full/Synthetic test refactor. * Combine hardlink and non/compressed in synthetic tests to reduce test time and improve coverage. * Change log level of hardlink logging to detail. * Cast size in S3 manifest to integer.
2017-06-15 21:32:10 +02:00
# Now the compression and hardlink changes will take effect
$oManifest{&MANIFEST_SECTION_BACKUP_OPTION}{&MANIFEST_KEY_COMPRESS} = JSON::PP::true;
if (!$bS3)
{
$oManifest{&MANIFEST_SECTION_BACKUP_OPTION}{&MANIFEST_KEY_HARDLINK} = JSON::PP::true;
$oHostBackup->{bHardLink} = true;
}
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$oHostDbMaster->manifestReference(\%oManifest);
$oHostDbMaster->manifestFileCreate(
\%oManifest, MANIFEST_TARGET_PGDATA, 'base/16384/17000', 'BASEUPDT2', '7579ada0808d7f98087a0a586d0df9de009cdc33',
$lTime, undef, undef, false);
$oManifest{&MANIFEST_SECTION_BACKUP_OPTION}{&MANIFEST_KEY_CHECKSUM_PAGE} = JSON::PP::false;
$strFullBackup = $oHostBackup->backup(
Reduce log level for all expect tests to detail. The C code is designed to be efficient rather than deterministic at the debug log level. As we move more testing from integration to unit tests it makes less sense to try and maintain the expect logs at this log level. Most of the expect logs have already been moved to detail level but mock/all still had tests at debug level. Change the logging defaults in the config file and remove as many references to log-level-console as possible.
2019-05-23 00:23:44 +02:00
$strType, 'update file', {oExpectedManifest => \%oManifest});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Call expire
Configuration rules are now pulled from the C library when present.
2017-08-25 22:47:47 +02:00
#---------------------------------------------------------------------------------------------------------------------------
Full/Synthetic test refactor. * Combine hardlink and non/compressed in synthetic tests to reduce test time and improve coverage. * Change log level of hardlink logging to detail. * Cast size in S3 manifest to integer.
2017-06-15 21:32:10 +02:00
$oHostBackup->expire({iRetentionFull => 1});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Diff Backup
Configuration rules are now pulled from the C library when present.
2017-08-25 22:47:47 +02:00
#---------------------------------------------------------------------------------------------------------------------------
$strType = CFGOPTVAL_BACKUP_TYPE_DIFF;
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$oHostDbMaster->manifestReference(\%oManifest, $strFullBackup);
$oHostDbMaster->manifestFileCreate(
\%oManifest, MANIFEST_TARGET_PGDATA, 'base/base2.txt', 'BASE2UPDT', 'cafac3c59553f2cfde41ce2e62e7662295f108c0',
$lTime, undef, undef, false);
# Munge the prior manifest so that option-checksum-page is missing to be sure the logic works for backups before page
# checksums were introduced
Improvements to Ini.pm. * Refactor Ini.pm to facilitate testing. * Complete statement/branch coverage for Ini.pm. * Improved functions used to test/munge manifest and info files.
2017-04-10 19:24:45 +02:00
$oHostBackup->manifestMunge(
$strFullBackup, {&MANIFEST_SECTION_BACKUP_OPTION => {&MANIFEST_KEY_CHECKSUM_PAGE => undef}}, false);
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$strBackup = $oHostBackup->backup(
Reduce log level for all expect tests to detail. The C code is designed to be efficient rather than deterministic at the debug log level. As we move more testing from integration to unit tests it makes less sense to try and maintain the expect logs at this log level. Most of the expect logs have already been moved to detail level but mock/all still had tests at debug level. Change the logging defaults in the config file and remove as many references to log-level-console as possible.
2019-05-23 00:23:44 +02:00
$strType, 'add file',
{oExpectedManifest => \%oManifest, strOptionalParam => '--' . cfgOptionName(CFGOPT_CHECKSUM_PAGE)});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Selective Restore
Configuration rules are now pulled from the C library when present.
2017-08-25 22:47:47 +02:00
#---------------------------------------------------------------------------------------------------------------------------
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Remove mapping for tablespace 1
delete($oRemapHash{&MANIFEST_TARGET_PGTBLSPC . '/1'});
# Remove checksum to match zeroed files
delete($oManifest{&MANIFEST_SECTION_TARGET_FILE}{'pg_data/base/32768/33000'}{&MANIFEST_SUBKEY_CHECKSUM});
delete($oManifest{&MANIFEST_SECTION_TARGET_FILE}{'pg_data/base/32768/33001'}{&MANIFEST_SUBKEY_CHECKSUM});
delete($oManifest{&MANIFEST_SECTION_TARGET_FILE}{'pg_tblspc/2/PG_9.4_201409291/32768/tablespace2.txt'}
{&MANIFEST_SUBKEY_CHECKSUM});
delete($oManifest{&MANIFEST_SECTION_TARGET_FILE}{'pg_tblspc/2/PG_9.4_201409291/32768/tablespace2c.txt'}
{&MANIFEST_SUBKEY_CHECKSUM});
$oHostDbMaster->restore(
Move restore test infrastructure to HostBackup.pm. Required to test restores on the backup server, a fairly common scenario. Improve the restore function to accept optional parameters rather than a long list of parameters. In passing, clean up extraneous use of strType and strComment variables.
2017-12-04 00:08:49 +02:00
'selective restore 16384', cfgDefOptionDefault(CFGCMD_RESTORE, CFGOPT_SET),
{rhExpectedManifest => \%oManifest, rhRemapHash => \%oRemapHash, bDelta => true,
Reduce log level for all expect tests to detail. The C code is designed to be efficient rather than deterministic at the debug log level. As we move more testing from integration to unit tests it makes less sense to try and maintain the expect logs at this log level. Most of the expect logs have already been moved to detail level but mock/all still had tests at debug level. Change the logging defaults in the config file and remove as many references to log-level-console as possible.
2019-05-23 00:23:44 +02:00
strOptionalParam => '--db-include=16384'});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Restore checksum values for next test
$oManifest{&MANIFEST_SECTION_TARGET_FILE}{'pg_data/base/32768/33000'}{&MANIFEST_SUBKEY_CHECKSUM} =
Fix incorrect offline upper bound for ignoring page checksum errors. For offline backups the upper bound was being set to 0x0000FFFF0000FFFF rather than UINT64_MAX. This meant that page checksum errors might be ignored for databases with a lot of past WAL in offline mode. Online mode is not affected since the upper bound is retrieved from pg_start_backup().
2019-07-11 15:13:56 +02:00
'7a16d165e4775f7c92e8cdf60c0af57313f0bf90';
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$oManifest{&MANIFEST_SECTION_TARGET_FILE}{'pg_data/base/32768/33001'}{&MANIFEST_SUBKEY_CHECKSUM} =
'6bf316f11d28c28914ea9be92c00de9bea6d9a6b';
$oManifest{&MANIFEST_SECTION_TARGET_FILE}{'pg_tblspc/2/PG_9.4_201409291/32768/tablespace2.txt'}
{&MANIFEST_SUBKEY_CHECKSUM} = 'dc7f76e43c46101b47acc55ae4d593a9e6983578';
$oManifest{&MANIFEST_SECTION_TARGET_FILE}{'pg_tblspc/2/PG_9.4_201409291/32768/tablespace2c.txt'}
{&MANIFEST_SUBKEY_CHECKSUM} = 'dfcb8679956b734706cf87259d50c88f83e80e66';
# Remove checksum to match zeroed file
delete($oManifest{&MANIFEST_SECTION_TARGET_FILE}{'pg_data/base/16384/17000'}{&MANIFEST_SUBKEY_CHECKSUM});
$oHostDbMaster->restore(
Move restore test infrastructure to HostBackup.pm. Required to test restores on the backup server, a fairly common scenario. Improve the restore function to accept optional parameters rather than a long list of parameters. In passing, clean up extraneous use of strType and strComment variables.
2017-12-04 00:08:49 +02:00
'selective restore 32768', cfgDefOptionDefault(CFGCMD_RESTORE, CFGOPT_SET),
{rhExpectedManifest => \%oManifest, rhRemapHash => \%oRemapHash, bDelta => true,
Reduce log level for all expect tests to detail. The C code is designed to be efficient rather than deterministic at the debug log level. As we move more testing from integration to unit tests it makes less sense to try and maintain the expect logs at this log level. Most of the expect logs have already been moved to detail level but mock/all still had tests at debug level. Change the logging defaults in the config file and remove as many references to log-level-console as possible.
2019-05-23 00:23:44 +02:00
strOptionalParam => '--db-include=32768'});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$oManifest{&MANIFEST_SECTION_TARGET_FILE}{'pg_data/base/16384/17000'}{&MANIFEST_SUBKEY_CHECKSUM} =
'7579ada0808d7f98087a0a586d0df9de009cdc33';
$oHostDbMaster->restore(
Move restore test infrastructure to HostBackup.pm. Required to test restores on the backup server, a fairly common scenario. Improve the restore function to accept optional parameters rather than a long list of parameters. In passing, clean up extraneous use of strType and strComment variables.
2017-12-04 00:08:49 +02:00
'error on invalid id', cfgDefOptionDefault(CFGCMD_RESTORE, CFGOPT_SET),
{rhExpectedManifest => \%oManifest, rhRemapHash => \%oRemapHash, bDelta => true,
iExpectedExitStatus => ERROR_DB_MISSING, strOptionalParam => '--log-level-console=warn --db-include=7777'});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$oHostDbMaster->restore(
Move restore test infrastructure to HostBackup.pm. Required to test restores on the backup server, a fairly common scenario. Improve the restore function to accept optional parameters rather than a long list of parameters. In passing, clean up extraneous use of strType and strComment variables.
2017-12-04 00:08:49 +02:00
'error on system id', cfgDefOptionDefault(CFGCMD_RESTORE, CFGOPT_SET),
{rhExpectedManifest => \%oManifest, rhRemapHash => \%oRemapHash, bDelta => true,
iExpectedExitStatus => ERROR_DB_INVALID, strOptionalParam => '--log-level-console=warn --db-include=1'});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
# Compact Restore
Configuration rules are now pulled from the C library when present.
2017-08-25 22:47:47 +02:00
#---------------------------------------------------------------------------------------------------------------------------
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
executeTest('rm -rf ' . $oHostDbMaster->dbBasePath(2) . "/*");
my $strDbPath = $oHostDbMaster->dbBasePath(2) . '/base';
Storage and IO layer refactor: Refactor storage layer to allow for new repository filesystems using drivers. (Reviewed by Cynthia Shang.) Refactor IO layer to allow for new compression formats, checksum types, and other capabilities using filters. (Reviewed by Cynthia Shang.)
2017-06-09 23:51:41 +02:00
storageTest()->pathCreate($strDbPath, {strMode => '0700'});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$oRemapHash{&MANIFEST_TARGET_PGDATA} = $strDbPath;
delete($oRemapHash{&MANIFEST_TARGET_PGTBLSPC . '/2'});
$oHostDbMaster->restore(
Move restore test infrastructure to HostBackup.pm. Required to test restores on the backup server, a fairly common scenario. Improve the restore function to accept optional parameters rather than a long list of parameters. In passing, clean up extraneous use of strType and strComment variables.
2017-12-04 00:08:49 +02:00
'no tablespace remap', cfgDefOptionDefault(CFGCMD_RESTORE, CFGOPT_SET),
The restore command is implemented entirely in C. For the most part this is a direct migration of the Perl code into C. There is one important behavioral change with regard to how file permissions are handled. The Perl code tried to set ownership as it was in the manifest even when running as an unprivileged user. This usually just led to errors and frustration. The C code works like this: If a restore is run as a non-root user (the typical scenario) then all files restored will belong to the user/group executing pgBackRest. If existing files are not owned by the executing user/group then an error will result if the ownership cannot be updated to the executing user/group. In that case the file ownership will need to be updated by a privileged user before the restore can be retried. If a restore is run as the root user then pgBackRest will attempt to recreate the ownership recorded in the manifest when the backup was made. Only user/group names are stored in the manifest so the same names must exist on the restore host for this to work. If the user/group name cannot be found locally then the user/group of the PostgreSQL data directory will be used and finally root if the data directory user/group cannot be mapped to a name. Reviewed by Cynthia Shang.
2019-09-26 13:52:02 +02:00
{rhExpectedManifest => \%oManifest, rhRemapHash => \%oRemapHash, bTablespace => false,
Reduce log level for all expect tests to detail. The C code is designed to be efficient rather than deterministic at the debug log level. As we move more testing from integration to unit tests it makes less sense to try and maintain the expect logs at this log level. Most of the expect logs have already been moved to detail level but mock/all still had tests at debug level. Change the logging defaults in the config file and remove as many references to log-level-console as possible.
2019-05-23 00:23:44 +02:00
strOptionalParam => '--tablespace-map-all=../../tablespace'});
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
$oManifest{&MANIFEST_SECTION_BACKUP_TARGET}{'pg_tblspc/2'}{&MANIFEST_SUBKEY_PATH} = '../../tablespace/ts2';
$oManifest{&MANIFEST_SECTION_TARGET_LINK}{'pg_data/pg_tblspc/2'}{&MANIFEST_SUBKEY_DESTINATION} = '../../tablespace/ts2';
# Dump out history path at the end to verify all history files are being recorded. This test is only performed locally
# because for some reason sort order is different when this command is executed via ssh (even though the content of the
# directory is identical).
Configuration rules are now pulled from the C library when present.
2017-08-25 22:47:47 +02:00
#---------------------------------------------------------------------------------------------------------------------------
Repository encryption support. Contributed by Cynthia Shang.
2017-11-06 19:51:12 +02:00
if (!$bRemote && !$bS3)
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
{
Make ls ordering deterministic in mock/all test.
2018-07-02 02:02:37 +02:00
executeTest('ls -1Rtr ' . storageRepo()->pathGet('backup/' . $self->stanza() . '/' . PATH_BACKUP_HISTORY),
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
{oLogTest => $self->expect(), bRemote => $bRemote});
}
Fixed the backup command so the backup-standby option is reset (and the backup proceeds on the master) if the standby is not configured and/or reachable. Fixed by Cynthia Shang.
2017-05-12 22:05:44 +02:00
# Test backup from standby warning that standby not configured so option reset
Configuration rules are now pulled from the C library when present.
2017-08-25 22:47:47 +02:00
#---------------------------------------------------------------------------------------------------------------------------
Full/Synthetic test refactor. * Combine hardlink and non/compressed in synthetic tests to reduce test time and improve coverage. * Change log level of hardlink logging to detail. * Cast size in S3 manifest to integer.
2017-06-15 21:32:10 +02:00
if (!defined($oHostDbStandby))
Fixed the backup command so the backup-standby option is reset (and the backup proceeds on the master) if the standby is not configured and/or reachable. Fixed by Cynthia Shang.
2017-05-12 22:05:44 +02:00
{
$strBackup = $oHostBackup->backup(
$strType, 'option backup-standby reset - backup performed from master', {oExpectedManifest => \%oManifest,
Configuration rules are now pulled from the C library when present.
2017-08-25 22:47:47 +02:00
strOptionalParam => '--log-level-console=info --' . cfgOptionName(CFGOPT_BACKUP_STANDBY)});
Fixed the backup command so the backup-standby option is reset (and the backup proceeds on the master) if the standby is not configured and/or reachable. Fixed by Cynthia Shang.
2017-05-12 22:05:44 +02:00
}
Split test modules into separate files. Makes the code more maintainable. Tests are dynamically loaded by name rather than requiring an if-else block.
2016-12-23 15:22:59 +02:00
}
}
1;
Reference in New Issue Copy Permalink