db/pgbackrest
1
0
Fork 0
mirror of https://github.com/pgbackrest/pgbackrest.git synced 2025-09-16 09:06:18 +02:00
Code Issues Releases Activity

Add detail logging for expired archive path.

Browse Source 
When archive expiration has a large number of files to remove it may look like the process has hung, at least at higher log levels.

Add a log message at detail level to show that progress is being made.
This commit is contained in:
Stefan Fercot
2025-02-17 18:51:51 +01:00
committed by GitHub
parent 4dcfa9ef59
commit 2155a12a3d
3 changed files with 21 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
doc/xml/release/2025/2.55.0.xml
View File

@@ -77,6 +77,21 @@
<p>Use <proper>lz4</proper> for protocol compression.</p>
</release-item>
<release-item>
<commit subject="Add detail logging to expire test."/>
<commit subject="Add detail logging for expired archive path.">
<github-issue id="2543"/>
<github-pull-request id="2559"/>
</commit>
<release-item-contributor-list>
<release-item-contributor id="stefan.fercot"/>
<release-item-reviewer id="david.steele"/>
</release-item-contributor-list>
<p>Add detail logging for expired archive path.</p>
</release-item>
<release-item>
<github-pull-request id="2472"/>

4
src/command/expire/expire.c
View File

@@ -677,6 +677,10 @@ removeExpiredArchive(const InfoBackup *const infoBackup, const bool timeBasedFul
.recurse = true);
}
LOG_DETAIL_FMT(
"%s: %s remove archive path %s", cfgOptionGroupName(cfgOptGrpRepo, repoIdx),
strZ(archiveId), strZ(walPath));
archiveExpire.total++;
archiveExpire.stop = strDup(walPath);

2
test/src/module/command/expireTest.c
View File

@@ -791,6 +791,8 @@ testRun(void)
" start = 000000020000000000000007, stop = 000000020000000000000007\n"
"P00 DETAIL: [DRY-RUN] repo1: 9.4-1 archive retention on backup 20181119-152800F_20181119-152252D,"
" start = 000000020000000000000009\n"
"P00 DETAIL: [DRY-RUN] repo1: 9.4-1 remove archive path 0000000100000000\n"
"P00 DETAIL: [DRY-RUN] repo1: 9.4-1 remove archive path 0000000100000001\n"
"P00 INFO: [DRY-RUN] repo1: 9.4-1 remove archive, start = 0000000100000000, stop = 0000000100000001\n"
"P00 INFO: [DRY-RUN] repo1: 9.4-1 remove archive, start = 000000020000000000000008, stop = 000000020000000000000008\n"
"P00 DETAIL: [DRY-RUN] repo1: 10-2 archive retention on backup 20181119-152900F, start = 000000010000000000000003\n"