db/pgbackrest
1
0
Fork 0
mirror of https://github.com/pgbackrest/pgbackrest.git synced 2026-06-20 01:17:49 +02:00
Code Issues Releases Activity

Remove explicit versioning from macros using versioned PostgreSQL types.

Browse Source 
Some of these macros have required different implementations according to PostgreSQL version but none of them do now.

The idea of versioning them even when not required was that it would reduce churn but in fact churn is increased because PostgreSQL versions expire far more often than these macros need version specific implementations.
This commit is contained in:
David Steele
2025-11-05 22:46:54 +02:00
parent 00621b6b79
commit 8749601e6d
2 changed files with 0 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/postgres/interface/version.intern.h
-42
View File
@@ -14,10 +14,6 @@ Determine if the supplied pg_control is for this version of PostgreSQL. When CAT
be accepted as a range that lasts until the end of the encoded year. This allows pgBackRest to work with PostgreSQL during the
alpha/beta/rc period without needing to be updated, unless of course the actual interface changes.
***********************************************************************************************************************************/
#if PG_VERSION > PG_VERSION_MAX
#elif PG_VERSION >= PG_VERSION_95
#ifdef CATALOG_VERSION_NO_MAX
#define PG_INTERFACE_CONTROL_IS(version) \
@@ -47,15 +43,9 @@ alpha/beta/rc period without needing to be updated, unless of course the actual
#endif
#endif
/***********************************************************************************************************************************
Read the version specific pg_control into a general data structure
***********************************************************************************************************************************/
#if PG_VERSION > PG_VERSION_MAX
#elif PG_VERSION >= PG_VERSION_95
#define PG_INTERFACE_CONTROL(version) \
static PgControl \
pgInterfaceControl##version(const uint8_t *controlFile) \
@@ -74,15 +64,9 @@ Read the version specific pg_control into a general data structure
}; \
}
#endif
/***********************************************************************************************************************************
Get control crc offset
***********************************************************************************************************************************/
#if PG_VERSION > PG_VERSION_MAX
#elif PG_VERSION >= PG_VERSION_95
#define PG_INTERFACE_CONTROL_CRC_OFFSET(version) \
static size_t \
pgInterfaceControlCrcOffset##version(void) \
@@ -90,15 +74,9 @@ Get control crc offset
return offsetof(ControlFileData, crc); \
}
#endif
/***********************************************************************************************************************************
Invalidate control checkpoint. PostgreSQL skips the first segment so any LSN in that segment is invalid.
***********************************************************************************************************************************/
#if PG_VERSION > PG_VERSION_MAX
#elif PG_VERSION >= PG_VERSION_93
#define PG_INTERFACE_CONTROL_CHECKPOINT_INVALIDATE(version) \
static void \
pgInterfaceControlCheckpointInvalidate##version(uint8_t *const controlFile) \
@@ -106,15 +84,9 @@ Invalidate control checkpoint. PostgreSQL skips the first segment so any LSN in
((ControlFileData *)controlFile)->checkPoint = PG_CONTROL_CHECKPOINT_INVALID; \
}
#endif
/***********************************************************************************************************************************
Get the control version
***********************************************************************************************************************************/
#if PG_VERSION > PG_VERSION_MAX
#elif PG_VERSION >= PG_VERSION_95
#define PG_INTERFACE_CONTROL_VERSION(version) \
static uint32_t \
pgInterfaceControlVersion##version(void) \
@@ -122,15 +94,9 @@ Get the control version
return PG_CONTROL_VERSION; \
}
#endif
/***********************************************************************************************************************************
Determine if the supplied WAL is for this version of PostgreSQL
***********************************************************************************************************************************/
#if PG_VERSION > PG_VERSION_MAX
#elif PG_VERSION >= PG_VERSION_95
#define PG_INTERFACE_WAL_IS(version) \
static bool \
pgInterfaceWalIs##version(const uint8_t *walFile) \
@@ -140,15 +106,9 @@ Determine if the supplied WAL is for this version of PostgreSQL
return ((const XLogPageHeaderData *)walFile)->xlp_magic == XLOG_PAGE_MAGIC; \
}
#endif
/***********************************************************************************************************************************
Read the version specific WAL header into a general data structure
***********************************************************************************************************************************/
#if PG_VERSION > PG_VERSION_MAX
#elif PG_VERSION >= PG_VERSION_95
#define PG_INTERFACE_WAL(version) \
static PgWal \
pgInterfaceWal##version(const uint8_t *walFile) \
@@ -161,5 +121,3 @@ Read the version specific WAL header into a general data structure
.size = ((const XLogLongPageHeaderData *)walFile)->xlp_seg_size, \
}; \
}
#endif
test/src/common/harnessPostgres/harnessVersion.intern.h
-18
View File
@@ -14,10 +14,6 @@ Macros to create harness functions per PostgreSQL version.
/***********************************************************************************************************************************
Get the catalog version
***********************************************************************************************************************************/
#if PG_VERSION > PG_VERSION_MAX
#elif PG_VERSION >= PG_VERSION_95
#define HRN_PG_INTERFACE_CATALOG_VERSION(version) \
uint32_t \
hrnPgInterfaceCatalogVersion##version(void) \
@@ -25,15 +21,9 @@ Get the catalog version
return CATALOG_VERSION_NO; \
}
#endif
/***********************************************************************************************************************************
Create a pg_control file
***********************************************************************************************************************************/
#if PG_VERSION > PG_VERSION_MAX
#elif PG_VERSION >= PG_VERSION_95
#define HRN_PG_INTERFACE_CONTROL_TEST(version) \
void \
hrnPgInterfaceControl##version( \
@@ -59,15 +49,9 @@ Create a pg_control file
((ControlFileData *)buffer)->crc = crc == 0 ? crc32cOne(buffer, offsetof(ControlFileData, crc)) : crc; \
}
#endif
/***********************************************************************************************************************************
Create a WAL file
***********************************************************************************************************************************/
#if PG_VERSION > PG_VERSION_MAX
#elif PG_VERSION >= PG_VERSION_95
#define HRN_PG_INTERFACE_WAL_TEST(version) \
void \
hrnPgInterfaceWal##version(const unsigned int magic, const PgWal pgWal, uint8_t *const buffer) \
@@ -78,8 +62,6 @@ Create a WAL file
((XLogLongPageHeaderData *)buffer)->xlp_seg_size = pgWal.size; \
}
#endif
/***********************************************************************************************************************************
Call all macros with a single macro to make the vXXX.c files as simple as possible
***********************************************************************************************************************************/