You've already forked pgbackrest
mirror of
https://github.com/pgbackrest/pgbackrest.git
synced 2026-06-20 01:17:49 +02:00
v0.11: Minor fixes
Tweaking a few settings after running backups for about a month. * Removed master_stderr_discard option on database SSH connections. There have been occasional lockups and they could be related issues originally seen in the file code. * Changed lock file conflicts on backup and expire commands to ERROR. They were set to DEBUG due to a copy-and-paste from the archive locks.
This commit is contained in:
@@ -6,6 +6,14 @@ Simple Postgres Backup and Restore
|
||||
release notes
|
||||
=============
|
||||
|
||||
v0.11: Minor fixes
|
||||
|
||||
Tweaking a few settings after running backups for about a month.
|
||||
|
||||
* Removed master_stderr_discard option on database SSH connections. There have been occasional lockups and they could be related issues originally seen in the file code.
|
||||
|
||||
* Changed lock file conflicts on backup and expire commands to ERROR. They were set to DEBUG due to a copy-and-paste from the archive locks.
|
||||
|
||||
v0.10: Backup and archiving are functional
|
||||
|
||||
This version has been put into production at Resonate, so it does work, but there are a number of major caveats.
|
||||
|
||||
+2
-2
@@ -471,7 +471,7 @@ if ($strOperation eq OP_BACKUP)
|
||||
|
||||
if (!lock_file_create($strLockFile))
|
||||
{
|
||||
&log(DEBUG, "backup process is already running for stanza ${strStanza} - exiting");
|
||||
&log(ERROR, "backup process is already running for stanza ${strStanza} - exiting");
|
||||
exit 0
|
||||
}
|
||||
|
||||
@@ -493,7 +493,7 @@ if ($strOperation eq OP_EXPIRE)
|
||||
|
||||
if (!lock_file_create($strLockFile))
|
||||
{
|
||||
&log(DEBUG, "expire process is already running for stanza ${strStanza} - exiting");
|
||||
&log(ERROR, "expire process is already running for stanza ${strStanza} - exiting");
|
||||
exit 0
|
||||
}
|
||||
|
||||
|
||||
+1
-1
@@ -38,7 +38,7 @@ sub BUILD
|
||||
&log(TRACE, "connecting to database ssh host $self->{strDbHost}");
|
||||
|
||||
# !!! This could be improved by redirecting stderr to a file to get a better error message
|
||||
$self->{oDbSSH} = Net::OpenSSH->new($self->{strDbHost}, master_stderr_discard => true, user => $self->{strDbUser});
|
||||
$self->{oDbSSH} = Net::OpenSSH->new($self->{strDbHost}, user => $self->{strDbUser});
|
||||
$self->{oDbSSH}->error and confess &log(ERROR, "unable to connect to $self->{strDbHost}: " . $self->{oDbSSH}->error);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user