db/pgbackrest
1
0
Fork 0
mirror of https://github.com/pgbackrest/pgbackrest.git synced 2025-09-16 09:06:18 +02:00
Code Issues Releases Activity

Update invalid address check in common/io-tls unit test.

Browse Source 
The prior check would result in a segfault from musl libc, which is understandable but not OK for a test.

Instead set all the flags to get the expected invalid result.

The second invalid test was not required for coverage so remove it. This was likely added before the earlier test was required for additional coverage.
This commit is contained in:
David Steele
2025-05-31 10:08:13 -04:00
parent cb673225e9
commit a30442f168
1 changed files with 1 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
test/src/module/common/ioTlsTest.c
View File

@@ -188,7 +188,7 @@ testRun(void)
TEST_RESULT_Z(logBuf, "{host: {\"" TEST_ADDR_LOOP_HOST "\"}, port: 443, list: [::1, 127.0.0.1]}", "check log");
// Munge address so it is invalid
((AddressInfoItem *)lstGet(addrInfo->pub.list, 0))->info->ai_addr = NULL;
((AddressInfoItem *)lstGet(addrInfo->pub.list, 0))->info->ai_addr->sa_family = UINT16_MAX;
TEST_RESULT_STR_Z(addrInfoToStr(addrInfoGet(addrInfo, 0)->info), "invalid", "check invalid");
// -------------------------------------------------------------------------------------------------------------------------
@@ -272,12 +272,6 @@ testRun(void)
TEST_RESULT_VOID(addrInfoFree(addrInfo), "free");
#endif
// -------------------------------------------------------------------------------------------------------------------------
TEST_TITLE("addrInfoToStr (invalid)");
struct addrinfo addrInfoInvalid = {0};
TEST_RESULT_STR_Z(addrInfoToStr(&addrInfoInvalid), "invalid", "check invalid");
}
// *****************************************************************************************************************************