1
0
mirror of https://github.com/vcmi/vcmi.git synced 2025-02-03 13:01:33 +02:00

Resource converter changes after review.

This commit is contained in:
krs 2023-01-18 19:14:26 +02:00 committed by Ivan Savenko
parent 774a8e024c
commit 05971d5bb5
2 changed files with 4 additions and 4 deletions

View File

@ -29,7 +29,7 @@ void ResourceConverter::convertExtractedResourceFiles(ConversionOptions conversi
std::vector<std::string> defFiles = { "TwCrPort.def", "CPRSMALL.def", "FlagPort.def", "ITPA.def", "ITPt.def", "Un32.def", "Un44.def" };
if(conversionOptions.splitDefs)
splitDefFiles(spritesPath, defFiles, conversionOptions.deleteOriginals);
splitDefFiles(defFiles, spritesPath, conversionOptions.deleteOriginals);
if(conversionOptions.convertPcxToPng)
doConvertPcxToPng(imagesPath, conversionOptions.deleteOriginals);
@ -83,10 +83,10 @@ void ResourceConverter::splitDefFile(const std::string & fileName, const bfs::pa
logGlobal->error("Def File Split error! " + fileName);
}
void ResourceConverter::splitDefFiles(const bfs::path & sourceFolder, std::vector<std::string> defFileNames, bool deleteOriginals)
void ResourceConverter::splitDefFiles(const std::vector<std::string> & defFileNames, const bfs::path & sourceFolder, bool deleteOriginals)
{
logGlobal->info("Splitting Def Files from folder: %s ...\n", sourceFolder);
for(std::string defFilename : defFileNames)
for(const auto & defFilename : defFileNames)
splitDefFile(defFilename, sourceFolder, deleteOriginals);
}

View File

@ -53,5 +53,5 @@ private:
/** Splits the given .def files into individual images.
* For each .def file, the resulting images will be output in the same folder, in a subfolder (named just like the .def file)
*/
static void splitDefFiles(const bfs::path & sourceFolder, std::vector<std::string> defFileNames, bool deleteOriginals);
static void splitDefFiles(const std::vector<std::string> & defFileNames, const bfs::path & sourceFolder, bool deleteOriginals);
};