games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-10-31 00:07:39 +02:00
Code Issues Releases Activity

Only delete CQuest in CMap destructor and not with IQuestObject

Browse Source 
Quest information must remain accessible even if map object removed. Fix issue 2472
This commit is contained in:
Arseniy Shestakov
2016-09-13 01:30:47 +03:00
parent 2543e068ac
commit 1e60ba6516
2 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/mapObjects/CQuest.cpp
View File

@@ -498,7 +498,9 @@ IQuestObject::IQuestObject():
IQuestObject::~IQuestObject()
{
delete quest;
///Information about quest should remain accessible even if IQuestObject removed from map
///All CQuest objects are freed in CMap destructor
//delete quest;
}
bool IQuestObject::checkQuest(const CGHeroInstance* h) const

3
lib/mapping/CMap.cpp
View File

@@ -245,6 +245,9 @@ CMap::~CMap()
for(auto obj : objects)
obj.dellNull();
for(auto quest : quests)
quest.dellNull();
}
void CMap::removeBlockVisTiles(CGObjectInstance * obj, bool total)