games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2026-06-19 22:57:37 +02:00
Code Issues Releases Activity

Merge pull request #6423 from kdmcser/only_commander_left_crash

Browse Source 
Fix crash when losing battle vs neutral creatures (null winnerHero commander)
This commit is contained in:
Ivan Savenko
2025-12-10 20:38:37 +02:00
committed by GitHub
parent e58ab1639b 8c68102909
commit 358afd6f0c
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/battles/BattleResultProcessor.cpp
+1 -2
View File
@@ -416,8 +416,7 @@ void BattleResultProcessor::battleFinalize(const BattleID & battleID, const Batt
{
winnerHero = (*battle)->battleGetFightingHero(finishingBattle->winnerSide);
loserHero = (*battle)->battleGetFightingHero(CBattleInfoEssentials::otherSide(finishingBattle->winnerSide));
auto commander = winnerHero->getCommander();
winnerHasUnitsLeft = winnerHero ? winnerHero->stacksCount() > 0 || (commander && commander->alive) : true;
winnerHasUnitsLeft = winnerHero ? winnerHero->stacksCount() > 0 || (winnerHero->getCommander() && winnerHero->getCommander()->alive) : true;
}
BattleResultsApplied resultsApplied;