games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-08-13 19:54:17 +02:00
Code Issues Releases Activity

Fix potential infinite loop

Browse Source
This commit is contained in:
Tomasz Zieliński
2023-06-12 20:32:58 +02:00
parent 983633d73b
commit 3d3c97bf93
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/rmg/modificators/TreasurePlacer.cpp
View File

@@ -763,17 +763,13 @@ void TreasurePlacer::createTreasures(ObjectManager& manager)
//this is squared distance for optimization purposes //this is squared distance for optimization purposes
const float minDistance = std::max<float>((125.f / totalDensity), 1.0f); const float minDistance = std::max<float>((125.f / totalDensity), 1.0f);
for (size_t i = 0; i < count;) for (size_t i = 0; i < count; i++)
{ {
auto treasurePileInfos = prepareTreasurePile(t); auto treasurePileInfos = prepareTreasurePile(t);
if (treasurePileInfos.empty()) if (treasurePileInfos.empty())
{ {
continue; continue;
} }
else
{
i++;
}
int value = std::accumulate(treasurePileInfos.begin(), treasurePileInfos.end(), 0, [](int v, const ObjectInfo* oi) {return v + oi->value; }); int value = std::accumulate(treasurePileInfos.begin(), treasurePileInfos.end(), 0, [](int v, const ObjectInfo* oi) {return v + oi->value; });