games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-03-25 21:38:59 +02:00
Code Issues Releases Activity

Enable xbrz2 by default on mobile systems

Browse Source 
Since upscaling is now performed in background there should be no
noticeable lags on most systems.

To be safe - it will only be enabled on systems with over 2 Gb RAM, to
exclude oldest hardware

This only affects autoselection. If upscaling filter was selected by
player explicitly, these changes will have no effect
This commit is contained in:
Ivan Savenko 2025-02-07 14:27:37 +00:00
parent 2beb4c6aa4
commit 3ed599bef3
1 changed files with 6 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
client/renderSDL/ScreenHandler.cpp
View File

@ -357,34 +357,23 @@ EUpscalingFilter ScreenHandler::loadUpscalingFilter() const
return filter;
// else - autoselect
#ifdef VCMI_MOBILE
// to help with performance - only if player explicitly enabled xbrz
return EUpscalingFilter::NONE;
#else
Point outputResolution = getRenderResolution();
Point logicalResolution = getPreferredLogicalResolution();
float scaleX = static_cast<float>(outputResolution.x) / logicalResolution.x;
float scaleY = static_cast<float>(outputResolution.x) / logicalResolution.x;
float scaling = std::min(scaleX, scaleY);
int systemMemoryMb = SDL_GetSystemRAM();
if (scaling <= 1.001f)
return EUpscalingFilter::NONE; // running at original resolution or even lower than that - no need for xbrz
else
return EUpscalingFilter::XBRZ_2;
#endif
#if 0
// Old version, most optimal, but rather performance-heavy
if (scaling <= 1.001f)
return EUpscalingFilter::NONE; // running at original resolution or even lower than that - no need for xbrz
if (scaling <= 2.001f)
return EUpscalingFilter::XBRZ_2; // resolutions below 1200p (including 1080p / FullHD)
if (scaling <= 3.001f)
return EUpscalingFilter::XBRZ_3; // resolutions below 2400p (including 1440p and 2160p / 4K)
if (systemMemoryMb < 2048)
return EUpscalingFilter::NONE; // xbrz2 may use ~1.0 - 1.5 Gb of RAM and has notable CPU cost - avoid on low-spec hardware
return EUpscalingFilter::XBRZ_4; // Only for massive displays, e.g. 8K
#endif
// Only using xbrz2 for autoselection.
// Higher options may have high system requirements and should be only selected explicitly by player
return EUpscalingFilter::XBRZ_2;
}
void ScreenHandler::selectUpscalingFilter()