games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-11-25 22:42:04 +02:00
Code Issues Releases Activity

Fix text formatting, fix todo's

Browse Source
This commit is contained in:
Ivan Savenko
2024-04-09 13:16:44 +03:00
parent 18ece6dcf6
commit 42616cf4e8
8 changed files with 64 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
lib/networkPacks/NetPacksLib.cpp
View File

@@ -1004,27 +1004,6 @@ void GiveBonus::applyGs(CGameState *gs)
auto b = std::make_shared<Bonus>(bonus);
cbsn->addNewBonus(b);
if(b->description.empty())
{
if((bonus.type == BonusType::LUCK || bonus.type == BonusType::MORALE)
&& (bonus.source == BonusSource::OBJECT_TYPE || bonus.source == BonusSource::OBJECT_INSTANCE))
{
//?could use allways when Type == BonusDuration::Type::ONE_BATTLE
if (bonus.val > 0)
b->description.appendTextID("core.arraytxt.110"); //+%d Temporary until next battle"
else
b->description.appendTextID("core.arraytxt.109"); //-%d Temporary until next battle"
}
else
{
logGlobal->debug("Empty bonus decription. Type=%d", (int) bonus.type);
}
}
// Some of(?) versions of H3 use " %s" here instead of %d. Try to replace both of them
//boost::replace_first(descr, "%d", std::to_string(std::abs(bonus.val))); // " +/-%d Temporary until next battle
//boost::replace_first(descr, " %s", boost::str(boost::format(" %+d") % bonus.val)); // " %s" in arraytxt.69, fountian of fortune
}
void ChangeObjPos::applyGs(CGameState *gs)